Change in vdsm[master]: gluster: command to create a public key file

Hello Bala.FA,

I'd like you to do a code review.  Please visit

http://gerrit.ovirt.org/17644

to review the following change.

Change subject: gluster: command to create a public key file
......................................................................

gluster: command to create a public key file

This executes the command to create a public key file
which will have public keys of all the hosts of source cluster.
This is needed for password-less communication between
slave cluster hosts during geo-replication

Change-Id: If8c979a89ce11a1622819c474b59dcf088733594
Signed-off-by: ndarshan 
---
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
2 files changed, 20 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/17644/1

diff --git a/vdsm/gluster/cli.py b/vdsm/gluster/cli.py
index bac6d1c..64529ae 100644
--- a/vdsm/gluster/cli.py
+++ b/vdsm/gluster/cli.py
@@ -897,3 +897,12 @@
         return _parseVolumeProfileInfo(xmltree, nfs)
     except _etreeExceptions:
         raise ge.GlusterXmlErrorException(err=[etree.tostring(xmltree)])
+
+@makePublic
+def createPublicKeyFile():
+    command = _getGlusterSystemCmd() + ["execute", "gsec_create"]
+    rc, out, err = _execGluster(command)
+    if rc:
+        raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc, out, err)
+    else:
+	return True
diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py
index c569a9e..1ee73bb 100644
--- a/vdsm/gluster/exception.py
+++ b/vdsm/gluster/exception.py
@@ -484,3 +484,14 @@
         prefix = "%s: " % (action)
         self.message = prefix + "Service action is not supported"
         self.err = [self.message]
+
+#geo-replication
+class GlusterGeoRepException(GlusterException):
+    code = 4560
+    message = "Gluster Geo-Replication Exception"
+
+ 
+class GlusterGeoRepPublicKeyFileCreationFailedException(GlusterGeoRepException):
+    code = 4561
+    message = "Creation of public key file failed"
+

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create a public key file
......................................................................

Patch Set 1: Code-Review-1

Build Unstable

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3705/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3621/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2814/ : SUCCESS

Timothy Asir has posted comments on this change.

Change subject: gluster: command to create a public key file
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

....................................................
File vdsm/gluster/cli.py
Line 904:     rc, out, err = _execGluster(command)
Line 905:     if rc:
Line 906:         raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc, out, err)
Line 907:     else:
Line 908: 	return True
return the key file (common secret pub file path which gluster cli provides) path instead of boolean expression and validate the file if possible.

....................................................
File vdsm/gluster/exception.py
Line 489: class GlusterGeoRepException(GlusterException):
Line 490:     code = 4560
Line 491:     message = "Gluster Geo-Replication Exception"
Line 492: 
Line 493:  
Remove this white space
Line 494: class GlusterGeoRepPublicKeyFileCreationFailedException(GlusterGeoRepException):
Line 495:     code = 4561
Line 496:     message = "Creation of public key file failed"

Timothy Asir has posted comments on this change.

Change subject: gluster: command to create a public key file
......................................................................

Patch Set 1: Code-Review-1

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create a public key file
......................................................................

Patch Set 2: Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3716/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3632/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2825/ : FAILURE

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create a public key file
......................................................................

Patch Set 3: Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3722/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3638/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2831/ : FAILURE

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create a public key file
......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3723/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3639/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2832/ : SUCCESS

Timothy Asir has posted comments on this change.

Change subject: gluster: command to create a public key file
......................................................................

Patch Set 4:

(4 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-08-05 09:59:19 +0530
Line 4: Commit:     ndarshan 
Line 5: CommitDate: 2013-08-06 11:20:37 +0530
Line 6: 
Line 7: gluster: command to create a public key file
Please add the word 'geo-replication' in the title. It will give a clear picture like why do we need this verb.
Line 8: 
Line 9: This executes the command to create a public key file which
Line 10: will have public keys of all the hosts of source cluster.It returns
Line 11: the path of the generated file. This is needed for password-less

Line 9: This executes the command to create a public key file which
Line 10: will have public keys of all the hosts of source cluster.It returns
Line 11: the path of the generated file. This is needed for password-less
Line 12: communication between slave cluster hosts during geo-replication
Line 13: 
it would be so nice if you could specify the return type/structure here!
Line 14: Change-Id: If8c979a89ce11a1622819c474b59dcf088733594

....................................................
File vdsm/gluster/cli.py
Line 897:         return _parseVolumeProfileInfo(xmltree, nfs)
Line 898:     except _etreeExceptions:
Line 899:         raise ge.GlusterXmlErrorException(err=[etree.tostring(xmltree)])
Line 900: 
Line 901: 
please update api.py and vdsClientGluster.py file also. So that one can quickly test and verify this command.
Line 902: @makePublic
Line 903: def createPublicKeyFile():
Line 904:     command = _getGlusterSystemCmd() + ["execute", "gsec_create"]
Line 905:     rc, out, err = _execGluster(command)

Line 902: @makePublic
Line 903: def createPublicKeyFile():
Line 904:     command = _getGlusterSystemCmd() + ["execute", "gsec_create"]
Line 905:     rc, out, err = _execGluster(command)
Line 906:     temp = out.partition('/')
you can avoid this temp variable here!
Line 907:     path = '/' + temp[-1]
Line 908:     if rc:
Line 909:         raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc,
Line 910:                                                                    out, err)

Timothy Asir has posted comments on this change.

Change subject: gluster: command to create a public key file
......................................................................

Patch Set 4: Code-Review-1

(1 comment)

....................................................
File vdsm/gluster/cli.py
Line 901: 
Line 902: @makePublic
Line 903: def createPublicKeyFile():
Line 904:     command = _getGlusterSystemCmd() + ["execute", "gsec_create"]
Line 905:     rc, out, err = _execGluster(command)
first check rc, if rc is success then return the well know path.
Line 906:     temp = out.partition('/')
Line 907:     path = '/' + temp[-1]
Line 908:     if rc:
Line 909:         raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc,

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create a public key file
......................................................................

Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3737/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3653/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2846/ : SUCCESS

Change in vdsm[master]: gluster Geo-replication: command to create a public key file

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster Geo-replication: command to create a public key file
......................................................................

Patch Set 6:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3755/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3671/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2864/ : SUCCESS

Change in vdsm[master]: gluster Geo-replication: command to create a geo-replication...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster Geo-replication: command to create a geo-replication session
......................................................................

Patch Set 7:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3796/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3712/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2905/ : SUCCESS

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 8:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3907/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3824/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3018/ : SUCCESS

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

Timothy Asir has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 8: Code-Review+1

(1 comment)

....................................................
File vdsm/gluster/cli.py
Line 905:     if rc:
Line 906:         raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc,
Line 907:                                                                    out, err)
Line 908:     path = out.partition('/')
Line 909:     if not os.path.isfile('/'+path):
missing whitespace around operator
Line 910:         raise ge.GlusterGeoRepPublicKeyFileDoesNotExistException(rc, out, err)
Line 911:     else:
Line 912:         return True
Line 913:

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

Timothy Asir has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 8:

(3 comments)

....................................................
File vdsm/gluster/exception.py
Line 492:     message = "Gluster Geo-Replication Exception"
Line 493: 
Line 494: 
Line 495: class GlusterGeoRepPublicKeyFileCreationFailedException(GlusterGeoRepException
Line 496:                                                         ):
change the class name more consistent

you can change like GlusterGeoRepPublicKeyFileCreateFailedException
Line 497:     code = 4561
Line 498:     message = "Creation of public key file failed"
Line 499: 
Line 500:

....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 403: {'command': {'class': 'GlusterGeoRep', 'name': 'create'},
Line 404:  'data': {'masterVolName': 'str', 'slaveHost': 'str', 'slaveVolName': 'str', 'Force': 'bool'},
Line 405:  'returns': 'bool'}
Line 406: 
Line 407: 
remove this extra line
Line 408: 
Line 409: ##
Line 410: # @GlusterGeoRep.delete:
Line 411: #

Line 417: #
Line 418: # @slaveVolName:   is an available existing volume name in the slave node
Line 419: #
Line 420: # Returns:
Line 421: # True if session is successfully Deleted
change the word 'Deleted' into 'deleted'
Line 422: #
Line 423: # Since: 4.10.3
Line 424: ##
Line 425: {'command': {'class': 'GlusterGeoRep', 'name': 'delete'},

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

Timothy Asir has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 8: Code-Review-1

(3 comments)

....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 374:  'returns': 'GlusterServicesStatusInfo'}
Line 375: 
Line 376: ## Category: @GlusterGeoReplication ######################################################
Line 377: ##
Line 378: # @GlusterGeoReplication:
Check the name and change accordingly.
you can change into "GlusterGeoRep"
Line 379: #
Line 380: # Gluster Geo Replication object.
Line 381: #
Line 382: # Since: 4.10.3

Line 392: # @mastervolname:    is an existing volume name in the master node
Line 393: #
Line 394: # @slavehost:    is remote slave host name or ip
Line 395: #
Line 396: # @slaveVolName:   is an available existing volume name in the slave node
use consistent casing
Line 397: #
Line 398: # Returns:
Line 399: # True if session is successfully created
Line 400: #

Line 400: #
Line 401: # Since: 4.10.3
Line 402: ##
Line 403: {'command': {'class': 'GlusterGeoRep', 'name': 'create'},
Line 404:  'data': {'masterVolName': 'str', 'slaveHost': 'str', 'slaveVolName': 'str', 'Force': 'bool'},
check the name "masterVolName", "slaveHost" which are not defined.
"Force" is not defined
Line 405:  'returns': 'bool'}
Line 406: 
Line 407: 
Line 408:

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 9:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4021/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3132/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3939/ : SUCCESS

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 10: Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4025/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3136/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3943/ : SUCCESS

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

ndarshan has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 8:

(7 comments)

....................................................
File vdsm/gluster/cli.py
Line 905:     if rc:
Line 906:         raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc,
Line 907:                                                                    out, err)
Line 908:     path = out.partition('/')
Line 909:     if not os.path.isfile('/'+path):
Done
Line 910:         raise ge.GlusterGeoRepPublicKeyFileDoesNotExistException(rc, out, err)
Line 911:     else:
Line 912:         return True
Line 913:

....................................................
File vdsm/gluster/exception.py
Line 492:     message = "Gluster Geo-Replication Exception"
Line 493: 
Line 494: 
Line 495: class GlusterGeoRepPublicKeyFileCreationFailedException(GlusterGeoRepException
Line 496:                                                         ):
Done
Line 497:     code = 4561
Line 498:     message = "Creation of public key file failed"
Line 499: 
Line 500:

....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 374:  'returns': 'GlusterServicesStatusInfo'}
Line 375: 
Line 376: ## Category: @GlusterGeoReplication ######################################################
Line 377: ##
Line 378: # @GlusterGeoReplication:
Instead of having a separate category, I will add the following two under GlusterVolume category which is already created in patch [WIP]vdsmapi: gluster: vdsmapi schema definitions for existing gluster verbs. I will make my patch dependent to that patch.
Line 379: #
Line 380: # Gluster Geo Replication object.
Line 381: #
Line 382: # Since: 4.10.3

Line 392: # @mastervolname:    is an existing volume name in the master node
Line 393: #
Line 394: # @slavehost:    is remote slave host name or ip
Line 395: #
Line 396: # @slaveVolName:   is an available existing volume name in the slave node
Done
Line 397: #
Line 398: # Returns:
Line 399: # True if session is successfully created
Line 400: #

Line 400: #
Line 401: # Since: 4.10.3
Line 402: ##
Line 403: {'command': {'class': 'GlusterGeoRep', 'name': 'create'},
Line 404:  'data': {'masterVolName': 'str', 'slaveHost': 'str', 'slaveVolName': 'str', 'Force': 'bool'},
Done
Line 405:  'returns': 'bool'}
Line 406: 
Line 407: 
Line 408:

Line 403: {'command': {'class': 'GlusterGeoRep', 'name': 'create'},
Line 404:  'data': {'masterVolName': 'str', 'slaveHost': 'str', 'slaveVolName': 'str', 'Force': 'bool'},
Line 405:  'returns': 'bool'}
Line 406: 
Line 407: 
Done
Line 408: 
Line 409: ##
Line 410: # @GlusterGeoRep.delete:
Line 411: #

Line 417: #
Line 418: # @slaveVolName:   is an available existing volume name in the slave node
Line 419: #
Line 420: # Returns:
Line 421: # True if session is successfully Deleted
Done
Line 422: #
Line 423: # Since: 4.10.3
Line 424: ##
Line 425: {'command': {'class': 'GlusterGeoRep', 'name': 'delete'},

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 10:

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4026/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3137/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3944/ : SUCCESS

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 10:

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3136/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3943/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4028/ : FAILURE

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 10: -Verified

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3136/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3943/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4029/ : SUCCESS

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 10: Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3136/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3943/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4031/ : FAILURE

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 10: -Verified

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3136/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3943/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4032/ : SUCCESS

Change in vdsm[master]: gluster Geo-replication: command to create and delete a geo-...

Bala.FA has posted comments on this change.

Change subject: gluster Geo-replication: command to create and delete a geo-replication session
......................................................................

Patch Set 10: Code-Review-1

(9 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-08-05 09:59:19 +0530
Line 4: Commit:     ndarshan 
Line 5: CommitDate: 2013-08-20 14:21:08 +0530
Line 6: 
Line 7: gluster Geo-replication: command to create and delete a geo-replication session
1. shorten the prefix by 'gluster:'
2. split this patch into two a) for create b) for delete
Line 8: 
Line 9: geo-replication create first executes the command to create a public key file which
Line 10: will have public keys of all the hosts of source cluster.Next it pushes the file to
Line 11: destination cluster and with password less communication geo-replication session is

....................................................
File client/vdsClientGluster.py
Line 440: 
Line 441:     def do_glusterVolumeGeoRepDelete(self, args):
Line 442:         params = self._eqSplit(args)
Line 443:         try:
Line 444:             masterVolName = params.get('masterVolName', '')
Use volumeName instead of masterVolName as its all about volume available locally.
Line 445:             slaveHost = params.get('slaveHost', '')
Line 446:             slaveVolName = params.get('slaveVolName', '')
Line 447:         except:
Line 448:             raise ValueError

Line 442:         params = self._eqSplit(args)
Line 443:         try:
Line 444:             masterVolName = params.get('masterVolName', '')
Line 445:             slaveHost = params.get('slaveHost', '')
Line 446:             slaveVolName = params.get('slaveVolName', '')
can we have remoteHost/remoteVolumeName than slaveHost/slaveVolName?
Line 447:         except:
Line 448:             raise ValueError
Line 449:         if not (masterVolName and slaveHost and slaveVolName):
Line 450:             raise ValueError

....................................................
File vdsm/gluster/api.py
Line 287:         status = self.svdsmProxy.glusterServicesGet(serviceNames)
Line 288:         return {'services': status}
Line 289: 
Line 290:     @exportAsVerb
Line 291:     def volumeGeoRepCreate(self, masterVolName, slaveHost,
1. I think this is geo-rep session create.  Please add session in the name

2. have volumeName, remoteHost, remoteVolume etc than master/slave

3. functionality of this verb is
a) check passwordless-ssh is there between localhost and remoteHost.  This requires http://gerrit.ovirt.org/8375

b) if false return error else continue

c) call cli:gsec_create

d) if success, call glusterVolumeGeoRepCreate
Line 292:                            slaveVolName, force=False, options=None):
Line 293:         status = self.svdsmProxy.glusterVolumeGeoRepCreate(masterVolName,
Line 294:                                                            slaveHost,
Line 295:                                                            slaveVolName,

Line 292:                            slaveVolName, force=False, options=None):
Line 293:         status = self.svdsmProxy.glusterVolumeGeoRepCreate(masterVolName,
Line 294:                                                            slaveHost,
Line 295:                                                            slaveVolName,
Line 296:                                                            force=False)
just pass force, no default to be set here
Line 297:         return {'geo-rep': status}
Line 298: 
Line 299:     @exportAsVerb
Line 300:     def volumeGeoRepDelete(self, masterVolName, slaveHost,

Line 296:                                                            force=False)
Line 297:         return {'geo-rep': status}
Line 298: 
Line 299:     @exportAsVerb
Line 300:     def volumeGeoRepDelete(self, masterVolName, slaveHost,
same here
Line 301:                            slaveVolName, options=None):
Line 302:         status = self.svdsmProxy.glusterVolumeGeoRepDelete(masterVolName,
Line 303:                                                            slaveHost,
Line 304:                                                            slaveVolName)

....................................................
File vdsm/gluster/cli.py
Line 905:     if rc:
Line 906:         raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc,
Line 907:                                                                    out, err)
Line 908:     path = out.partition('/')
Line 909:     if not os.path.isfile('/' + path):
1. make this function as one-to-one mapping

a) change name of the function to systemExecuteGsecCreate
b) make this function available publically

2. I would suggest to return well known filepath than parsing stdout.  Also please open a bug in glusterfs to return xml output for this command as tracker.
Line 910:         raise ge.GlusterGeoRepPublicKeyFileDoesNotExistException(rc, out, err)
Line 911:     else:
Line 912:         return True
Line 913:

....................................................
File vdsm/gluster/exception.py
Line 491:     code = 4560
Line 492:     message = "Gluster Geo-Replication Exception"
Line 493: 
Line 494: 
Line 495: class GlusterGeoRepPublicKeyFileCreateFailedException(GlusterGeoRepException
GlusterGeoRepSecCreateFailedException may be?
Line 496:                                                       ):
Line 497:     code = 4561
Line 498:     message = "Creation of public key file failed"
Line 499:

Line 497:     code = 4561
Line 498:     message = "Creation of public key file failed"
Line 499: 
Line 500: 
Line 501: class GlusterGeoRepPublicKeyFileDoesNotExistException(GlusterGeoRepException):
I don't think this exception needed
Line 502:     code = 4562
Line 503:     message = "Public key file does not exist"
Line 504: 
Line 505:

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 11:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4077/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3182/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3998/ : SUCCESS

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

ndarshan has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 10:

(9 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-08-05 09:59:19 +0530
Line 4: Commit:     ndarshan 
Line 5: CommitDate: 2013-08-20 14:21:08 +0530
Line 6: 
Line 7: gluster Geo-replication: command to create and delete a geo-replication session
I will change the prefix,

I feel that both create and delete are almost similar and delete is very small, and this patch has dependency on one more patch, so to avoid the overhead its better to have a single patch
Line 8: 
Line 9: geo-replication create first executes the command to create a public key file which
Line 10: will have public keys of all the hosts of source cluster.Next it pushes the file to
Line 11: destination cluster and with password less communication geo-replication session is

....................................................
File client/vdsClientGluster.py
Line 440: 
Line 441:     def do_glusterVolumeGeoRepDelete(self, args):
Line 442:         params = self._eqSplit(args)
Line 443:         try:
Line 444:             masterVolName = params.get('masterVolName', '')
Done
Line 445:             slaveHost = params.get('slaveHost', '')
Line 446:             slaveVolName = params.get('slaveVolName', '')
Line 447:         except:
Line 448:             raise ValueError

Line 442:         params = self._eqSplit(args)
Line 443:         try:
Line 444:             masterVolName = params.get('masterVolName', '')
Line 445:             slaveHost = params.get('slaveHost', '')
Line 446:             slaveVolName = params.get('slaveVolName', '')
Done
Line 447:         except:
Line 448:             raise ValueError
Line 449:         if not (masterVolName and slaveHost and slaveVolName):
Line 450:             raise ValueError

....................................................
File vdsm/gluster/api.py
Line 287:         status = self.svdsmProxy.glusterServicesGet(serviceNames)
Line 288:         return {'services': status}
Line 289: 
Line 290:     @exportAsVerb
Line 291:     def volumeGeoRepCreate(self, masterVolName, slaveHost,
I have changed the verb name, master/slave  volume to volume/remotevolume.
but checking passwordless-ssh could not be done as argument fingerprint is not available.
Line 292:                            slaveVolName, force=False, options=None):
Line 293:         status = self.svdsmProxy.glusterVolumeGeoRepCreate(masterVolName,
Line 294:                                                            slaveHost,
Line 295:                                                            slaveVolName,

Line 292:                            slaveVolName, force=False, options=None):
Line 293:         status = self.svdsmProxy.glusterVolumeGeoRepCreate(masterVolName,
Line 294:                                                            slaveHost,
Line 295:                                                            slaveVolName,
Line 296:                                                            force=False)
Done
Line 297:         return {'geo-rep': status}
Line 298: 
Line 299:     @exportAsVerb
Line 300:     def volumeGeoRepDelete(self, masterVolName, slaveHost,

Line 296:                                                            force=False)
Line 297:         return {'geo-rep': status}
Line 298: 
Line 299:     @exportAsVerb
Line 300:     def volumeGeoRepDelete(self, masterVolName, slaveHost,
Done
Line 301:                            slaveVolName, options=None):
Line 302:         status = self.svdsmProxy.glusterVolumeGeoRepDelete(masterVolName,
Line 303:                                                            slaveHost,
Line 304:                                                            slaveVolName)

....................................................
File vdsm/gluster/cli.py
Line 905:     if rc:
Line 906:         raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc,
Line 907:                                                                    out, err)
Line 908:     path = out.partition('/')
Line 909:     if not os.path.isfile('/' + path):
1. I felt that this function is consumed only by volumeGeoRepCreate so I did not make it public,now I have made this function one-to-mapping.

2. I will return the well known path.
   Regarding xml output, since "gluster system:: execute gsec_create" command is task oriented i believe the output is not of that value.
   If you still want me to raise a bug i will do it.
Line 910:         raise ge.GlusterGeoRepPublicKeyFileDoesNotExistException(rc, out, err)
Line 911:     else:
Line 912:         return True
Line 913:

....................................................
File vdsm/gluster/exception.py
Line 491:     code = 4560
Line 492:     message = "Gluster Geo-Replication Exception"
Line 493: 
Line 494: 
Line 495: class GlusterGeoRepPublicKeyFileCreateFailedException(GlusterGeoRepException
Done
Line 496:                                                       ):
Line 497:     code = 4561
Line 498:     message = "Creation of public key file failed"
Line 499:

Line 497:     code = 4561
Line 498:     message = "Creation of public key file failed"
Line 499: 
Line 500: 
Line 501: class GlusterGeoRepPublicKeyFileDoesNotExistException(GlusterGeoRepException):
Now i have made the glusterSystemExecuteGsecCreate function to use the well known path, so i feel checking if the file exists and raising an error is necessary as gluster cli may change the location of the file some day or the file may not be created because of some issue.
Line 502:     code = 4562
Line 503:     message = "Public key file does not exist"
Line 504: 
Line 505:

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 12:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4078/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3183/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3999/ : SUCCESS

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

Bala.FA has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 12: Code-Review-1

(6 comments)

....................................................
Commit Message
Line 8: 
Line 9: geo-replication create first executes the command to create a public key file which
Line 10: will have public keys of all the hosts of source cluster.Next it pushes the file to
Line 11: destination cluster and with password less communication geo-replication session is
Line 12: created.Geo-replication delete deletes a created geo-replication session
You could add comments about the functionality than the logic.  something like

This patch adds a feature of geo-replication session create and delete.  It exposes two verbs
* glusterVolumeGeoRepSessionCreate
  - This verb sets up session to remote volume of remote gluster cluster for given volume name.

* glusterVolumeGeoRepSessionDelete
  - This verb delete previously created session.
Line 13: 
Line 14: Change-Id: If8c979a89ce11a1622819c474b59dcf088733594

....................................................
File client/vdsClientGluster.py
Line 735:               '(swift, glusterd, smb, memcached)'
Line 736:               )),
Line 737:          'glusterVolumeGeoRepSessionCreate': (
Line 738:              serv.do_glusterVolumeGeoRepSessionCreate,
Line 739:              ('volName=<master_volume_name> '
Change volName to volumeName everywhere for consistency.  Please look into other verbs
Line 740:               'remoteHost=<slave_host_name> '
Line 741:               'remoteVolName=<slave_volume_name> '
Line 742:               '[force={yes|no}]\n\t'
Line 743:               '<master_volume_name>existing volume name in the master node\n\t'

....................................................
File vdsm/gluster/cli.py
Line 898:         raise ge.GlusterXmlErrorException(err=[etree.tostring(xmltree)])
Line 899: 
Line 900: 
Line 901: @makePublic
Line 902: def glusterSystemExecuteGsecCreate():
@makePublic add gluster prefix.  So this function becomes glusterGlusterSystemExecuteGsecCreate().   Please fix it
Line 903:     command = _getGlusterSystemCmd() + ["execute", "gsec_create"]
Line 904:     rc, out, err = _execGluster(command)
Line 905:     if rc:
Line 906:         raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc,

Line 905:     if rc:
Line 906:         raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc,
Line 907:                                                                    out, err)
Line 908:     if not os.path.isfile(_publicKeyFilePath):
Line 909:         raise ge.GlusterGeoRepPublicKeyFileDoesNotExistException(rc, out, err)
May be GlusterGeoRepPublicKeyFileNotFoundException?
Line 910:     else:
Line 911:         return True
Line 912: 
Line 913:

Line 912: 
Line 913: 
Line 914: @makePublic
Line 915: def volumeGeoRepSessionCreate(volName, remoteHost, remoteVolName, force=False):
Line 916:     glusterSystemExecuteGsecCreate()
Don't call this here.  The verb (method in api.py) should take care of calling this first, then glusterVolumeGeoRepSessionCreate() next.
Line 917:     command = _getGlusterVolCmd() + ["geo-replication", volName,
Line 918:                                      "%s::%s" % (remoteHost, remoteVolName),
Line 919:                                      "create", "push-pem"]
Line 920:     try:

....................................................
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 695: #
Line 696: # @volumeName: Gluster volume name
Line 697: #
Line 698: # Returns:
Line 699: # Gluster volume Status 
white space cleanup?
Line 700: #
Line 701: # Since: 4.10.3
Line 702: ##
Line 703: {'command': {'class': 'GlusterVolume', 'name': 'status'},

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

Bala.FA has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 10:

(1 comment)

....................................................
File vdsm/gluster/cli.py
Line 905:     if rc:
Line 906:         raise ge.GlusterGeoRepPublicKeyFileCreationFailedException(rc,
Line 907:                                                                    out, err)
Line 908:     path = out.partition('/')
Line 909:     if not os.path.isfile('/' + path):
1. returning well known path is interim.  We should get the path from the cli only. (for instance, downstream/upstream cli may return different path)

2. If gluster cli output is consumed by a program/script should use xml to avoid breakage in future, so please open a bug for this.
Line 910:         raise ge.GlusterGeoRepPublicKeyFileDoesNotExistException(rc, out, err)
Line 911:     else:
Line 912:         return True
Line 913:

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 13:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4211/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3316/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4132/ : SUCCESS

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 14:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4234/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3339/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4155/ : SUCCESS

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 15:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4241/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3346/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4162/ : SUCCESS

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 16:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4284/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3387/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4203/ : SUCCESS

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 17:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4398/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3501/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4317/ : SUCCESS

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

Itamar Heim has posted comments on this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Patch Set 17:

ping

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

Itamar Heim has abandoned this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Abandoned

abandoning - old. no reply. not touched for a while. please restore if relevant

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

Darshan N has restored this change.

Change subject: gluster: command to create and delete a geo-replication session
......................................................................

Restored

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 18: Verified+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 18:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9361/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10145/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/10301/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5227/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3385/ : SUCCESS

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Timothy Asir has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 18:

(1 comment)

http://gerrit.ovirt.org/#/c/17644/18/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1058: 
Line 1059: 
Line 1060: @makePublic
Line 1061: def systemExecuteGsecCreate():
Line 1062:     command = _getGlusterSystemCmd() + ["execute", "gsec_create"]
Can we return here if any valid pem file already exists?
Line 1063:     rc, out, err = _execGluster(command)
Line 1064:     if rc:
Line 1065:         raise ge.GlusterGeoRepPublicKeyFileCreateFailedException(rc,
Line 1066:                                                                  out, err)

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 18:

(1 comment)

http://gerrit.ovirt.org/#/c/17644/18/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1058: 
Line 1059: 
Line 1060: @makePublic
Line 1061: def systemExecuteGsecCreate():
Line 1062:     command = _getGlusterSystemCmd() + ["execute", "gsec_create"]
> Can we return here if any valid pem file already exists?

Done
Line 1063:     rc, out, err = _execGluster(command)
Line 1064:     if rc:
Line 1065:         raise ge.GlusterGeoRepPublicKeyFileCreateFailedException(rc,
Line 1066:                                                                  out, err)

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 19:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10545/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11487/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11330/ : SUCCESS

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 19: Verified+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Bala.FA has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 19:

May be not related to this patch, but basic geo-rep,

What happen to establishing passwordless ssh connection between local node to remote node?

Please have related patches together as a set.

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 20:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10742/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/11684/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11527/ : SUCCESS

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 20: Verified+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 21:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11108/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12050/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11897/ : SUCCESS

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 22:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 22:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16159/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15359/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16329/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1135/ : FAILURE

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 23:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 24:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 24: Verified+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 23: Code-Review-1 Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16160/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15360/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16330/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1136/ : FAILURE

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 24:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16161/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15361/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16331/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1137/ : FAILURE

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 25:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 25: Verified+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 25:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16168/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15368/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16338/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/1144/ : FAILURE

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 26:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 26:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16256/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15456/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16426/ : SUCCESS

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 26: Verified+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Bala.FA has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 26: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/17644/26/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1342: userName
have userName as remoteUserName

Line 1361: userName
1. same as above.

2. applicable to api.py and other places too

3. in what version of glusterfs is this feature available?  you should set correct version in the spec file as well

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 27:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 26:

(2 comments)

https://gerrit.ovirt.org/#/c/17644/26/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1342: userName
> have userName as remoteUserName

Done

Line 1361: userName
> same as above.

This is available only in glusterfs master, not available in any upstream release. And upstream release is not any time soon. So got a suggestion from sahina saying for now we can leave the glusterfs dependency(as this feature is not released soon) and get this merged(so qe can start testing).
Once the glusterfs-upstream release happens, will send a patch with proper dependency.

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 27: Verified+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Bala.FA has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 26:

(1 comment)

https://gerrit.ovirt.org/#/c/17644/26/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1361: userName
> This is available only in glusterfs master, not available in any upstream r

I think you need to wait till glusterfs is released with the version otherwise it will break the whole functionality in ovirt upstream release.

This is applicable to any other patches.  Please make it accordingly.

You make such patches to -1 and add dependency bug in the comment about you are waiting for that.

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Bala.FA has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 27: Code-Review-1

As per https://gerrit.ovirt.org/#/c/17644/26/vdsm/gluster/cli.py@1361

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 27: Code-Review-1 Verified-1

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16509/ : UNSTABLE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16680/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15710/ : FAILURE

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 28:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 28:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16571/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16742/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15772/ : FAILURE

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 29:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 29: Verified+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 29:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16733/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16905/ : SUCCESS

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Bala.FA has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 29: Code-Review+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 30:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 30:

Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17081/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 30:

Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16909/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 30:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16909/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17081/ : SUCCESS

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 30: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/17644/30/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:

Line 274:         return self._gluster.geoRepMountBrokerSetup(remoteUserName,
Line 275:                                                     remoteGroupName,
Line 276:                                                     remoteVolumeName)
Line 277: 
Line 278:     def geoRepSessionCreate(self, volumeName, remoteHost, remotVolumeName,
if you want to have options parameter in apiwrapper you need to add it to schema.
Line 279:                             remoteUserName=None, force=False, options=None):
Line 280:         return self._gluster.volumeGeoRepSessionCreate(
Line 281:             volumeName,
Line 282:             remoteHost,

Line 284:             remoteUserName,
Line 285:             force
Line 286:         )
Line 287: 
Line 288:     def geoRepSessionDelete(self, volumeName, remoteHost,
as above.
Line 289:                             remoteVolumeName,
Line 290:                             remoteUserName=None, options=None):
Line 291:         return self._gluster.volumeGeoRepSessionDelete(
Line 292:             volumeName,

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 31:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 31:

Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16920/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 30:

(2 comments)

https://gerrit.ovirt.org/#/c/17644/30/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:

Line 274:         return self._gluster.geoRepMountBrokerSetup(remoteUserName,
Line 275:                                                     remoteGroupName,
Line 276:                                                     remoteVolumeName)
Line 277: 
Line 278:     def geoRepSessionCreate(self, volumeName, remoteHost, remotVolumeName,
> if you want to have options parameter in apiwrapper you need to add it to s

option was added by mistake, will remove this.
Line 279:                             remoteUserName=None, force=False, options=None):
Line 280:         return self._gluster.volumeGeoRepSessionCreate(
Line 281:             volumeName,
Line 282:             remoteHost,

Line 284:             remoteUserName,
Line 285:             force
Line 286:         )
Line 287: 
Line 288:     def geoRepSessionDelete(self, volumeName, remoteHost,
> as above.

Done
Line 289:                             remoteVolumeName,
Line 290:                             remoteUserName=None, options=None):
Line 291:         return self._gluster.volumeGeoRepSessionDelete(
Line 292:             volumeName,

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 31: Verified+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 31:

Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17093/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 31:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16920/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17093/ : SUCCESS

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 31: Code-Review+1

api and schema changes looks good

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 32:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 32:

Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17125/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Darshan N has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 32: Verified+1

Rebased patch set 31

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 32:

Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17299/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 32:

Build Successful

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17125/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17299/ : SUCCESS

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

Sahina Bose has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 32: Code-Review+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Piotr Kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 32: Code-Review+1

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 32: Code-Review+2

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

gluster: Patch adds geo-replication create and delete verbs.

This patch adds the feature geo-replication session create and delete.
It exposes two verbs:
*glusterVolumeGeoRepSessionCreate- This verb sets up session to remote
volume of remote gluster cluster for given volume name.
*glusterVolumeGeoRepSessionDelete- This verb deletes previously
created session.

Change-Id: If8c979a89ce11a1622819c474b59dcf088733594
Signed-off-by: Darshan N 
Reviewed-on: https://gerrit.ovirt.org/17644
Reviewed-by: Sahina Bose 
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Dan Kenigsberg 
---
M client/vdsClientGluster.py
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
6 files changed, 185 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Darshan N: Verified
  Sahina Bose: Looks good to me, but someone else must approve

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[e-mail] has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/800/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me...

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4782/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/773/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer...

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/806/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer...

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me...

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

Build Started (9/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/807/

Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: gluster: Patch adds geo-replication create and delete verbs.
......................................................................

Patch Set 33:

Build Failed

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/800/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_me... : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4782/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/773/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_mer... : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/806/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_mer... : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_me... : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/807/ : SUCCESS