Saggi Mizrahi has posted comments on this change.
Change subject: [WIP] Move the VDSM common code to the python site lib
......................................................................
Patch Set 3:
Well, in my opinion it's wrong that everyone are accessing constants and config.
Config in my opinion should only be accessed by clientIf.py
and HSM.py each reading it's own section of the configuration and then distributing
the proper values in a less global fashion.
the huge constants.py should be removed. each tool should have it's own wrapper and
have it be the only point the path is defined. All modules should use the the warrper
module so there aren't multiple users of the constant.
The actual way to devide this in my opinion would be
VDSM pacakge
Storage package
python-syntools - collection of our sync objects made in a way that they can be useful to
other projects
python-XXX - more packages with reusable parts stripped off.
--
To view, visit
http://gerrit.ovirt.org/286
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>