Yaniv Bronhaim has posted comments on this change.
Change subject: Remove verbosity from restorecon hack for /var/log/core.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm.spec.in
Line 663: # hack until we replace core dump with abrt
Line 664: if /usr/sbin/selinuxenabled; then
Line 665: /usr/sbin/semanage fcontext -a -t virt_cache_t
'/var/log/core(/.*)?'
Line 666: fi
Line 667: /sbin/restorecon -R /var/log/core
dont you need also >/dev/null 2>&1 on errors? rpm not suppose to verbose
anything
Line 668: # hack until we replace core dump with abrt
Line 669:
Line 670: %if 0%{?rhel}
Line 671: if [ "$1" -eq 1 ] ; then
--
To view, visit
http://gerrit.ovirt.org/21888
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I862039a6dfeebe38fc5c62276ae98213ef92bd02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes