Change in vdsm[master]: fix getMasterDomain masterVersion handling
Dan Kenigsberg has posted comments on this change.
Change subject: fix getMasterDomain masterVersion handling
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 661: os.unlink(self._poolFile)
maybe it's safe here, but I hate test-and-later-set; better unlink and ignore error.
p.s what is it good for? you are soon to overwrite this file anyway.
hmm, the save here does not survive kill-9 before sync. is it bad?
--
To view, visit http://gerrit.ovirt.org/431
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5dd06800e770c098460466fa8642c5bc928e54
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>