Saggi Mizrahi has posted comments on this change.
Change subject: added support for mirror promisc mode
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Please try and have all the cmd parsing stuff in separate modules wrapping the operations
and then use the actual logic in code. Mixing everything makes reading, understanding, and
debugging much harder.
....................................................
File vdsm/supervdsmServer.py
Line 187: this command will run:
When commenting don't say what you do say what you mean to do.
Line 193: command = [EXT_TC, 'qdisc', 'del', 'dev',
networkName, 'root']
You already have tc.py, create a wrapper there.
Creating wrapper functions in tc will not only make the code easier to understand but will
also make this whole function 4 lines long
--
To view, visit
http://gerrit.ovirt.org/956
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>