Ayal Baron has posted comments on this change.
Change subject: getAllVolumes() that can operate on SDs with broken images.
......................................................................
Patch Set 5: (3 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2013-02-28 12:22:37 +0200
Line 4: Commit: Eduardo Warszawski <ewarszaw(a)redhat.com>
Line 5: CommitDate: 2013-03-17 16:10:36 +0200
Line 6:
Line 7: getAllVolumes() that can operate on SDs with broken images.
s/.*/Make getAllVolumes not fail on broken images/
Line 8:
Line 9: getAllVolumesImages differentiates between legal and remnants.
Line 10: Added getAllRemnants for garbage detection.
Line 11:
....................................................
File vdsm/storage/blockSD.py
Line 1006: self.__markForDelVols(sdUUID, imgUUID, toZero, sd.ZEROED_IMAGE_PREFIX)
Line 1007: zeroImgVolumes(sdUUID, imgUUID, toZero)
Line 1008: self.rmDCImgDir(imgUUID, volsImgs)
Line 1009:
Line 1010: def getAllVolumesImages(self):
see patch 3 for unhandled comments on this
Line 1011: """
Line 1012: Return all the images that depend on a volume.
Line 1013:
Line 1014: Return dicts:
Line 1024: ip.imgs[0].startswith(sd.REMOVED_IMAGE_PREFIX)):
Line 1025: remnants[volName] = ip
Line 1026: else:
Line 1027: vols[volName] = ip
Line 1028: return vols, remnants
same
Line 1029:
Line 1030: def getAllVolumes(self):
Line 1031: vols, rems = self.getAllVolumesImages()
Line 1032: return vols
--
To view, visit
http://gerrit.ovirt.org/12546
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server