Change in vdsm[master]: getAllVolumes returns partially deleted volumes too.

List overview All Threads
Download

newer

older

Change in vdsm[master]:...

Change in vdsm[master]: Marking...

ewarszaw＠redhat.com

28 Feb 2013 28 Feb '13

3:04 p.m.

Eduardo has uploaded a new change for review.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

getAllVolumes returns partially deleted volumes too.

getAllVolumesImages differentiates between legal and remnants. Added getAllRemnants for garbage detection.

Related to: BZ#905938, BZ#910013, BZ#875708

Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/blockSD.py 1 file changed, 33 insertions(+), 10 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/12546/1

diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index 35282e5..4a00cec 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -171,11 +171,15 @@ res[volName]['parent'] = parentVol if vImg not in res[volName]['imgs']: res[volName]['imgs'].insert(0, vImg) - if (parentVol != sd.BLANK_UUID and - not volName.startswith( - sd.REMOVED_IMAGE_PREFIX) and - vImg not in res[parentVol]['imgs']): - res[parentVol]['imgs'].append(vImg) + if parentVol != sd.BLANK_UUID: + try: + newImg = vImg not in res[parentVol]['imgs'] + except KeyError: + log.warning("Orphan volume %s/%s: img: %s, parent %s", + sdUUID, volName, vImg, parentVol) + else: + if newImg: + res[parentVol]['imgs'].append(vImg)

return dict((k, sd.ImgsPar(tuple(v['imgs']), v['parent'])) for k, v in res.iteritems()) @@ -1003,15 +1007,34 @@ zeroImgVolumes(sdUUID, imgUUID, toZero) self.rmDCImgDir(imgUUID, volsImgs)

- def getAllVolumes(self): + def getAllVolumesImages(self): """ Return all the images that depend on a volume.

- TODO: rename to getAllVolumeImages. - - Return dict {volUUID: ([imgUUID1, imgUUID2], parentUUID)]}. + Return dicts: + vols = {volUUID: ([imgUUID1, imgUUID2], parentUUID)]} + for complete images. + remnants (same) for broken imgs, orphan volumes, etc. """ - return getAllVolumes(self.sdUUID) + vols = {} # The "legal" volumes: not half deleted/removed volumes. + remnants = {} # vols belongs to a partially deleted imgs + allVols = getAllVolumes(self.sdUUID) + for volName, ip in allVols.iteritems(): + images, parent = ip + if (volName.startswith(sd.REMOVED_IMAGE_PREFIX) or + ip.imgs[0].startswith(sd.REMOVED_IMAGE_PREFIX)): + remnants[volName] = ip + else: + vols[volName] = ip + return vols, remnants + + def getAllVolumes(self): + vols, rems = self.getAllVolumesImages() + return vols + + def getAllRemnants(self): + vols, rems = self.getAllVolumesImages() + return rems

def activateVolumes(self, volUUIDs): """

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com

Show replies by date

Jenkins CI RO

28 Feb 28 Feb

3:04 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/573/ (1/3)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

ewarszaw＠redhat.com

3:09 p.m.

Eduardo has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 1: Verified

Verified by Paikov.

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

ewarszaw＠redhat.com

3:10 p.m.

Eduardo has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 1:

Still dubious if we really want this change.

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:06 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1426/ (2/3)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:06 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1465/ (3/3)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:08 p.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1426/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1465/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/573/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

paikov＠gmail.com

11 Mar 11 Mar

6:32 a.m.

Daniel Paikov has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 1: Verified

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

8:06 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1548/ (1/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

8:07 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1511/ (2/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

8:09 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1548/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1511/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Haim Ateya

12 Mar 12 Mar

3:39 a.m.

Haim Ateya has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 2: Verified

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

abaron＠redhat.com

4:36 p.m.

Ayal Baron has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 2: (5 inline comments)

.................................................... File vdsm/storage/blockSD.py Line 170: for volName, vImg, parentVol in vols.itervalues(): Line 171: res[volName]['parent'] = parentVol Line 172: if vImg not in res[volName]['imgs']: Line 173: res[volName]['imgs'].insert(0, vImg) Line 174: if parentVol != sd.BLANK_UUID: why not return the partial images here separately already? Line 175: try: Line 176: newImg = vImg not in res[parentVol]['imgs'] Line 177: except KeyError: Line 178: log.warning("Orphan volume %s/%s: img: %s, parent %s",

Line 172: if vImg not in res[volName]['imgs']: Line 173: res[volName]['imgs'].insert(0, vImg) Line 174: if parentVol != sd.BLANK_UUID: Line 175: try: Line 176: newImg = vImg not in res[parentVol]['imgs'] s/newImg/imageIsNew/ newImg sounds like an image object imageIsNew is clearly a boolean Line 177: except KeyError: Line 178: log.warning("Orphan volume %s/%s: img: %s, parent %s", Line 179: sdUUID, volName, vImg, parentVol) Line 180: else:

Line 174: if parentVol != sd.BLANK_UUID: Line 175: try: Line 176: newImg = vImg not in res[parentVol]['imgs'] Line 177: except KeyError: Line 178: log.warning("Orphan volume %s/%s: img: %s, parent %s", You're not really saying anything here to the user. Should be: "Found a broken image..., delete manually or restore parent" or something Line 179: sdUUID, volName, vImg, parentVol) Line 180: else: Line 181: if newImg: Line 182: res[parentVol]['imgs'].append(vImg)

Line 1016: for complete images. Line 1017: remnants (same) for broken imgs, orphan volumes, etc. Line 1018: """ Line 1019: vols = {} # The "legal" volumes: not half deleted/removed volumes. Line 1020: remnants = {} # vols belongs to a partially deleted imgs s/vols belongs/volumes which are part of an incomplete image (probably due to failed delete) Line 1021: allVols = getAllVolumes(self.sdUUID) Line 1022: for volName, ip in allVols.iteritems(): Line 1023: images, parent = ip Line 1024: if (volName.startswith(sd.REMOVED_IMAGE_PREFIX) or

Line 1025: ip.imgs[0].startswith(sd.REMOVED_IMAGE_PREFIX)): Line 1026: remnants[volName] = ip Line 1027: else: Line 1028: vols[volName] = ip Line 1029: return vols, remnants I don't understand why we need this function and this logic is not part of getAllVolumes(sdUUID) Line 1030: Line 1031: def getAllVolumes(self): Line 1032: vols, rems = self.getAllVolumesImages() Line 1033: return vols

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

ewarszaw＠redhat.com

4:49 p.m.

Eduardo has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 2: (2 inline comments)

.................................................... File vdsm/storage/blockSD.py Line 170: for volName, vImg, parentVol in vols.itervalues(): Line 171: res[volName]['parent'] = parentVol Line 172: if vImg not in res[volName]['imgs']: Line 173: res[volName]['imgs'].insert(0, vImg) Line 174: if parentVol != sd.BLANK_UUID: Because partially deleted images is a property of the BlockStorageDomain object. I thought thas is clearer this way. I wanted to separate a the functionality of marked volumes and the possibility of getting all the volumes in the SD. Line 175: try: Line 176: newImg = vImg not in res[parentVol]['imgs'] Line 177: except KeyError: Line 178: log.warning("Orphan volume %s/%s: img: %s, parent %s",

Line 1025: ip.imgs[0].startswith(sd.REMOVED_IMAGE_PREFIX)): Line 1026: remnants[volName] = ip Line 1027: else: Line 1028: vols[volName] = ip Line 1029: return vols, remnants I wanted to separate a the functionality of marked volumes and the possibility of getting all the volumes in the SD. Line 1030: Line 1031: def getAllVolumes(self): Line 1032: vols, rems = self.getAllVolumesImages() Line 1033: return vols

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

13 Mar 13 Mar

4:23 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1546/ (1/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

4:23 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1583/ (2/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

4:25 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1583/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1546/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

5:51 p.m.

Ayal Baron has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 3: (1 inline comment)

.................................................... File vdsm/storage/blockSD.py Line 1025: ip.imgs[0].startswith(sd.REMOVED_IMAGE_PREFIX)): Line 1026: remnants[volName] = ip Line 1027: else: Line 1028: vols[volName] = ip Line 1029: return vols, remnants I don't see the logic in doing the split outside of this method. Seems like redundant code and layer to me. You always consume the partial and complete images separately and in any event this method would return all images, just split into 2 lists to avoid having to run 'if's on them in upper layers (or worse, forgetting to do so) Line 1030: Line 1031: def getAllVolumes(self): Line 1032: vols, rems = self.getAllVolumesImages() Line 1033: return vols

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

ewarszaw＠redhat.com

14 Mar 14 Mar

12:31 a.m.

Eduardo has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 3: (1 inline comment)

.................................................... File vdsm/storage/blockSD.py Line 1025: ip.imgs[0].startswith(sd.REMOVED_IMAGE_PREFIX)): Line 1026: remnants[volName] = ip Line 1027: else: Line 1028: vols[volName] = ip Line 1029: return vols, remnants In this way I maintainig the actual getAllVolumes() interfaces making it less risky for z-stream. In addition, I think that future consumers, like garbage collection should have no access to regular images and get allVolumes() consumers should have no interaction with remnants. This way we avoid, as you request, if's in upper layers. (Dynamic code is distasteful for Dan.) Line 1030: Line 1031: def getAllVolumes(self): Line 1032: vols, rems = self.getAllVolumesImages() Line 1033: return vols

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

ykaplan＠redhat.com

5:39 a.m.

Yeela Kaplan has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 3: (3 inline comments)

.................................................... File vdsm/storage/blockSD.py Line 175: try: Line 176: imgIsUnknown = vImg not in res[parentVol]['imgs'] Line 177: except KeyError: Line 178: log.warning("Found broken img %s, orphan volume %s/%s, " Line 179: "parent %s", vImg, sdUUID, volName, parentVol) log message is not clear Line 180: else: Line 181: if imgIsUnknown: Line 182: res[parentVol]['imgs'].append(vImg) Line 183:

Line 1006: self.__markForDelVols(sdUUID, imgUUID, toZero, sd.ZEROED_IMAGE_PREFIX) Line 1007: zeroImgVolumes(sdUUID, imgUUID, toZero) Line 1008: self.rmDCImgDir(imgUUID, volsImgs) Line 1009: Line 1010: def getAllVolumesImages(self): Edu if I understand correctly from your comment this should therefore be a private method: def _getAllVolumesImages Line 1011: """ Line 1012: Return all the images that depend on a volume. Line 1013: Line 1014: Return dicts:

Line 1019: vols = {} # The "legal" volumes: not half deleted/removed volumes. Line 1020: remnants = {} # Volumes which are part of failed image deletes. Line 1021: allVols = getAllVolumes(self.sdUUID) Line 1022: for volName, ip in allVols.iteritems(): Line 1023: images, parent = ip This looks redundant, you don't use images and parent, only ip. Line 1024: if (volName.startswith(sd.REMOVED_IMAGE_PREFIX) or Line 1025: ip.imgs[0].startswith(sd.REMOVED_IMAGE_PREFIX)): Line 1026: remnants[volName] = ip Line 1027: else:

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

ewarszaw＠redhat.com

6:57 a.m.

Eduardo has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 3: (3 inline comments)

.................................................... File vdsm/storage/blockSD.py Line 175: try: Line 176: imgIsUnknown = vImg not in res[parentVol]['imgs'] Line 177: except KeyError: Line 178: log.warning("Found broken img %s, orphan volume %s/%s, " Line 179: "parent %s", vImg, sdUUID, volName, parentVol) My free interpretation of Ayal's previous comment. Please suggest. Line 180: else: Line 181: if imgIsUnknown: Line 182: res[parentVol]['imgs'].append(vImg) Line 183:

Can be private.

Since I dislike private methods, in python nothing is really private, I don't want to specify a user policy here and this can easily changed I prefer this way, but should be by consensus.

In addition leaving this public is the function that Ayal wants and using the getAllVolumes/remnants interfaces is like the old interface and everybody will be happy. ;) Line 1011: """ Line 1012: Return all the images that depend on a volume. Line 1013: Line 1014: Return dicts:

Line 1019: vols = {} # The "legal" volumes: not half deleted/removed volumes. Line 1020: remnants = {} # Volumes which are part of failed image deletes. Line 1021: allVols = getAllVolumes(self.sdUUID) Line 1022: for volName, ip in allVols.iteritems(): Line 1023: images, parent = ip Done Line 1024: if (volName.startswith(sd.REMOVED_IMAGE_PREFIX) or Line 1025: ip.imgs[0].startswith(sd.REMOVED_IMAGE_PREFIX)): Line 1026: remnants[volName] = ip Line 1027: else:

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:27 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1567/ (2/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

7:27 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 4:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1602/ (1/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7:29 a.m.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 4:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1602/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1567/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

paikov＠gmail.com

17 Mar 17 Mar

6:17 a.m.

Daniel Paikov has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 4: Verified

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

7:33 a.m.

Ayal Baron has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 4: (3 inline comments)

.................................................... Commit Message Line 3: AuthorDate: 2013-02-28 12:22:37 +0200 Line 4: Commit: Eduardo Warszawski ewarszaw@redhat.com Line 5: CommitDate: 2013-03-14 12:56:04 +0200 Line 6: Line 7: getAllVolumes returns partially deleted volumes too. this is not explaining the problem you're solving here Line 8: Line 9: getAllVolumesImages differentiates between legal and remnants. Line 10: Added getAllRemnants for garbage detection. Line 11:

.................................................... File vdsm/storage/blockSD.py Line 172: if vImg not in res[volName]['imgs']: Line 173: res[volName]['imgs'].insert(0, vImg) Line 174: if parentVol != sd.BLANK_UUID: Line 175: try: Line 176: imgIsUnknown = vImg not in res[parentVol]['imgs'] name is still confusing. the image is non unknown, we just haven't added it to the dictionary. If the value of res[parentVol]['imgs'] were a set then you could just update it directly and not care. would make the code clearer. Line 177: except KeyError: Line 178: log.warning("Found broken img %s, orphan volume %s/%s, " Line 179: "parent %s", vImg, sdUUID, volName, parentVol) Line 180: else:

Line 174: if parentVol != sd.BLANK_UUID: Line 175: try: Line 176: imgIsUnknown = vImg not in res[parentVol]['imgs'] Line 177: except KeyError: Line 178: log.warning("Found broken img %s, orphan volume %s/%s, " s/img/image/ Line 179: "parent %s", vImg, sdUUID, volName, parentVol) Line 180: else: Line 181: if imgIsUnknown: Line 182: res[parentVol]['imgs'].append(vImg)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

7:33 a.m.

Ayal Baron has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 3: (2 inline comments)

.................................................... File vdsm/storage/blockSD.py Line 1006: self.__markForDelVols(sdUUID, imgUUID, toZero, sd.ZEROED_IMAGE_PREFIX) Line 1007: zeroImgVolumes(sdUUID, imgUUID, toZero) Line 1008: self.rmDCImgDir(imgUUID, volsImgs) Line 1009: Line 1010: def getAllVolumesImages(self): I don't understand what 'is the function that Ayal wants'. Any method that should not be used outside the scope of the class should start with an '_'. Although python *lets* you do all kinds of funky things it doesn't mean that you *should* and keeping things private is good practice. Line 1011: """ Line 1012: Return all the images that depend on a volume. Line 1013: Line 1014: Return dicts:

Line 1025: ip.imgs[0].startswith(sd.REMOVED_IMAGE_PREFIX)): Line 1026: remnants[volName] = ip Line 1027: else: Line 1028: vols[volName] = ip Line 1029: return vols, remnants No, that is taken care of by getAllVolumes and getAllRemnants below. You have not convinced me that doing the split should be in getAllVolumesImages and not in getAllVolumes. Line 1030: Line 1031: def getAllVolumes(self): Line 1032: vols, rems = self.getAllVolumesImages() Line 1033: return vols

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

ewarszaw＠redhat.com

8:21 a.m.

Eduardo has posted comments on this change.

Change subject: getAllVolumes returns partially deleted volumes too. ......................................................................

Patch Set 4: (1 inline comment)

.................................................... File vdsm/storage/blockSD.py Line 172: if vImg not in res[volName]['imgs']: Line 173: res[volName]['imgs'].insert(0, vImg) Line 174: if parentVol != sd.BLANK_UUID: Line 175: try: Line 176: imgIsUnknown = vImg not in res[parentVol]['imgs'] ['imgs'] is a list because the order is important. If more than one image was found, the 1st one is the image template. Line 177: except KeyError: Line 178: log.warning("Found broken img %s, orphan volume %s/%s, " Line 179: "parent %s", vImg, sdUUID, volName, parentVol) Line 180: else:

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

8:21 a.m.

New subject: Change in vdsm[master]: getAllVolumes() that can operate on SDs with broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes() that can operate on SDs with broken images. ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1634/ (1/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

8:21 a.m.

New subject: Change in vdsm[master]: getAllVolumes() that can operate on SDs with broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes() that can operate on SDs with broken images. ......................................................................

Patch Set 5:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1599/ (2/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

8:21 a.m.

New subject: Change in vdsm[master]: getAllVolumes() that can operate on SDs with broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes() that can operate on SDs with broken images. ......................................................................

Patch Set 5: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1599/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1634/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

9:02 a.m.

New subject: Change in vdsm[master]: getAllVolumes() that can operate on SDs with broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes() that can operate on SDs with broken images. ......................................................................

Patch Set 5: No score

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1643/ (2/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

9:04 a.m.

New subject: Change in vdsm[master]: getAllVolumes() that can operate on SDs with broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes() that can operate on SDs with broken images. ......................................................................

Patch Set 5: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1599/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1643/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

2:25 p.m.

New subject: Change in vdsm[master]: getAllVolumes() that can operate on SDs with broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes() that can operate on SDs with broken images. ......................................................................

Patch Set 5: No score

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1651/ (2/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

2:27 p.m.

New subject: Change in vdsm[master]: getAllVolumes() that can operate on SDs with broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: getAllVolumes() that can operate on SDs with broken images. ......................................................................

Patch Set 5: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1599/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1651/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

6:23 p.m.

New subject: Change in vdsm[master]: getAllVolumes() that can operate on SDs with broken images.

Ayal Baron has posted comments on this change.

Change subject: getAllVolumes() that can operate on SDs with broken images. ......................................................................

Patch Set 5: (3 inline comments)

.................................................... Commit Message Line 3: AuthorDate: 2013-02-28 12:22:37 +0200 Line 4: Commit: Eduardo Warszawski ewarszaw@redhat.com Line 5: CommitDate: 2013-03-17 16:10:36 +0200 Line 6: Line 7: getAllVolumes() that can operate on SDs with broken images. s/.*/Make getAllVolumes not fail on broken images/ Line 8: Line 9: getAllVolumesImages differentiates between legal and remnants. Line 10: Added getAllRemnants for garbage detection. Line 11:

Line 1024: ip.imgs[0].startswith(sd.REMOVED_IMAGE_PREFIX)): Line 1025: remnants[volName] = ip Line 1026: else: Line 1027: vols[volName] = ip Line 1028: return vols, remnants same Line 1029: Line 1030: def getAllVolumes(self): Line 1031: vols, rems = self.getAllVolumesImages() Line 1032: return vols

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

18 Mar 18 Mar

12:04 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1653/ (2/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

12:04 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 6:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1609/ (1/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

12:06 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 6: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1609/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1653/ : FAILURE

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

ykaplan＠redhat.com

20 Mar 20 Mar

10:28 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

Yeela Kaplan has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 6:

You haven't fixed 2/3 comments from patch set 3

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

21 Mar 21 Mar

10:54 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

Ayal Baron has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 6: I would prefer that you didn't submit this

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

31 Mar 31 Mar

2:08 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1754/ (2/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

2:08 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 7:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1805/ (1/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

2:11 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 7:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1754/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1805/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

2 Apr 2 Apr

5:35 p.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

Ayal Baron has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 7: I would prefer that you didn't submit this

(2 inline comments)

Line 1027: # Deleted images are not dependencies of valid volumes. Line 1028: images = [img for img in ip.imgs Line 1029: if not img.starstwith(sd.REMOVED_IMAGE_PREFIX)] Line 1030: vols[volName] = sd.ImgsPar(tuple(images, ip.parent)) Line 1031: return vols, remnants same Line 1032: Line 1033: def getAllVolumes(self): Line 1034: vols, rems = self.getAllVolumesImages() Line 1035: return vols

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

ewarszaw＠redhat.com

11:28 p.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

Eduardo has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 7: (2 inline comments)

I don't want to make this private.

This function returns images an remnants at once. If the two will be used in a calculation, you should use it. Sequential calls to getAllVolumes and getAllRemnants is racy.

in spite that this is actually not called outside the class I'm not sure that this should or will be this way forever. Line 1011: """ Line 1012: Return all the images that depend on a volume. Line 1013: Line 1014: Return dicts:

Line 1027: # Deleted images are not dependencies of valid volumes. Line 1028: images = [img for img in ip.imgs Line 1029: if not img.starstwith(sd.REMOVED_IMAGE_PREFIX)] Line 1030: vols[volName] = sd.ImgsPar(tuple(images, ip.parent)) Line 1031: return vols, remnants This function returns images an remnants at once. If the two will be used in a calculation, you should use it.

If you are dealing with regular images call getAllImages, without knowing the possibility or existence of the remnants concept. Line 1032: Line 1033: def getAllVolumes(self): Line 1034: vols, rems = self.getAllVolumesImages() Line 1035: return vols

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

4 Apr 4 Apr

3:30 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

Ayal Baron has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 7: Looks good to me, approved

(1 inline comment)

Although I dislike the location of the split, it's not worth arguing about.

.................................................... File vdsm/storage/blockSD.py Line 1006: self.__markForDelVols(sdUUID, imgUUID, toZero, sd.ZEROED_IMAGE_PREFIX) Line 1007: zeroImgVolumes(sdUUID, imgUUID, toZero) Line 1008: self.rmDCImgDir(imgUUID, volsImgs) Line 1009: Line 1010: def getAllVolumesImages(self): if you're not sure it should be this way then all the more reason to make it private... Line 1011: """ Line 1012: Return all the images that depend on a volume. Line 1013: Line 1014: Return dicts:

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

7 Apr 7 Apr

6:43 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 8:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1891/ (1/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

Jenkins CI RO

6:43 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 8:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1840/ (2/2)

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

paikov＠gmail.com

6:45 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

Daniel Paikov has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 8: Verified

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

abaron＠redhat.com

6:45 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

Ayal Baron has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 8: Looks good to me, approved

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Jenkins CI RO

6:46 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Patch Set 8:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1840/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1891/ : SUCCESS

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Dan Kenigsberg

7:20 a.m.

New subject: Change in vdsm[master]: Make getAllVolumes() not fail on broken images.

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Make getAllVolumes() not fail on broken images. ......................................................................

Make getAllVolumes() not fail on broken images.

getAllVolumesImages differentiates between legal and remnants. Added getAllRemnants for garbage detection.

Related to: BZ#905938, BZ#910013, BZ#875708

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=917363

Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Signed-off-by: Eduardo ewarszaw@redhat.com --- M vdsm/storage/blockSD.py 1 file changed, 35 insertions(+), 10 deletions(-)

Approvals: Ayal Baron: Looks good to me, approved Daniel Paikov: Verified Dan Kenigsberg:

-- To view, visit http://gerrit.ovirt.org/12546 To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Daniel Paikov paikov@gmail.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Gadi Ickowicz gickowic@redhat.com Gerrit-Reviewer: Haim Ateya hateya@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server

4900

Age (days ago)

4938

Last active (days ago)

vdsm-patches@lists.fedorahosted.org

52 comments

7 participants

tags (0)

participants (7)

abaron＠redhat.com
Dan Kenigsberg
ewarszaw＠redhat.com
Haim Ateya
Jenkins CI RO
paikov＠gmail.com
ykaplan＠redhat.com