Nir Soffer has posted comments on this change.
Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61436/1/tests/storage_guarded_test.py
File tests/storage_guarded_test.py:
Line 59: calls.append(('releaseResource', ('A', 'a'),
{}))
Line 60:
Line 61: def test_sorting(self):
Line 62: src_locks = [
Line 63: guarded.ResourceManagerLock(IMAGE_NAMESPACE, 'a',
This is not how we create namespaces - please use sd.getNamespace() to create the test
data.
Line 64: rm.LockType.shared),
Line 65: guarded.ResourceManagerLock(sc.STORAGE, 'b',
Line 66: rm.LockType.shared),
Line 67: ]
--
To view, visit
https://gerrit.ovirt.org/61436
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes