Change in vdsm[master]: storage: Sortable ResourceManager lock namespaces

Adam Litke has uploaded a new change for review.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................

storage: Sortable ResourceManager lock namespaces

In order to simplify correct locking order, change the namespace constants so
that they sort in the order that they should be taken.

Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Signed-off-by: Adam Litke <alitke(a)redhat.com&gt;
---
M lib/vdsm/storage/constants.py
M tests/storage_guarded_test.py
2 files changed, 24 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/61436/1

diff --git a/lib/vdsm/storage/constants.py b/lib/vdsm/storage/constants.py
index e49c88e..9803b89 100644
--- a/lib/vdsm/storage/constants.py
+++ b/lib/vdsm/storage/constants.py
@@ -22,11 +22,12 @@
 
 from vdsm import qemuimg
 
+
 # ResourceManager Lock Namespaces
-STORAGE = "Storage"
-LVM_ACTIVATION_NAMESPACE = 'lvmActivationNS'
-IMAGE_NAMESPACE = 'imageNS'
-VOLUME_NAMESPACE = 'volumeNS'
+STORAGE = "00_Storage"
+LVM_ACTIVATION_NAMESPACE = '01_lvmActivationNS'
+IMAGE_NAMESPACE = '02_imageNS'
+VOLUME_NAMESPACE = '03_volumeNS'
 
 SECTOR_SIZE = 512
 VG_EXTENT_SIZE_MB = 128
diff --git a/tests/storage_guarded_test.py b/tests/storage_guarded_test.py
index 29db745..bf4371a 100644
--- a/tests/storage_guarded_test.py
+++ b/tests/storage_guarded_test.py
@@ -25,9 +25,11 @@
 from storagefakelib import FakeResourceManager
 from testlib import VdsmTestCase, expandPermutations, permutations
 
+from vdsm.storage import constants as sc
 from vdsm.storage import guarded
 
 from storage import resourceManager as rm
+from storage.resourceFactories import IMAGE_NAMESPACE
 
 
 @expandPermutations
@@ -58,29 +60,34 @@
 
     def test_sorting(self):
         src_locks = [
-            guarded.ResourceManagerLock('C', 'a', rm.LockType.shared),
-            guarded.ResourceManagerLock('A', 'b', rm.LockType.shared),
+            guarded.ResourceManagerLock(IMAGE_NAMESPACE, 'a',
+                                        rm.LockType.shared),
+            guarded.ResourceManagerLock(sc.STORAGE, 'b',
+                                        rm.LockType.shared),
         ]
         src = GuardedEntity(src_locks)
         dst_locks = [
-            guarded.ResourceManagerLock('A', 'a', rm.LockType.shared),
-            guarded.ResourceManagerLock('B', 'a', rm.LockType.shared),
+            guarded.ResourceManagerLock(sc.STORAGE, 'a', rm.LockType.shared),
+            guarded.ResourceManagerLock(IMAGE_NAMESPACE, 'b',
+                                        rm.LockType.exclusive),
         ]
         dst = GuardedEntity(dst_locks)
         with self.env() as rmanager:
             calls = [
-                ('acquireResource', ('A', 'a',
rm.LockType.shared), {}),
-                ('acquireResource', ('A', 'b',
rm.LockType.shared), {}),
-                ('acquireResource', ('B', 'a',
rm.LockType.shared), {}),
-                ('acquireResource', ('C', 'a',
rm.LockType.shared), {}),
+                ('acquireResource', (sc.STORAGE, 'a',
rm.LockType.shared), {}),
+                ('acquireResource', (sc.STORAGE, 'b',
rm.LockType.shared), {}),
+                ('acquireResource',
+                 (IMAGE_NAMESPACE, 'a', rm.LockType.shared), {}),
+                ('acquireResource',
+                 (IMAGE_NAMESPACE, 'b', rm.LockType.exclusive), {}),
             ]
             with guarded.operation_context((src, dst)):
                 self.assertEqual(calls, rmanager.__calls__)
             calls.extend([
-                ('releaseResource', ('C', 'a'), {}),
-                ('releaseResource', ('B', 'a'), {}),
-                ('releaseResource', ('A', 'b'), {}),
-                ('releaseResource', ('A', 'a'), {}),
+                ('releaseResource', (IMAGE_NAMESPACE, 'a'), {}),
+                ('releaseResource', (IMAGE_NAMESPACE, 'b'), {}),
+                ('releaseResource', (sc.STORAGE, 'b'), {}),
+                ('releaseResource', (sc.STORAGE, 'a'), {}),
             ])
             self.assertEqual(calls, rmanager.__calls__)
 


-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/61436/1/lib/vdsm/storage/constants.py
File lib/vdsm/storage/constants.py:

Line 24: 
Line 25: 
Line 26: # ResourceManager Lock Namespaces
Line 27: STORAGE = "00_Storage"
Line 28: LVM_ACTIVATION_NAMESPACE = '01_lvmActivationNS'
Why before imageNS? I would put this last since it is the most specific resource.
Line 29: IMAGE_NAMESPACE = '02_imageNS'
Line 30: VOLUME_NAMESPACE = '03_volumeNS'
Line 31: 
Line 32: SECTOR_SIZE = 512


Line 26: # ResourceManager Lock Namespaces
Line 27: STORAGE = "00_Storage"
Line 28: LVM_ACTIVATION_NAMESPACE = '01_lvmActivationNS'
Line 29: IMAGE_NAMESPACE = '02_imageNS'
Line 30: VOLUME_NAMESPACE = '03_volumeNS'
This is not enough, because we created namespaces like this:

    imageResourcesNamespace = getNamespace(self.sdUUID, IMAGE_NAMESPACE)

And sd.getNamespace is:

    def getNamespace(*args):
        return '_'.join(args)

So the namespaces would be:

    00_storage
    0504c8ee-5e70-4bba-a032-63b2695b1da3_01_lvmActivationNS
    0504c8ee-5e70-4bba-a032-63b2695b1da3_02_imageNS
    0504c8ee-5e70-4bba-a032-63b2695b1da3_02_volumeNS

But we actually want this:

    00_storage
    01_lvmActivationNS_0504c8ee-5e70-4bba-a032-63b2695b1da3
    02_imageNS_0504c8ee-5e70-4bba-a032-63b2695b1da3
    02_volumeNS_0504c8ee-5e70-4bba-a032-63b2695b1da3

Or better this:

    00_storage
    01_img_0504c8ee-5e70-4bba-a032-63b2695b1da3
    02_vol_0504c8ee-5e70-4bba-a032-63b2695b1da3
    03_lvm_0504c8ee-5e70-4bba-a032-63b2695b1da3
Line 31: 
Line 32: SECTOR_SIZE = 512
Line 33: VG_EXTENT_SIZE_MB = 128
Line 34: 


-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/61436/1/tests/storage_guarded_test.py
File tests/storage_guarded_test.py:

Line 59:             calls.append(('releaseResource', ('A', 'a'),
{}))
Line 60: 
Line 61:     def test_sorting(self):
Line 62:         src_locks = [
Line 63:             guarded.ResourceManagerLock(IMAGE_NAMESPACE, 'a',
This is not how we create namespaces - please use sd.getNamespace() to create the test
data.
Line 64:                                         rm.LockType.shared),
Line 65:             guarded.ResourceManagerLock(sc.STORAGE, 'b',
Line 66:                                         rm.LockType.shared),
Line 67:         ]


-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/61436/2/lib/vdsm/storage/constants.py
File lib/vdsm/storage/constants.py:

Line 24: 
Line 25: 
Line 26: # ResourceManager Lock Namespaces
Line 27: STORAGE = "00_Storage"
Line 28: LVM_ACTIVATION_NAMESPACE = '01_lvmActivationNS'
I asked in the previous patch - why lvmActivationNS comes before imageNS?

Please check again my comments in
https://gerrit.ovirt.org/#/c/61436/1/lib/vdsm/storage/constants.py
Line 29: IMAGE_NAMESPACE = '02_imageNS'
Line 30: VOLUME_NAMESPACE = '03_volumeNS'
Line 31: 
Line 32: SECTOR_SIZE = 512


-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 5:

Adam, can you verify?

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Adam Litke has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 8: Verified+1

Verified by initiating storage operations such as create disk, remove disk, LSM, live
merge, etc.

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Nir Soffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


storage: Sortable ResourceManager lock namespaces

In order to simplify correct locking order, change the namespace constants so
that they sort in the order that they should be taken.

Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Signed-off-by: Adam Litke <alitke(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/61436
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com&gt;
Continuous-Integration: Jenkins CI
---
M lib/vdsm/storage/constants.py
M tests/storage_sdm_create_volume_test.py
M vdsm/storage/blockSD.py
M vdsm/storage/blockVolume.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/resourceFactories.py
M vdsm/storage/sd.py
M vdsm/storage/sdm/api/create_volume.py
M vdsm/storage/sp.py
M vdsm/storage/volume.py
11 files changed, 51 insertions(+), 50 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;

gerrit-hooks has posted comments on this change.

Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No