Nir Soffer has posted comments on this change.
Change subject: storage: Sortable ResourceManager lock namespaces
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/61436/1/lib/vdsm/storage/constants.py
File lib/vdsm/storage/constants.py:
Line 24:
Line 25:
Line 26: # ResourceManager Lock Namespaces
Line 27: STORAGE = "00_Storage"
Line 28: LVM_ACTIVATION_NAMESPACE = '01_lvmActivationNS'
Why before imageNS? I would put this last since it is the most specific resource.
Line 29: IMAGE_NAMESPACE = '02_imageNS'
Line 30: VOLUME_NAMESPACE = '03_volumeNS'
Line 31:
Line 32: SECTOR_SIZE = 512
Line 26: # ResourceManager Lock Namespaces
Line 27: STORAGE = "00_Storage"
Line 28: LVM_ACTIVATION_NAMESPACE = '01_lvmActivationNS'
Line 29: IMAGE_NAMESPACE = '02_imageNS'
Line 30: VOLUME_NAMESPACE = '03_volumeNS'
This is not enough, because we created namespaces like this:
imageResourcesNamespace = getNamespace(self.sdUUID, IMAGE_NAMESPACE)
And sd.getNamespace is:
def getNamespace(*args):
return '_'.join(args)
So the namespaces would be:
00_storage
0504c8ee-5e70-4bba-a032-63b2695b1da3_01_lvmActivationNS
0504c8ee-5e70-4bba-a032-63b2695b1da3_02_imageNS
0504c8ee-5e70-4bba-a032-63b2695b1da3_02_volumeNS
But we actually want this:
00_storage
01_lvmActivationNS_0504c8ee-5e70-4bba-a032-63b2695b1da3
02_imageNS_0504c8ee-5e70-4bba-a032-63b2695b1da3
02_volumeNS_0504c8ee-5e70-4bba-a032-63b2695b1da3
Or better this:
00_storage
01_img_0504c8ee-5e70-4bba-a032-63b2695b1da3
02_vol_0504c8ee-5e70-4bba-a032-63b2695b1da3
03_lvm_0504c8ee-5e70-4bba-a032-63b2695b1da3
Line 31:
Line 32: SECTOR_SIZE = 512
Line 33: VG_EXTENT_SIZE_MB = 128
Line 34:
--
To view, visit
https://gerrit.ovirt.org/61436
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd94f0152c08f6260ca93228fd4c4a792e72051
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes