Federico Simoncelli has posted comments on this change.
Change subject: added support for mirror promisc mode
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/tc.py
Line 23: class MirrorPromisc():
I'm not sure if this class deserves a new module. If it solves something strictly
related to a vm definition (as it looks since it's checking the 'promisc'
attribute in the nics objects) then it belongs to libvirtvm. If instead it's something
more generic and networking related then it belongs configNetwork.
--
To view, visit
http://gerrit.ovirt.org/956
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>