Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add deathSignal options to better peopen
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
Looks good, just nitpicking on the commit message.
....................................................
Commit Message
Line 9: This allows VDSM to specify as signal that will be sent by the kernel to
s/as/the
Line 13: recompile the SO when the C file was changed
No need to indent this block.
--
To view, visit
http://gerrit.ovirt.org/6241
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>