Change in vdsm[master]: hooks: vm: graphics console listen on all ifs

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: vm: graphics console listen on all ifs
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/35661/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: hooks: vm: graphics console listen on all ifs
Line 8: 
Line 9: This hook makes the graphics console device listen on all interfaces (instead
Line 10: of listening on display network).
why is it good? who should use this hook? does this use case work with
http://www.ovirt.org/Features/Multiple_Gateways ?

the name is too long and not clear enough.how about no_display_net?

You must update the spec and makefile. See http://gerrit.ovirt.org/22124 for an example.
Line 11: 
Line 12: The configuration is described in the hook itself.
Line 13: 
Line 14: Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com&gt;


http://gerrit.ovirt.org/#/c/35661/1/vdsm_hooks/console_listen_on_all_ifs/...
File vdsm_hooks/console_listen_on_all_ifs/before_vm_start.py:

Line 57: 
Line 58: 
Line 59: def main():
Line 60:     try:
Line 61:         if config.getboolean('vars',
'console_listen_on_all_ifs'):
using vdsm.conf to control this hook is not a good idea, as it requires further setting on
each host, and apply to all VMs.

Per-VM custom property are a fine control lever.
Line 62:             sys.stderr.write('console_listen_on_all_ifs: '
Line 63:                              'starting to modify vm \n')
Line 64:             domxml = hooking.read_domxml()
Line 65:             adjust_graphics(domxml)


-- 
To view, visit http://gerrit.ovirt.org/35661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I512586497209cb631e684c5f09084dcecfca0ec3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes