Federico Simoncelli has posted comments on this change.
Change subject: Check if block device without invoking storage subsystem
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/vm.py
Line 254: def isBlockDevice(path):
I know it's against your principles (not overloading utils/misc), but wouldn't
make sense to expose this function somewhere else?
--
To view, visit
http://gerrit.ovirt.org/678
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia452c576b56f8d91fa1c6096237c2c150d746ac4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>