Federico Simoncelli has posted comments on this change.
Change subject: Refactor unit test directory structure
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
It's a little bit early to decide what to do. Let's add more tests and later on
decide how to organize them. As a start we could use modules, we'll move to packages
when it's needed.
....................................................
File Makefile.am
Line 40: $(MAKE) -C tests $@
It's already recursive, you don't need that. What target are you running? You
should use:
$ make check
....................................................
File tests/vdsm/storage/test_storage_exception.py
Line 23: from vdsm.storage import storage_exception
I'm not sure I like this, "vdsm" will be a package in the python sitelib.
--
To view, visit
http://gerrit.ovirt.org/2839
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5179f5c9711b3b8f353fc3ea590730059c9f3d7f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>