Federico Simoncelli has uploaded a new change for review.
Change subject: Mark vds_bootstrap as executable in the Makefile ......................................................................
Mark vds_bootstrap as executable in the Makefile
The bootstrap files should be always installed as executables (not only in the rpm package).
Change-Id: I0dd77ef76174e66d39526ce3833d2470128b0e19 --- M vds_bootstrap/Makefile.am M vdsm.spec.in M vdsm_reg/Makefile.am 3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/966/1 -- To view, visit http://gerrit.ovirt.org/966 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I0dd77ef76174e66d39526ce3833d2470128b0e19 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Mark vds_bootstrap as executable in the Makefile ......................................................................
Patch Set 2: Looks good to me, approved
I knew you wouldn't like my solution...
-- To view, visit http://gerrit.ovirt.org/966 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0dd77ef76174e66d39526ce3833d2470128b0e19 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Mark vds_bootstrap as executable in the Makefile ......................................................................
Patch Set 3: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/966 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I0dd77ef76174e66d39526ce3833d2470128b0e19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Mark vds_bootstrap as executable in the Makefile ......................................................................
Mark vds_bootstrap as executable in the Makefile
The bootstrap files should be always installed as executables (not only in the rpm package).
Change-Id: I0dd77ef76174e66d39526ce3833d2470128b0e19 --- M vds_bootstrap/Makefile.am M vdsm.spec.in M vdsm_reg/Makefile.am 3 files changed, 4 insertions(+), 4 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/966 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I0dd77ef76174e66d39526ce3833d2470128b0e19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com
vdsm-patches@lists.fedorahosted.org