Change in vdsm[master]: report network's underlying device as "iface"

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: report network's underlying device as "iface"
......................................................................

report network's underlying device as "iface"

ovirt-engine-3.1 expects to see "interface" for bridgeless networks, and
only for them. A recent patch http://gerrit.ovirt.org/6644 started
reporting "interface" for bridged networks, too. Which broke Engine.

I consider this an Engine bug (it should have relied on the "bridged"
attribute to decide if a network is bridged or not), but this cannot be
changed on the Engine side so near to the ovirt-3.1 release.

This patch reports "iface" for all networks, keeping "interface" only
for bridgeless networks, for ovirt-3.1 backward compatibility.

With this new API nit, we report a new cluster level 3.2.

Change-Id: Ibc8a5b8c66ecbb5cfd6378db358e38375b16c54c
Signed-off-by: Dan Kenigsberg 
---
M vdsm/netinfo.py
1 file changed, 14 insertions(+), 9 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/6806/1
--
To view, visit http://gerrit.ovirt.org/6806
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc8a5b8c66ecbb5cfd6378db358e38375b16c54c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: report network's underlying device as "iface"
......................................................................

Patch Set 2: I would prefer that you didn't submit this

You missed several usages of 'interface'.
I found two, but please recheck it again.

configNetwork.py:

ifaceUsers()
showNetwork()

--
To view, visit http://gerrit.ovirt.org/6806
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8a5b8c66ecbb5cfd6378db358e38375b16c54c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Moti Asayag

Moti Asayag has posted comments on this change.

Change subject: report network's underlying device as "iface"
......................................................................

Patch Set 2: Verified

Verified on rhel6.3:

iface attribute added to network devices and reports the correct network underlying device.

interface attribute is still reported for the same value as 'iface'

--
To view, visit http://gerrit.ovirt.org/6806
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8a5b8c66ecbb5cfd6378db358e38375b16c54c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Moti Asayag

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: report network's underlying device as "iface"
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6806
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8a5b8c66ecbb5cfd6378db358e38375b16c54c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Moti Asayag

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: report network's underlying device as "iface"
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/6806
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8a5b8c66ecbb5cfd6378db358e38375b16c54c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Moti Asayag

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: report network's underlying device as "iface"
......................................................................

report network's underlying device as "iface"

ovirt-engine-3.1 expects to see "interface" for bridgeless networks, and
only for them. A recent patch http://gerrit.ovirt.org/6644 started
reporting "interface" for bridged networks, too. Which broke Engine.

I consider this an Engine bug (it should have relied on the "bridged"
attribute to decide if a network is bridged or not), but this cannot be
changed on the Engine side so near to the ovirt-3.1 release.

This patch reports "iface" for all networks, keeping "interface" only
for bridgeless networks, for ovirt-3.1 backward compatibility.

With this new API nit, we report a new cluster level 3.2.

Change-Id: Ibc8a5b8c66ecbb5cfd6378db358e38375b16c54c
Signed-off-by: Dan Kenigsberg 
---
M vdsm/configNetwork.py
M vdsm/dsaversion.py.in
M vdsm/netinfo.py
3 files changed, 17 insertions(+), 12 deletions(-)

Approvals:
  Dan Kenigsberg: Verified
  Igor Lvovsky: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/6806
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc8a5b8c66ecbb5cfd6378db358e38375b16c54c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Livnat Peer 
Gerrit-Reviewer: Moti Asayag