On (Tue) 23 Apr 2013 [20:41:03], Amit Shah wrote:
On (Tue) 23 Apr 2013 [10:32:56], Cole Robinson wrote:
> On 04/23/2013 01:57 AM, Amit Shah wrote:
> > Hello,
> >
> > Fedora has carried flow control patches for qemu chardevs since a very
> > long time now. They weren't upstream, and they were required for
> > spice, usb-redir to work properly and not freeze the guest.
> >
> > Upstream qemu has now merged an alternative implementation of the same
> > concept, and most of the bugs have been shaken out upstream (we don't
> > know of any known bugs now). So I'm of the view we should replace
> > the older patches in F19's qemu with the backport of the newer,
> > upstream ones.
> >
> > Is this fine? I can work with Cole / Hans who have been keeping the
> > older patches uptodate on Fedora to replace the patches.
> >
>
> If the backport is fairly clean and self contained it should be okay, but
> can't say I'm excited about it. What's the benefit besides more testing
of the
> new code? Yes we get to drop the old patches but at this point they are a long
> tested known quantity. If it was a month ago I'd be less resistant but this
> will be past the alpha.
Yes, I was concerned about the timing too.
Cole mentioned on IRC about rawhide virt-preview, which I agree will
be a good idea to get this code into users' hands. So let's drop the
backport idea for now -- I'm quite relieved :)
Amit