Wiki pages: Missing tests in %check and missing upstream test suites

Richard W.M. Jones rjones at
Thu Feb 27 14:18:54 UTC 2014

On Thu, Feb 27, 2014 at 03:55:02PM +0200, Alexander Todorov wrote:
> Hi folks,
> thanks for your feedback in the last few days. I've created two wiki
> pages about packages which don't execute their tests in %check:

Of the two packages that have 'virt' in their title, it looks like
virt-manager genuinely contains tests upstream but they are not
enabled in Fedora.  Actually some tests fail in Fedora 20.

Attached is a proposed patch to the spec file.  I ran this under
auto-buildrequires to see if it would need any extra BRs, but auto-br
didn't find any.

I didn't want to push it because I have approximately no idea what I'm
doing with python / virt-manager & tests.

> and another one for packages which don't seem to have test suites at all:

virt-viewer is mentioned in this list.  Not sure how that could be
meaningfully tested since it requires an X11 display and a network
connection to a VM.

Keep up the good work,


Richard Jones, Virtualization Group, Red Hat
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
-------------- next part --------------
From 179896a12622b596408405c9b7e6c2ae221636d1 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones at>
Date: Thu, 27 Feb 2014 14:11:59 +0000
Subject: [PATCH] Enable tests, but do not fail if they don't pass.

 virt-manager.spec | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/virt-manager.spec b/virt-manager.spec
index f4ca564..971839f 100644
--- a/virt-manager.spec
+++ b/virt-manager.spec
@@ -162,6 +162,10 @@ python install -O1 --root=$RPM_BUILD_ROOT
 %find_lang %{name}
+python test ||:
 /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
 /usr/bin/update-desktop-database &> /dev/null || :

More information about the devel mailing list