Current FTBFS packages (was Re: [ACTION REQUIRED] Retiring packages for Fedora 21)
przemek.klosowski at nist.gov
Wed Jun 18 19:24:09 UTC 2014
On 06/18/2014 02:16 PM, Adam Jackson wrote:
> If I may vent for a moment, I'd like to point out exactly how spurious
> the blocks usage was (and, implicitly, troll for code review):
> That's right kids, the C89 version is less code even _before_ you
> count the actual Blocks runtime.
I should know better than start an argument about programming with you,
but isn't your patch leaking memory? I don't know how often hfsplus
tools allocate ctx->preMessage but just overwriting the pointer seems
off. At least a comment, maybe?
- if (bp)
- ctx->postMessage = (fsckBlock_t)Block_copy(bp);
+ /* possible memory leak: unlinking old postMessage */
+ ctx->postMessage = bp;
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the devel