excluding dot files from gems

Miroslav Suchý msuchy at redhat.com
Fri Dec 13 17:12:10 UTC 2013


On 12/11/2013 07:46 PM, Ken Dreyer wrote:
> What do you think about something like this?
>
> --- a/pkgwat.gemspec
> +++ b/pkgwat.gemspec
> @@ -26,6 +26,7 @@ Gem::Specification.new do|s|
>     s.add_development_dependency("debugger")
>
>     s.files         = `git ls-files`.split("\n")
> +  s.files        -= `git ls-files -- .??*`.split("\n")
>     s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
>     s.executables   = `git ls-files -- bin/*`.split("\n").map{|f|  File.basename(
>     s.require_paths = ["lib"]
>
> It seems like this would be a good pattern to propose to the various
> upstreams, but I wanted to get others' opinions first.

What if they would have ".a" file?
IMHO concept of generating list of list is wrong. You get used to that. And next time you add/remove something you would 
not check if it was actually added/removed in distributed package.
I personally simply enumerate those files (that top dir is not long) and if I ever add/remove something and I forgot to 
change it in that list, I get error. And then I have to *think* about it. Think if it should be included in result, or not.

-- 
Miroslav Suchy, RHCE, RHCDS
Red Hat, Software Engineer, #brno, #devexp, #fedora-buildsys


More information about the ruby-sig mailing list