[fedora-virt] Revert Snapshots - VM Definition won't revert

[Cole Robinson]

On 03/24/2014 05:21 PM, Jorge Fábregas wrote:
> Hi,
> 
> I just realized that when one does revert to a previous snapshot ("start
> a snapshot"), the properties of the actual virtual machine don't revert
> back as they looked when the snapshot was taken.  For example (on a
> powered-down VM):
> 
> - take snapshot X
> - Add some hardware (a new disk)
> - revert to snapshot X
> 
> At this point I would expect the recently added disk to be removed from
> the VM definition (and for the qcow2 file to be deleted from disk as
> well) since those weren't there when the snapshot was taken.
> 
> I think that's the correct way it should behave and thereforew, when you
> revert to a snapshot,  instead of saying;
> 
> "All disk changes since the last snapshot was created will be discarded."
> 
> ... it should simply say:
> 
> "All changes since the last snapshot was created will be discarded."
> 
> What do you guys think?
> 

Thanks for the suggestion. When the VM is offline, I changed the revert
message to 'all disk and configuration changes...'. I wanted to keep it
explicit with the 'disk' bit, since 'all changes' is a bit generic, and we
already use that phrase to refer to discarding UI changes in the details
dialog. I want the message to be very clear that we are talking about actual
changes inside the guest.

commit 9d743ab4c80416af481290018d2c1b026c4ed1ce
Author: Cole Robinson <crobinso at redhat.com>
Date:   Wed Mar 26 08:54:10 2014 -0400

    snapshots: Tweak warning before run

    Make it clear that VM configuration changes will also be dropped if
    reverting to a snapshot while the VM is offline.

    Suggested-by: Jorge Fábregas <jorge.fabregas at gmail.com>


Thanks,
Cole