Hi people,
I have done some work on tickets 262, 273 and 266 - concerning change of hook architecture to watcher/event and some refactoring of the AutoQA script.
Basically, the idea was to split the hook directory and put watchers into separate directory from hooks - which'd be called events. Together with this came the need to actually completely eliminate the term "hook" from AutoQA project, which I have done partially - on the main level. "Hooks" appear pretty much everywhere, including tests, so I am waiting with complete refactoring to events until I have some feedback.
So right now: hook directory ceased to exist, autoqa script mentions hooks no longer including the help messages etc., autoqa script has been organized into functions/procedures to make more sense, makefile has been rewritten accordingly to install the new directories, autoqa.config and cron files has also been edited to reflect the new "architecture".
To my knowledge and testing, these changes in architecture made no changes/regressions to the functionality, however I need you guys to confirm, if that is true. Additionally, if you have some time, please go over the change - as this was my first thing to do with AutoQA - to check whether I didn't create some obvious trouble.
I have created a new remote branch origin/vhumpa, where the code is stored. Please checkout the origin/vhumpa an try to "make clean install" the project and run some tests as you are used to, to see, if the behavior is the same. Please also delete the "/etc/autoqa.conf" before the first install as this file doesn't get deleted during the clean (the /usr/share/autoqa also didn't used to, however the new /usr/share/autoqa/watchers and /usr/share/autoqa/events now do).
I must admit that I am so far not familiar with the usual change confirming / patching process - please, anybody let me know if there is something particular to do that I omitted.
Thank you team! -- Vita Humpa Red Hat Brno