Hi Joza
- I'd support changing test_vars['hook'] to test_vars['event'] or
something similar, since we'd like to get rid of the 'hook' term overall, IIRC.
- Connects to (1) - if you decide to change that, then you'll also
need to change the control.autoqa files (specifically the "if hook not in [xyz, abc]" lines).
- I know it's not a programming issue, but changing README to reflect
current state of watcher/event parsing would be nice.
We've just went through the all the changes with Kamil and decided to go with all the three things above just like you recommended - basically to go "deeper" and really remove the occurrence of "hook" everywhere :)
+ couple more things - do not modify the clean behavior of Makefile (clean just the src dir) - edit specfile accordingly (Something I didn't do before) - rename the watchers all to watcher.py and rename their dirs as well
Thanks for the review! -- Vita Humpa