kparal and I had a discussion in IRC around the changes currently proposed in my patch for #265 - Create function to download RPMs from koji for given NVR. I am summarizing the conversation here.
- koji_utils is an extraordinarily difficult class to test due to the way that it is currently written and as such, was a poor choice for a testing proof-of-concept.
- The refactoring in koji_utils decreases the functionality in the class
- The advantages brought by the refactoring are not trivial to visualize and mostly affect the testability of the code
- tflink did miss a side-effect while testing that would break upgradepath
The current plan of action is: - tflink will rewrite the code for #265 in order to not change koji_utils
- testing will start with simpler code, if possible
- a ticket will be filed to deal with the testability issues in koji_utils.
Let us know if you have any other ideas/concerns/etc. I will be submitting a new patch for #265 in the next day or so.
Tim