On Mon, 2011-03-21 at 07:55 -0400, Josef Skladanka wrote:
Hi,
Just a few notes to #266:
1) I'd support changing test_vars['hook'] to test_vars['event'] or
something similar,
since we'd like to get rid of the 'hook' term overall, IIRC.
2) Connects to (1) - if you decide to change that, then you'll also need to change
the control.autoqa files (specifically the "if hook not in [xyz, abc]"
lines).
Possibly future enhancement, but these dictionary hook/event checks in
control.autoqa files seem too susceptible to failure. At least, I keep
messing them up :) Should we define a common method to use instead, or
is this a useless optimization?
def check_autoqa_event_support(event, approved_events=[],
required_kwargs[]):
if isinstance(String, approved_events):
approved_events = [approved_events]
if isinstance(String, restricted_events=):
restricted_events= = [restricted_events=]
if event in approved_events and not in restricted_events
return True
else:
return False
3) I know it's not a programming issue, but changing README to
reflect current state
of watcher/event parsing would be nice.
Good suggestion.
Thanks,
James