#279: depcheck: KeyError: 'visualvm-1.3.1-3.fc14' --------------------+------------------------------------------------------- Reporter: jlaska | Owner: jskladan Type: task | Status: new Priority: major | Milestone: 0.4.4 Component: tests | Keywords: --------------------+------------------------------------------------------- {{{ Packages skipped because of dependency problems: visualvm-1.3.1-3.fc14.x86_64 from f14-updates-testing visualvm-1.3.2-1.2.7.fc14.x86_64 from pending REJECT: visualvm-1.3.1-3.fc14.x86_64 visualvm-1.3.2-1.2.7.fc14.x86_64 ACCEPT: backintime-gnome-1.0.6-1.fc14.noarch xine-lib- devel-1.1.19-2.fc14.2.i686 2:postfix-2.7.3-1.fc14.x86_64 rawstudio-1.2-10.fc14.20110226svn3835.x86_64 directfb-1.4.11-3.fc14.i686 puddletag-0.10.0-1.fc14.noarch docky-devel-2.0.12-1.fc14.i686 backintime- common-1.0.6-1.fc14.noarch tintin-2.00.6-1.fc14.x86_64 docky- devel-2.0.12-1.fc14.x86_64 ghc-ForSyDe-prof-3.1.1-4.fc14.x86_64 ghc- ForSyDe-devel-3.1.1-4.fc14.x86_64 ghc-ForSyDe-devel-3.1.1-4.fc14.i686 perl-voms-server-0.11-1.fc14.noarch directfb-1.4.11-3.fc14.x86_64 perl- VOMS-Lite-0.11-1.fc14.noarch docky-2.0.12-1.fc14.x86_64 backintime- kde-1.0.6-1.fc14.noarch perl-VOMS-Lite-tests-0.11-1.fc14.noarch tintin- doc-2.00.6-1.fc14.noarch directfb-devel-1.4.11-3.fc14.x86_64 xine-lib- devel-1.1.19-2.fc14.2.x86_64 xine-lib-extras-1.1.19-2.fc14.2.i686 tzdata- 2011b-3.fc14.noarch 2:postfix-perl-scripts-2.7.3-1.fc14.x86_64 perl- Package-DeprecationManager-0.10-3.fc14.noarch jpilot-1.8.0-2.fc14.x86_64 xine-lib-1.1.19-2.fc14.2.x86_64 rawstudio-1.2-10.fc14.20110226svn3835.i686 ghc-ForSyDe-3.1.1-4.fc14.x86_64 xine-lib-1.1.19-2.fc14.2.i686 xine-lib- extras-1.1.19-2.fc14.2.x86_64 directfb-devel-1.4.11-3.fc14.i686 scap- workbench-0.2.3-1.fc14.noarch vifir-0.8-1.fc14.x86_64 tzdata-java- 2011b-3.fc14.noarch ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/autoqa/decorators.py", line 71, in newf f_result = f(*args, **kwargs) #call the decorated function File "/usr/share/autotest/tests/depcheck/depcheck.py", line 133, in run_once rejected_builds = set([pending_parent_map[nvr] for nvr in rejected_nvrs]) KeyError: 'visualvm-1.3.1-3.fc14' }}}
Complete log available at http://test1186.test.redhat.com/results/104-autotest/test189.test.redhat.com...
#279: depcheck: KeyError: 'visualvm-1.3.1-3.fc14' --------------------+------------------------------------------------------- Reporter: jlaska | Owner: jskladan Type: task | Status: new Priority: major | Milestone: 0.4.4 Component: tests | Resolution: Keywords: | --------------------+------------------------------------------------------- Old description:
{{{ Packages skipped because of dependency problems: visualvm-1.3.1-3.fc14.x86_64 from f14-updates-testing visualvm-1.3.2-1.2.7.fc14.x86_64 from pending REJECT: visualvm-1.3.1-3.fc14.x86_64 visualvm-1.3.2-1.2.7.fc14.x86_64 ACCEPT: backintime-gnome-1.0.6-1.fc14.noarch xine-lib- devel-1.1.19-2.fc14.2.i686 2:postfix-2.7.3-1.fc14.x86_64 rawstudio-1.2-10.fc14.20110226svn3835.x86_64 directfb-1.4.11-3.fc14.i686 puddletag-0.10.0-1.fc14.noarch docky-devel-2.0.12-1.fc14.i686 backintime- common-1.0.6-1.fc14.noarch tintin-2.00.6-1.fc14.x86_64 docky- devel-2.0.12-1.fc14.x86_64 ghc-ForSyDe-prof-3.1.1-4.fc14.x86_64 ghc- ForSyDe-devel-3.1.1-4.fc14.x86_64 ghc-ForSyDe-devel-3.1.1-4.fc14.i686 perl-voms-server-0.11-1.fc14.noarch directfb-1.4.11-3.fc14.x86_64 perl- VOMS-Lite-0.11-1.fc14.noarch docky-2.0.12-1.fc14.x86_64 backintime- kde-1.0.6-1.fc14.noarch perl-VOMS-Lite-tests-0.11-1.fc14.noarch tintin- doc-2.00.6-1.fc14.noarch directfb-devel-1.4.11-3.fc14.x86_64 xine-lib- devel-1.1.19-2.fc14.2.x86_64 xine-lib-extras-1.1.19-2.fc14.2.i686 tzdata- 2011b-3.fc14.noarch 2:postfix-perl-scripts-2.7.3-1.fc14.x86_64 perl- Package-DeprecationManager-0.10-3.fc14.noarch jpilot-1.8.0-2.fc14.x86_64 xine-lib-1.1.19-2.fc14.2.x86_64 rawstudio-1.2-10.fc14.20110226svn3835.i686 ghc- ForSyDe-3.1.1-4.fc14.x86_64 xine-lib-1.1.19-2.fc14.2.i686 xine-lib- extras-1.1.19-2.fc14.2.x86_64 directfb-devel-1.4.11-3.fc14.i686 scap- workbench-0.2.3-1.fc14.noarch vifir-0.8-1.fc14.x86_64 tzdata-java- 2011b-3.fc14.noarch
Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/autoqa/decorators.py", line 71, in newf f_result = f(*args, **kwargs) #call the decorated function File "/usr/share/autotest/tests/depcheck/depcheck.py", line 133, in run_once rejected_builds = set([pending_parent_map[nvr] for nvr in rejected_nvrs]) KeyError: 'visualvm-1.3.1-3.fc14' }}}
Complete log available at http://test1186.test.redhat.com/results/104-autotest/test189.test.redhat.com...
New description:
Looks like the depcheck test runs to completion, but then the depcheck.py wrapper 'splodes while parsing REJECTED results.
{{{ Packages skipped because of dependency problems: visualvm-1.3.1-3.fc14.x86_64 from f14-updates-testing visualvm-1.3.2-1.2.7.fc14.x86_64 from pending REJECT: visualvm-1.3.1-3.fc14.x86_64 visualvm-1.3.2-1.2.7.fc14.x86_64 ACCEPT: backintime-gnome-1.0.6-1.fc14.noarch xine-lib- devel-1.1.19-2.fc14.2.i686 2:postfix-2.7.3-1.fc14.x86_64 rawstudio-1.2-10.fc14.20110226svn3835.x86_64 directfb-1.4.11-3.fc14.i686 puddletag-0.10.0-1.fc14.noarch docky-devel-2.0.12-1.fc14.i686 backintime- common-1.0.6-1.fc14.noarch tintin-2.00.6-1.fc14.x86_64 docky- devel-2.0.12-1.fc14.x86_64 ghc-ForSyDe-prof-3.1.1-4.fc14.x86_64 ghc- ForSyDe-devel-3.1.1-4.fc14.x86_64 ghc-ForSyDe-devel-3.1.1-4.fc14.i686 perl-voms-server-0.11-1.fc14.noarch directfb-1.4.11-3.fc14.x86_64 perl- VOMS-Lite-0.11-1.fc14.noarch docky-2.0.12-1.fc14.x86_64 backintime- kde-1.0.6-1.fc14.noarch perl-VOMS-Lite-tests-0.11-1.fc14.noarch tintin- doc-2.00.6-1.fc14.noarch directfb-devel-1.4.11-3.fc14.x86_64 xine-lib- devel-1.1.19-2.fc14.2.x86_64 xine-lib-extras-1.1.19-2.fc14.2.i686 tzdata- 2011b-3.fc14.noarch 2:postfix-perl-scripts-2.7.3-1.fc14.x86_64 perl- Package-DeprecationManager-0.10-3.fc14.noarch jpilot-1.8.0-2.fc14.x86_64 xine-lib-1.1.19-2.fc14.2.x86_64 rawstudio-1.2-10.fc14.20110226svn3835.i686 ghc-ForSyDe-3.1.1-4.fc14.x86_64 xine-lib-1.1.19-2.fc14.2.i686 xine-lib- extras-1.1.19-2.fc14.2.x86_64 directfb-devel-1.4.11-3.fc14.i686 scap- workbench-0.2.3-1.fc14.noarch vifir-0.8-1.fc14.x86_64 tzdata-java- 2011b-3.fc14.noarch ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/autoqa/decorators.py", line 71, in newf f_result = f(*args, **kwargs) #call the decorated function File "/usr/share/autotest/tests/depcheck/depcheck.py", line 133, in run_once rejected_builds = set([pending_parent_map[nvr] for nvr in rejected_nvrs]) KeyError: 'visualvm-1.3.1-3.fc14' }}}
Complete log available at http://test1186.test.redhat.com/results/104-autotest/test189.test.redhat.com...
#279: depcheck: KeyError: 'visualvm-1.3.1-3.fc14' --------------------+------------------------------------------------------- Reporter: jlaska | Owner: jskladan Type: task | Status: new Priority: major | Milestone: 0.4.4 Component: tests | Resolution: Keywords: | --------------------+------------------------------------------------------- Changes (by kparal):
* cc: wwoods (added)
Comment:
I have found the root issue. Depcheck test reports visualvm-1.3.1-3.fc14.x86_64 and visualvm-1.3.2-1.2.7.fc14.x86_64 as rejected, but only the second one was passed to it as an input value (pending update). Our test wrapper doesn't expect to see a rejected package that was not amongst the input packages.
Sadly it was not discovered during testing because we were unable to find broken dependencies at that time (weird, I know). Also our internet speed limits us in making too many test runs.
The question is now where to fix it. We can do it in the test object, that should be easy. But I believe it would be more proper to fix it in the depcheck test. Will's advice is needed here. Also, although I believe it's just a one-liner fix ("rejected = skipped_packages.intersection(input_packages)"), it's hard for me to do without spending hours to study those yum objects (how to retrieve those input_packages?).
Will, can you please comment on this?
If this is not solved quickly inside depcheck (or if Will doesn't suggest this is the intended behavior), we will solve this matter inside the test wrapper and deal with this issue properly later.
#279: depcheck: KeyError: 'visualvm-1.3.1-3.fc14' --------------------+------------------------------------------------------- Reporter: jlaska | Owner: jskladan Type: task | Status: new Priority: major | Milestone: 0.4.4 Component: tests | Resolution: Keywords: | --------------------+------------------------------------------------------- Comment (by kparal):
The quick patch in the test object is here:
https://fedorahosted.org/reviewboard/r/118/
#279: depcheck: KeyError: 'visualvm-1.3.1-3.fc14' --------------------+------------------------------------------------------- Reporter: jlaska | Owner: jskladan Type: task | Status: new Priority: major | Milestone: 0.4.4 Component: tests | Resolution: Keywords: | --------------------+------------------------------------------------------- Comment (by kparal):
Since wwoods said the depecheck behavior is expected, I have modified the patch to produce better output (it's not warning now, just a note, and it is not being put into highlights):
https://fedorahosted.org/reviewboard/r/118/
#279: depcheck: KeyError: 'visualvm-1.3.1-3.fc14' --------------------+------------------------------------------------------- Reporter: jlaska | Owner: jskladan Type: task | Status: closed Priority: major | Milestone: 0.4.4 Component: tests | Resolution: fixed Keywords: | --------------------+------------------------------------------------------- Changes (by kparal):
* status: new => closed * resolution: => fixed
Comment:
Fix pushed as 2777392e98b2756c5b838da5744838e429e437e5 .
autoqa-devel@lists.fedorahosted.org
-
fedora-badges