#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi --------------------+------------------------------------------------------- Reporter: tflink | Owner: Type: task | Status: new Priority: major | Milestone: Hot issues Component: core | Keywords: --------------------+------------------------------------------------------- With the current setup, maintainers are sent an email with every single comment made by AutoQA.
These emails aren't particularly useful and increase the amount of noise that maintainers need to filter out.
Find a way to decrease the number of useless emails sent to maintainers.
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi --------------------+------------------------------------------------------- Reporter: tflink | Owner: tflink Type: task | Status: assigned Priority: major | Milestone: Hot issues Component: core | Resolution: Keywords: | --------------------+------------------------------------------------------- Changes (by tflink):
* owner: => tflink * status: new => assigned
Comment:
lmacken made changes in bodhi and python-fedora to support email-less comments: * https://fedorahosted.org/bodhi/changeset/88d39aac30319c2a2c6c3f2632aa76d4c8e... * https://fedorahosted.org/python-fedora/changeset/devel%2C691
We need to change bodhi_utils to make "PASSED" comments like: {{{ #!python bodhi.comment(update, comment, karma, Email=False) }}}
I'll get a patch written and once the packages are pushed to updates- testing, send out a call for karma so we can get this rolled out.
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi --------------------+------------------------------------------------------- Reporter: tflink | Owner: tflink Type: task | Status: assigned Priority: major | Milestone: Hot issues Component: core | Resolution: Keywords: | --------------------+------------------------------------------------------- Comment (by tflink):
Review request created: * https://fedorahosted.org/reviewboard/r/142/
Keep in mind that this code won't be valid until we get a new build of python-fedora. If anyone notices the build, feel free to send out a request for testing. I suppose that we could test with the package from updates-testing, though.
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi --------------------+------------------------------------------------------- Reporter: tflink | Owner: tflink Type: task | Status: assigned Priority: major | Milestone: 0.5.0 Component: core | Resolution: Keywords: | --------------------+------------------------------------------------------- Changes (by timn):
* cc: timn (added)
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi --------------------+------------------------------------------------------- Reporter: tflink | Owner: tflink Type: task | Status: assigned Priority: major | Milestone: 0.5.0 Component: core | Resolution: Keywords: | --------------------+------------------------------------------------------- Comment (by tflink):
As Kamil mentioned in an email thread, the solution I proposed here is way too simplistic and would cause more problems than it would solve. This is going to require a little more thought before implementing. Review request discarded.
Conversation on autoqa-devel (split due to the month change): * https://fedorahosted.org/pipermail/autoqa-devel/2011-April/002133.html * https://fedorahosted.org/pipermail/autoqa-devel/2011-May/002139.html
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi --------------------+------------------------------------------------------- Reporter: tflink | Owner: tflink Type: task | Status: assigned Priority: major | Milestone: 0.5.0 Component: core | Resolution: Keywords: | --------------------+------------------------------------------------------- Old description:
With the current setup, maintainers are sent an email with every single comment made by AutoQA.
These emails aren't particularly useful and increase the amount of noise that maintainers need to filter out.
Find a way to decrease the number of useless emails sent to maintainers.
New description:
With the current setup, maintainers are sent an email with every single comment made by AutoQA.
These emails aren't particularly useful and increase the amount of noise that maintainers need to filter out.
Find a way to decrease the number of useless emails sent to maintainers.
A full feature description can be found on [wiki:Planning05xEmailReduction the associated planning wiki page]
Comment (by tflink):
I pushed up an initial pass at code to reduce the number of emails sent by AutoQA through bodhi. The code and associated tests are in the tflink branch - df3d9cb12df3f6324eb9c7d9005c5eb7a6263f02
The code is by no means complete, there are some duplication issues and nothing is configurable yet. However, I want to give people a chance to review and comment on the way I'm doing this before I get any farther.
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi --------------------+------------------------------------------------------- Reporter: tflink | Owner: tflink Type: task | Status: assigned Priority: major | Milestone: 0.5.0 Component: core | Resolution: Keywords: | --------------------+------------------------------------------------------- Comment (by tflink):
I updated the code in the tflink branch to support configuration and to have better support for 32 bit results. I haven't tested it a whole lot yet due to the difficulty in doing so but I'm planning to do more testing before we release. I also haven't updated from master yet. I figured that could happen when it gets merged with the other features.
Commit with changes: 82cf7ce3dbefcafff82b8fe860dfce22efda93c0
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi --------------------+------------------------------------------------------- Reporter: tflink | Owner: tflink Type: task | Status: closed Priority: major | Milestone: 0.5.0 Component: core | Resolution: fixed Keywords: | --------------------+------------------------------------------------------- Changes (by tflink):
* status: assigned => closed * resolution: => fixed
Comment:
Code has been reviewed and pushed to master:
613fa26bf144e2c90146344c686cd01eeeca1939
Testing will start when we get all the 0.5.0 features pushed to master.
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi ---------------------------+------------------------------------------------ Reporter: tflink | Owner: tflink Type: task | Status: reopened Priority: major | Milestone: 0.5.0 Component: documentation | Resolution: Keywords: | ---------------------------+------------------------------------------------ Changes (by kparal):
* status: closed => reopened * resolution: fixed => * component: core => documentation
Comment:
Maybe this ticket will require some wiki doc adjustments. Changing to documentation component until we do that.
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi ---------------------------+------------------------------------------------ Reporter: tflink | Owner: tflink Type: task | Status: reopened Priority: major | Milestone: 0.5.0 Component: documentation | Resolution: Keywords: | ---------------------------+------------------------------------------------ Comment (by tflink):
Added documentation about configuration settings to the trac wiki. This documentation can be found at https://fedorahosted.org/autoqa/wiki/autoqaconf
I don't think that much else would need to be documented. If there are other things, let me know otherwise I will close this ticket soon.
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi ---------------------------+------------------------------------------------ Reporter: tflink | Owner: tflink Type: task | Status: reopened Priority: major | Milestone: 0.5.0 Component: documentation | Resolution: Keywords: | ---------------------------+------------------------------------------------ Comment (by kparal):
Great job, I just have a few comments:
1. Do we want to have two separate autoqa.conf documentation places? The first is inside the file itself, the second is online. I am kind of reluctant to maintain it at two places, I don't see the benefit. OTOH I understand that our wiki allows us to express some ideas better - like the two tables you created, they are great.
2. The new page should be linked from somewhere, otherwise only a handful of people would find it.
I would propose following:
a) Let's keep as much as possible of our documentation inside autoqa.conf. Let's document online only those options that need very detailed explanation or for which a plain text format is not sufficient.
b) Let's link the extended documentation directly from autoqa.conf (put a hyperlink in the first few lines of that file).
We should also think about fpo wiki and trac wiki. Do we want to have all of our documentation at one place, or do we have some system of splitting up content, or are we fine with having it randomly distributed?
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi ---------------------------+------------------------------------------------ Reporter: tflink | Owner: tflink Type: task | Status: reopened Priority: major | Milestone: 0.5.0 Component: documentation | Resolution: Keywords: | ---------------------------+------------------------------------------------ Comment (by tflink):
Replying to [comment:11 kparal]:
- Do we want to have two separate autoqa.conf documentation places? The
first is inside the file itself, the second is online. I am kind of reluctant to maintain it at two places, I don't see the benefit. OTOH I understand that our wiki allows us to express some ideas better - like the two tables you created, they are great.
No, I don't think that we do. The duplication occurred to me while I was writing it but figured that this would work for now.
- The new page should be linked from somewhere, otherwise only a
handful of people would find it.
I would propose following:
a) Let's keep as much as possible of our documentation inside
autoqa.conf. Let's document online only those options that need very detailed explanation or for which a plain text format is not sufficient.
b) Let's link the extended documentation directly from autoqa.conf (put
a hyperlink in the first few lines of that file).
OK, that makes sense. Expand upon the examples and what a 'state change' is on the wiki page but otherwise keep the docs in the comments for the conf file.
We should also think about fpo wiki and trac wiki. Do we want to have
all of our documentation at one place, or do we have some system of splitting up content, or are we fine with having it randomly distributed?
Agreed but I also think that's a conversation for autoqa-devel.
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi ---------------------------+------------------------------------------------ Reporter: tflink | Owner: tflink Type: task | Status: reopened Priority: major | Milestone: 0.5.0 Component: documentation | Resolution: Keywords: | ---------------------------+------------------------------------------------ Comment (by tflink):
I updated the [wiki:autoqaconf configuration page in the trac wiki] to do more than just duplicate the comments in autoqa.conf.
I also added links to that page in autoqa.conf * 1ed5906019cde47fdf4c0939c1f58e84a06a96dc
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi ---------------------------+------------------------------------------------ Reporter: tflink | Owner: tflink Type: task | Status: reopened Priority: major | Milestone: 0.5.0 Component: documentation | Resolution: Keywords: | ---------------------------+------------------------------------------------ Comment (by jlaska):
Replying to [comment:13 tflink]:
I updated the [wiki:autoqaconf configuration page in the trac wiki] to
do more than just duplicate the comments in autoqa.conf.
Ooh good stuff! I like the examples. I made some minor table tweaks on the wiki doc in the hopes to make it slightly more readable. Feel free to adjust/revert as desired.
#314: Decrease the volume of 'PASSED' email sent to maintainers from bodhi --------------------+------------------------------------------------------- Reporter: tflink | Owner: tflink Type: task | Status: closed Priority: major | Milestone: 0.5.0 Component: core | Resolution: fixed Keywords: | --------------------+------------------------------------------------------- Changes (by kparal):
* status: reopened => closed * resolution: => fixed * component: documentation => core
Comment:
I think this ticket can be closed. Any objections?
autoqa-devel@lists.fedorahosted.org
-
fedora-badges