ReviewBoad instance for AutoQA

[Tim Flink]

Our fedorahosted ReviewBoard instance was activated faster than I
thought it would be and is now active.

Login with FAS credentials at:
https://fedorahosted.org/reviewboard/

Our group name is (surprise, surprise) autoqa.

I went ahead and uploaded my patch for #265 to the system as a test [1].
Add comments to specific lines by clicking on the line number in the
diff. Add general comments using the review button.

There is also a command line tool for simplifying diff submission [2]
but I haven't tried it yet.

Thoughts?

Tim

[1] https://fedorahosted.org/reviewboard/r/117/
[2] http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/

[Kamil Paral]

----- Original Message -----
> Our fedorahosted ReviewBoard instance was activated faster than I
> thought it would be and is now active.
>
> Login with FAS credentials at:
> https://fedorahosted.org/reviewboard/
>
> Our group name is (surprise, surprise) autoqa.
>
> I went ahead and uploaded my patch for #265 to the system as a test
> [1].
> Add comments to specific lines by clicking on the line number in the
> diff. Add general comments using the review button.
>
> There is also a command line tool for simplifying diff submission [2]
> but I haven't tried it yet.
>
> Thoughts?
>
> Tim
>
> [1] https://fedorahosted.org/reviewboard/r/117/
> [2]
> http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/

Ooooo, looks nice! I didn't know we can already use it, I am subscribed to the infrastructure ticket [1] and nothing changed in a long time. The Zimbra-like performance is unpleasant, but it seems usable enough. The email notifications can be compensated by emails to autoqa-devel.

I say let's use it for our patches and we will see what the overall experience will be like. Great work, Tim.

[1] https://fedorahosted.org/fedora-infrastructure/ticket/1196

[Tim Flink]

On 03/10/2011 03:27 AM, Kamil Paral wrote:
> ----- Original Message -----
> > Our fedorahosted ReviewBoard instance was activated faster than I 
> > thought it would be and is now active.
> >
> > Login with FAS credentials at: 
> > https://fedorahosted.org/reviewboard/
> >
> > Our group name is (surprise, surprise) autoqa.
> >
> > I went ahead and uploaded my patch for #265 to the system as a
> > test [1]. Add comments to specific lines by clicking on the line
> > number in the diff. Add general comments using the review button.
> >
> > There is also a command line tool for simplifying diff submission
> > [2] but I haven't tried it yet.
> >
> > Thoughts?
> >
> > Tim
> >
> > [1] https://fedorahosted.org/reviewboard/r/117/ [2] 
> > http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/
> >
>
> Ooooo, looks nice! I didn't know we can already use it, I am
> subscribed to the infrastructure ticket [1] and nothing changed in a
> long time. The Zimbra-like performance is unpleasant, but it seems
> usable enough. The email notifications can be compensated by emails
> to autoqa-devel.
>
> I say let's use it for our patches and we will see what the overall
> experience will be like. Great work, Tim.
>
> [1] https://fedorahosted.org/fedora-infrastructure/ticket/1196

It sounds like work on ReviewBoard has stalled for now due to a shift in
priorities for the people involved. I didn't ask for details on what was
left to do but if we use it enough and are frustrated with
performance/emails, we could always offer to help :)

Tim

[Kamil Paral]

----- Original Message -----
> Add comments to specific lines by clicking on the line number in the
> diff. Add general comments using the review button.

Is it possible to add several different comments to a single line somehow? I can't find the way.

[Tim Flink]

On 03/14/2011 06:39 AM, Kamil Paral wrote:
> ----- Original Message -----
> > Add comments to specific lines by clicking on the line number in the
> > diff. Add general comments using the review button.
>
> Is it possible to add several different comments to a single line somehow? I can't find the way.

I can't figure out a way to do it, either. The only thing that I can
think of is to put everything into one comment.

Tim

[James Laska]

On Mon, 2011-03-14 at 08:34 -0600, Tim Flink wrote:
> On 03/14/2011 06:39 AM, Kamil Paral wrote:
> > ----- Original Message -----
> > > Add comments to specific lines by clicking on the line number in the
> > > diff. Add general comments using the review button.
> >
> > Is it possible to add several different comments to a single line somehow? I can't find the way.
>
> I can't figure out a way to do it, either. The only thing that I can
> think of is to put everything into one comment.

Possibly off-topic, does anyone have experience with gerrit?

https://code.google.com/p/gerrit/

Thanks,
James