[AutoQA] #354: Custom 404 page for autoqa.fp.o

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |       Owner:       
     Type:  task      |      Status:  new  
 Priority:  minor     |   Milestone:  0.6.0
Component:  autotest  |    Keywords:       
----------------------+-----------------------------------------------------
 Quoting tflink:

For some reason, this came to mind when I was thinking about the bodhi
 link issue but how do we feel about putting a custom 404 on autoqa.fp.o?

Since we don't keep logs forever, anything that links to old results
 goes to a generic 404 without more explanation than "could not find the
 file you were looking for". Instead, we could do a custom 404 that
 contains:

- Explanation of log retention policy
  - Relevant AutoQA or FedoraQA links

It would involve a small change to the apache config and some static
 HTML on the autotest server. Pretty easy finger food :)

https://fedorahosted.org/pipermail/autoqa-devel/2011-July/002546.html

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  new    
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:         
 Keywords:            |  
----------------------+-----------------------------------------------------
Changes (by kparal):

* owner:  => mkrizek

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  new    
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:         
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by mkrizek):

To activate custom 404 page add "ErrorDocument 404 /404.html" into
 /etc/httpd/autotest.conf (VirtualHost directive) and copy files 404.html
 and autoqa.png into autotest document root -
 /usr/share/autotest/apache/www.

Any comments on solution of this?

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  new    
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:         
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by jskladan):

Makes sense :) Just a minor tweak - I'd recommend putting the 404.html
 page not directly into document root, but into a 'errordocs' directory
 (which is imho 'standard' in apache).

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  new    
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:         
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by kparal):

Replying to [comment:2 mkrizek]:
> To activate custom 404 page add "ErrorDocument 404 /404.html" into

/etc/httpd/autotest.conf (VirtualHost directive) and copy files 404.html
 and autoqa.png into autotest document root -
 /usr/share/autotest/apache/www.

The path should be /etc/httpd/conf.d/autotest.conf.

I tested this approach and it works OK.

Could you please prepare a patch (including Makefile and packaging
 changes)? Thanks.

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  new    
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:         
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by mkrizek):

Patch: https://fedorahosted.org/reviewboard/r/192/

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  new    
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:         
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by jlaska):

Replying to [comment:5 mkrizek]:
> Patch: https://fedorahosted.org/reviewboard/r/192/

Thanks Martin, I added some feedback to the review request.

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  new    
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:         
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by mkrizek):

Thanks for the review, I reuploaded the patch.

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  new    
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:         
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by kparal):

Added comments.

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  new    
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:         
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by mkrizek):

Thanks, the patch is updated.

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  new    
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:         
 Keywords:            |  
----------------------+-----------------------------------------------------
Comment (by kparal):

Reviewed. But let's wait for some other approval, I am not skilled in
 these apache-like matters much.

[fedora-badges]

#354: Custom 404 page for autoqa.fp.o
----------------------+-----------------------------------------------------
 Reporter:  kparal    |        Owner:  mkrizek
     Type:  task      |       Status:  closed 
 Priority:  minor     |    Milestone:  0.6.0  
Component:  autotest  |   Resolution:  fixed  
 Keywords:            |  
----------------------+-----------------------------------------------------
Changes (by mkrizek):

* status:  new => closed
  * resolution:  => fixed

Comment:

Pushed into master as 518a74677ce205f5fbae924fcfe08548b5493065