This is in the ctor of the consumer resource.
if (username != null) { this.owner = ownerCurator.lookupByName(username); if (owner == null) { owner = ownerCurator.create(new Owner(username)); } }
I assume this should be FIXME?
-- bk
----- "Bryan Kearney" bkearney@redhat.com wrote:
This is in the ctor of the consumer resource.
if (username != null) { this.owner = ownerCurator.lookupByName(username); if (owner == null) { owner = ownerCurator.create(new Owner(username)); } }
I assume this should be FIXME?
I think that if the resource is a singleton then this is quite a problem...
-- bk _______________________________________________ candlepin mailing list candlepin@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/candlepin
On 03/26/2010 02:49 PM, Justin Harris wrote:
----- "Bryan Kearney"bkearney@redhat.com wrote:
This is in the ctor of the consumer resource.
if (username != null) { this.owner = ownerCurator.lookupByName(username); if (owner == null) { owner = ownerCurator.create(new Owner(username)); } }
I assume this should be FIXME?
I think that if the resource is a singleton then this is quite a problem...
Even if not :) Why create a new owner for a username?
-- bk
On Fri, Mar 26, 2010 at 02:41:11PM -0400, Bryan Kearney wrote:
This is in the ctor of the consumer resource.
if (username != null) { this.owner = ownerCurator.lookupByName(username); if (owner == null) { owner = ownerCurator.create(new Owner(username)); } }
I assume this should be FIXME?
+1 I think it does need a fixme.
candlepin@lists.fedorahosted.org