-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 03/29/2010 10:42 AM, Bryan Kearney wrote:
On 03/26/2010 04:19 PM, Jesus Rodriguez wrote:
On Fri, Mar 26, 2010 at 03:07:42PM -0400, Bryan Kearney wrote:
I took my own advice.. And reviewed one of the existing stories. I have a bunch of comments below.
Reviewing the Create Consumer Code
ConsumerResource
- I assume the owner creation code in the ctor should be a fixme.
+1
- Should the Identity cert creation go into the Curator? This seems like
business logic.
Probably not, I just reworked the create method, but I still left it mostly intact. I could probably use even more cleanup like you mention.
Why not? I am just curious on this one.. trying to figure out the role of the curator.
Cuz that sentence didn't make any sense :) I *think* I was trying to say that it probably was not moved to the curator. I agree it probably SHOULD go there :)
sorry for the confusion.
jesus
- -- jesus m. rodriguez | jesusr@redhat.com principal software engineer | irc: zeus red hat systems management | 919.754.4413 (w) rhce # 805008586930012 | 919.623.0080 (c) +---------------------------------------------+ | "Those who cannot remember the past | | are condemned to repeat it." | | -- George Santayana | +---------------------------------------------+