-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
CandlepinConfiguration -
* Why is there a special JPAConfiguration class?
JPAConfiguration
* see first question above :)
* in parseConfig() instead of looking to see if the key exists, why not pre-populate the map with all the defaults first, THEN override the ones the user passes in?
I fear that if we add more 'defaults', we'll have to add yet another check for each additional one.
Thinking something like:
JPAConfiguration() { ... defaultConfigurationSettings(); ... }
Then when you call parseConfig() you just have to add what came in.
CandlepinProductionConfiguration -
* I'm stuff fuzzy on why we have this (I know it sets up the "production" config but feels odd to me still)
persistence.xml -
* AWESOME, I'm glad to see this go.
- -- jesus m. rodriguez | jesusr@redhat.com principal software engineer | irc: zeus red hat systems management | 919.754.4413 (w) rhce # 805008586930012 | 919.623.0080 (c) +---------------------------------------------+ | "Those who cannot remember the past | | are condemned to repeat it." | | -- George Santayana | +---------------------------------------------+
On 02/11/2010 06:47 PM, Jesus M. Rodriguez wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
CandlepinConfiguration -
- Why is there a special JPAConfiguration class?
JPAConfiguration
in the new incarnation the class has responsibility of parsing persistence.xml and returning property values for 'production' persistence unit that are used as defualts.
see first question above :)
in parseConfig() instead of looking to see if the key exists, why not pre-populate the map with all the defaults first, THEN override the ones the user passes in?
I fear that if we add more 'defaults', we'll have to add yet another check for each additional one.
Thinking something like:
JPAConfiguration() { ... defaultConfigurationSettings(); ... }
Then when you call parseConfig() you just have to add what came in.
The above stuff is no longer present in JPAConfiguration.
CandlepinProductionConfiguration -
- I'm stuff fuzzy on why we have this (I know it sets up the "production" config but feels odd to me still)
we have different bindings for test environment and production one. One of the differences for example, is what persistence unit should be used.
persistence.xml -
- AWESOME, I'm glad to see this go.
Unfortunately it has to stay.
-Dmitri
candlepin@lists.fedorahosted.org