A change in candlepin/config/ConfigProperties.java

[William Poteat]

      // Authentication
>   -    public static final String TRUSTED_AUTHENTICATION =
> "candlepin.auth.trusted.enabled";
>   -    public static final String SSL_AUTHENTICATION =
> "candlepin.auth.ssl.enabled";
>   -    public static final String OAUTH_AUTHENTICATION =
> "candlepin.auth.oauth.enabled";
>   -    public static final String BASIC_AUTHENTICATION =
> "candlepin.auth.basic.enabled";
>   +    public static final String TRUSTED_AUTHENTICATION =
> "candlepin.auth.trusted.enable";
>   +    public static final String SSL_AUTHENTICATION =
> "candlepin.auth.ssl.enable";
>   +    public static final String OAUTH_AUTHENTICATION =
> "candlepin.auth.oauth.enable";
>   +    public static final String BASIC_AUTHENTICATION =
> "candlepin.auth.basic.enable"; 

-- 
+-----------------------------+
William Poteat
Senior Software Engineer
Red Hat
919.890.8823 Phone
919.830.7189 Cell

wpoteat(a)redhat.com
+-----------------------------+

[katello-devel] A change in candlepin/config/ConfigProperties.java

[Jason Rist]

On 08/15/2011 08:17 AM, William Poteat wrote:
>  
>  
>       // Authentication
> >  -    public static final String TRUSTED_AUTHENTICATION =
> > "candlepin.auth.trusted.enabled";
> >  -    public static final String SSL_AUTHENTICATION =
> > "candlepin.auth.ssl.enabled";
> >  -    public static final String OAUTH_AUTHENTICATION =
> > "candlepin.auth.oauth.enabled";
> >  -    public static final String BASIC_AUTHENTICATION =
> > "candlepin.auth.basic.enabled";
> >  +    public static final String TRUSTED_AUTHENTICATION =
> > "candlepin.auth.trusted.enable";
> >  +    public static final String SSL_AUTHENTICATION =
> > "candlepin.auth.ssl.enable";
> >  +    public static final String OAUTH_AUTHENTICATION =
> > "candlepin.auth.oauth.enable";
> >  +    public static final String BASIC_AUTHENTICATION =
> > "candlepin.auth.basic.enable";
>  
>   
Why was this change made?  Why change the tense?  What is the context?

Thanks,
Jason

-- 
Jason E. Rist
Senior Software Engineer
Systems Management and Cloud Enablement
Red Hat, Inc.
+1.919.754.4048
Freenode: jrist

[katello-devel] A change in candlepin/config/ConfigProperties.java

[Jesus M. Rodriguez]

The tense was changed to be consistent with other configuration entries in
candlepin.  The inconsistencies were driving me nuts and I preferred enable
vs enabled.

Jesus
On Aug 16, 2011 8:01 AM, "Jason Rist" <jrist(a)redhat.com&gt; wrote:
>  On 08/15/2011 08:17 AM, William Poteat wrote:
> >
> >
> > // Authentication
> >> - public static final String TRUSTED_AUTHENTICATION =
> >> "candlepin.auth.trusted.enabled";
> >> - public static final String SSL_AUTHENTICATION =
> >> "candlepin.auth.ssl.enabled";
> >> - public static final String OAUTH_AUTHENTICATION =
> >> "candlepin.auth.oauth.enabled";
> >> - public static final String BASIC_AUTHENTICATION =
> >> "candlepin.auth.basic.enabled";
> >> + public static final String TRUSTED_AUTHENTICATION =
> >> "candlepin.auth.trusted.enable";
> >> + public static final String SSL_AUTHENTICATION =
> >> "candlepin.auth.ssl.enable";
> >> + public static final String OAUTH_AUTHENTICATION =
> >> "candlepin.auth.oauth.enable";
> >> + public static final String BASIC_AUTHENTICATION =
> >> "candlepin.auth.basic.enable";
> >
> >
>  Why was this change made? Why change the tense? What is the context?
>
>  Thanks,
>  Jason
>
>  --
>  Jason E. Rist
>  Senior Software Engineer
>  Systems Management and Cloud Enablement
>  Red Hat, Inc.
>  +1.919.754.4048
>  Freenode: jrist
>  _______________________________________________
>  candlepin mailing list
>  candlepin(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/candlepin

[jesus rodriguez]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/15/2011 10:17 AM, William Poteat wrote:
>  
>  
>        // Authentication
> >  -    public static final String TRUSTED_AUTHENTICATION =
> "candlepin.auth.trusted.enabled";
> >  -    public static final String SSL_AUTHENTICATION =
> "candlepin.auth.ssl.enabled";
> >  -    public static final String OAUTH_AUTHENTICATION =
> "candlepin.auth.oauth.enabled";
> >  -    public static final String BASIC_AUTHENTICATION =
> "candlepin.auth.basic.enabled";
> >  +    public static final String TRUSTED_AUTHENTICATION =
> "candlepin.auth.trusted.enable";
> >  +    public static final String SSL_AUTHENTICATION =
> "candlepin.auth.ssl.enable";
> >  +    public static final String OAUTH_AUTHENTICATION =
> "candlepin.auth.oauth.enable";
> >  +    public static final String BASIC_AUTHENTICATION =
> "candlepin.auth.basic.enable";
>  
>   
I wrote this bug up when I realized our configs are inconsistent. We have
some that were marked 'enabled' others marked enable. I preferred
'enable'
since by setting these configs it will enable said feature, while 'enabled'
seemed more of a question than a statement to me.

jesus

- -- 
jesus m. rodriguez          | jesusr(a)redhat.com
principal software engineer | irc: zeus
red hat systems management  | 919.754.4413 (w)
rhce # 805008586930012      | 919.623.0080 (c)
+---------------------------------------------+
|   "Those who cannot remember the past       |
|    are condemned to repeat it."             |
|                        -- George Santayana  |
+---------------------------------------------+

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk5JLa8ACgkQvJZ57YntiYOfrwCgj++Rg7HOrcj1XqCrli6wJusZ
> rjQAnir5afg9HV21wgKVtJdojwBthLUl
> =gmZI
> -----END PGP SIGNATURE-----