Re: [cobbler-devel] [PATCH] Fix issue with `cobbler system reboot'
On Fri, Mar 9, 2012 at 7:14 PM, Nishanth Aravamudan
<nacc(a)linux.vnet.ibm.com> wrote:
Commit 659a2e5b tried to fix a stack trace with cobbler system
reboot
without a --name option, but instead completely disabled system reboot.
Rather than actually reboot the system, issuing `cobbler system reboot
--name=...' would result in the corresponding system being saved in the
backend.
Fix this by first obtaining all valid actions up-front. Then, re-order
the action conditionals to check the three that don't require a name
parameter first, followed by any valid action. If it's a valid
name-requiring action without a name option, quit with a warning.
Otherwise, fall down into the appropriate handler block, but actually do
'reboot' in the right place (not as a save operation).
Signed-off-by: Nishanth Aravamudan <nacc(a)us.ibm.com>
It looks like from_iterable() was introduced in python 2.6, which
could cause issues for any distros that still ship 2.4 (old RHEL
only?) I'm not sure if that's a major concern anymore, but as far as I
knew we weren't planning on abandoning support for RHEL4 quite yet.
Also, any chance you could send this as a pull request via github?
Much easier to work with.