proposal: stop using duplicated/bundled libraries

[Cristian Ciupitu]

As some of you might already know, bundling libraries isn't a good
practice for various reasons. You can read more about this subject at
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries.
Unfortunately cobbler comes with its own subprocess and optparse
modules: cobbler/sub_process.py, koan/sub_process.py and
koan/opt_parse.py. As far as I know, this is needed because the Python
from RHEL is old and its stdlib doesn't include them. On the other hand,
the Python from Fedora has them and it would be nice to use these.

What I would like to propose is to try using the system provided
libraries and if they aren't available fall back to the bundled ones.
I'm waiting for your opinions on this.

Thank you,
Cristian Ciupitu

[Cristian Ciupitu]

>  From: Cristian Ciupitu <cristian.ciupitu(a)yahoo.com&gt; What I
> would like
>  to propose is to try using the system provided libraries and if they
>  aren't available fall back to the bundled ones.  I'm waiting for your
>  opinions on this. 
I've started working a bit on this and I've found 2 quick & dirty fixes
for this:
- import only OptionParser from optparse/opt_parse, i.e 
  "from optparse import OptionParser"
- import the modules under an alias, i.e. "import X as Y"
  ("import optparse as opt_parse")

My code is available at git://github.com/ciupicri/cobbler.git branch
master-bugfix530724 (bug from RH BZ).

Regards,
Cristian

[Cristian Ciupitu]

>  From: Cristian Ciupitu <cristian.ciupitu(a)yahoo.com&gt;
>  
>  As some of you might already know, bundling libraries isn't a good
>  practice for various reasons. You can read more about this subject at
>  http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries. 
I've reported 2 bugs on Fedora's bug tracker:
https://bugzilla.redhat.com/show_bug.cgi?id=530726 (cobbler)
https://bugzilla.redhat.com/show_bug.cgi?id=530724 (koan)

I've used this bug tracker, because Fedora has this (strict) policy.

Cheers,
Cristian Ciupitu

[Alex Wood]

> > As some of you might already know, bundling libraries isn't a
> good
> > practice for various reasons. You can read more about this subject at
> > http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries.
>  
>  I've reported 2 bugs on Fedora's bug tracker:
>  https://bugzilla.redhat.com/show_bug.cgi?id=530726 (cobbler)
>  https://bugzilla.redhat.com/show_bug.cgi?id=530724 (koan)
>  
>  I've used this bug tracker, because Fedora has this (strict) policy.
>  
>  Cheers,
>  Cristian Ciupitu 
Cristian,

We also created a Trac bug for this issue at 
https://fedorahosted.org/cobbler/ticket/523

We also decided that we will accept a patch if you care to contribute 
one. =)
---------------
Regards,
Alex

-- 
Senior Software Engineer
Red Hat
919.754.4445

[Cristian Ciupitu]

>  From: Alex Wood <awood(a)redhat.com&gt;
>
>  >> As some of you might already know, bundling libraries isn't a good
>  >> practice for various reasons. You can read more about this subject
>  >> at http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries.
>  >
>  > I've reported 2 bugs on Fedora's bug tracker:
>  > https://bugzilla.redhat.com/show_bug.cgi?id=530726 (cobbler)
>  > https://bugzilla.redhat.com/show_bug.cgi?id=530724 (koan)
>  >
>  > I've used this bug tracker, because Fedora has this (strict) policy.
>  >
>  > Cheers, Cristian Ciupitu
>
>  Cristian,
>
>  We also created a Trac bug for this issue at
>  https://fedorahosted.org/cobbler/ticket/523
>
>  We also decided that we will accept a patch if you care to contribute
>  one. =) 
git://github.com/ciupicri/cobbler.git branches:
- master-bugfix530724
- master-bugfix530726

Be careful that the code hasn't been tested yet, but I'll try to make
some RPMs and test it as soon as possible.

Cheers, 
Cristian

[Cristian Ciupitu]

>  From: Cristian Ciupitu <cristian.ciupitu(a)yahoo.com&gt; 
>  
>  git://github.com/ciupicri/cobbler.git branches:
>  - master-bugfix530724
>  - master-bugfix530726
>  
>  Be careful that the code hasn't been tested yet, but I'll try to make
>  some RPMs and test it as soon as possible. 
I tested it and it worked fine.
I've also made some changes related to packaging: updated setup.py
and stopped bundling these libraries in the RPMs. These are available in
the master-bugfix523-packagingbranch.
 
Cheers, 
Cristian

[Alex Wood]

> > git://github.com/ciupicri/cobbler.git branches:
> > - master-bugfix530724
> > - master-bugfix530726
> >
> > Be careful that the code hasn't been tested yet, but I'll try to make
> > some RPMs and test it as soon as possible.
>  
>  I tested it and it worked fine.
>  I've also made some changes related to packaging: updated setup.py
>  and stopped bundling these libraries in the RPMs. These are available in
>  the master-bugfix523-packagingbranch.
>   
>  Cheers, 
>  Cristian 
Committed d16bd18d59f5e86727b18f6b19a2a51c280ee746

Thanks for your contribution.
-------------
Regards,
Alex

-- 
Senior Software Engineer
Red Hat
919.754.4445

[Cristian Ciupitu]

>  From: Alex Wood <awood(a)redhat.com&gt; 
>  To: cobbler development list
> <cobbler-devel(a)lists.fedorahosted.org&gt;
>  Sent: Fri, November 6, 2009 11:23:16 PM
>  Subject: Re: proposal: stop using duplicated/bundled libraries
>  
>  >> git://github.com/ciupicri/cobbler.git branches:
>  >> - master-bugfix530724
>  >> - master-bugfix530726
>  >>
>  >> Be careful that the code hasn't been tested yet, but I'll try to make
>  >> some RPMs and test it as soon as possible.
>  > 
>  > I tested it and it worked fine.
>  > I've also made some changes related to packaging: updated setup.py
>  > and stopped bundling these libraries in the RPMs. These are available in
>  > the master-bugfix523-packagingbranch.
>  >  
>  > Cheers, 
>  > Cristian
>  
>  Committed d16bd18d59f5e86727b18f6b19a2a51c280ee746 
I've discovered another bundled library, text_wrap (textwrap). It's used
only by opt_parse, so it's practically not used anymore on new systems,
but it's still packaged. Therefore I've updated the master-bugfix523-packaging
branch to exclude this library too.

Cheers,
Cristian