[Epel-packagers-sig] [Bug 2120537] New: 'bodhi updates new' does not report error/warning when setting karma limit below minimal value for package in critical path

https://bugzilla.redhat.com/show_bug.cgi?id=2120537

            Bug ID: 2120537
           Summary: 'bodhi updates new' does not report error/warning when
                    setting karma limit below minimal value for package in
                    critical path
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: bodhi-client
          Assignee: thrcka(a)redhat.com
          Reporter: zdohnal(a)redhat.com
                CC: aurelien(a)bompard.org,
                    epel-packagers-sig(a)lists.fedoraproject.org,
                    lenka(a)sepu.cz, thrcka(a)redhat.com
  Target Milestone: ---
    Classification: Fedora



Hi,

I was surprised why my bodhi update (
https://bodhi.fedoraproject.org/updates/FEDORA-2022-6f5e420e52 ) doesn't show
an option for pushing into stable or why the update is not in stable already,
because the positive karma limit (1) is reached.

On #fedora-devel IRC channel kalev answered:

(09:34:34 AM) zdohnal: Hi all, do you have an idea what blocks this update
https://bodhi.fedoraproject.org/updates/FEDORA-2022-6f5e420e52 from being
pushed to the stable?
(09:38:32 AM) kalev: zdohnal: looks like it's marked as critical path and
because of that, it needs minimum of +2 karma to be pushed to stable
(09:40:19 AM) GrannyGoose left the room (quit: Quit: Going offline, see ya!
(www.adiirc.com)).
(09:41:00 AM) zdohnal: kalev: aha - good to know. However bodhi-client should
give me error when I set karma below this limit...

According to the conversation, there is karma limit for components in critical
path and it is higher - 2 - than the limit set by me - 1, which causes
confusion.

I use 'bodhi updates new' CLI command for creating updates, and I didn't see
any error/warning regarding setting the karma limit too low.

IMHO CLI command has to fail if user tries to set the limit too low, and bodhi
web UI should handle this in some way as well.

Would you mind looking into it?

Version-Release number of selected component (if applicable):
bodhi-client-6.0.1-4.fc37


How reproducible:
always


Steps to Reproduce:
1. $ bodhi updates new --type bugfix --close-bugs --request testing --autokarma
--autotime --stable-karma 1 --unstable-karma -1 --notes "Update for component
in critical path" <critical-component-1.2.3-1.fc37>

Actual results:
No error or warning, bodhi web ui shows user defined limit and the update has
karma to fulfill the limit, but the update is not pushed into stable. 

Expected results:
Give error (in both interfaces - CLI and Web UI) if user wants to set lower
karma limit than it is required on the package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2120537