[freeipa PR#875][opened] Fix ip address checks

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/875
Author: MartinBasti
 Title: #875: Fix ip address checks
Action: opened

PR body:
"""
Fix various checks of IP address in installers, removal of some unneeded checks that are
not working correctly,  and mainly causes only false positive errors.

This PR also fixes regressions caused by bf9886a84393d1d1546db7e49b102e08a16a83e7

https://pagure.io/freeipa/issue/4317
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/875/head:pr875
git checkout pr875

[freeipa PR#875][comment] Fix ip address checks

[dkupka]

  URL: https://github.com/freeipa/freeipa/pull/875
Title: #875: Fix ip address checks

dkupka commented:
"""
Changes look good to me. But it uncovers another unwanted behaviour: With --setup-dns the
installer adds IP and FQDN into /etc/hosts. This results in all traffic from local system
towards it's FQDN being routed over the external IP.
I believe this is not a good idea but don't have strong opinion about fixing it in
this PR or separate one. It's time to stop touching /etc/hosts.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/875#issuecomment-309665085

[freeipa PR#875][comment] Fix ip address checks

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/875
Title: #875: Fix ip address checks

MartinBasti commented:
"""
@dkupka it is not aim of this PR to fix what you mentioned.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/875#issuecomment-309666594

[freeipa PR#875][comment] Fix ip address checks

[dkupka]

  URL: https://github.com/freeipa/freeipa/pull/875
Title: #875: Fix ip address checks

dkupka commented:
"""
@MartinBasti You're right.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/875#issuecomment-309688040

[freeipa PR#875][+ack] Fix ip address checks

[dkupka]

  URL: https://github.com/freeipa/freeipa/pull/875
Title: #875: Fix ip address checks

Label: +ack

[freeipa PR#875][+pushed] Fix ip address checks

[dkupka]

  URL: https://github.com/freeipa/freeipa/pull/875
Title: #875: Fix ip address checks

Label: +pushed

[freeipa PR#875][comment] Fix ip address checks

[dkupka]

  URL: https://github.com/freeipa/freeipa/pull/875
Title: #875: Fix ip address checks

dkupka commented:
"""
master:

* 82ad586f6cbf6e707add3c866ed4e37ade69b045 Fix local IP address validation
* cb48a49c80f4a11d2d16511e0f1366867320f153 ipa-dns-install: remove check for local ip
address
* 0b69e44f16fbba6ab7ddef5a3e55bdabcfd6a8a6 refactor CheckedIPAddress class
* 6024165101677c844dc3bbb337e290df2e66eaf1 CheckedIPAddress: remove match_local param
* f9cba7d161f788c32336b66ff7c641f4a1ed2754 Remove ip_netmask from option parser
* 1b8dc1131c9ca7218efb8fe16dcce97f9f960be9 replica install: add missing check for
non-local IP address
* f3537297bee2890c6b839750bb7a0a2cf904cdf9 Remove network and broadcast address warnings
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/875#issuecomment-309698183

[freeipa PR#875][closed] Fix ip address checks

[dkupka]

   URL: https://github.com/freeipa/freeipa/pull/875
Author: MartinBasti
 Title: #875: Fix ip address checks
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/875/head:pr875
git checkout pr875

[freeipa PR#875][-pushed] Fix ip address checks

[dkupka]

  URL: https://github.com/freeipa/freeipa/pull/875
Title: #875: Fix ip address checks

Label: -pushed

[freeipa PR#875][+pushed] Fix ip address checks

[dkupka]

  URL: https://github.com/freeipa/freeipa/pull/875
Title: #875: Fix ip address checks

Label: +pushed

[freeipa PR#875][comment] Fix ip address checks

[dkupka]

  URL: https://github.com/freeipa/freeipa/pull/875
Title: #875: Fix ip address checks

dkupka commented:
"""
@MartinBasti please rebase for ipa-4-5
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/875#issuecomment-309698530

[freeipa PR#875][comment] Fix ip address checks

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/875
Title: #875: Fix ip address checks

MartinBasti commented:
"""
Rebased in #881 
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/875#issuecomment-309712146