[freeipa PR#821][opened] fix incorrect suffix handling in topology checks

[martbab]

URL: https://github.com/freeipa/freeipa/pull/821
Author: martbab
 Title: #821: fix incorrect suffix handling in topology checks
Action: opened

PR body:
"""
When trying to delete a partially removed master entry lacking
'iparepltopomanagedsuffix' attribute, the code that tries to retrieve
tha value for further computations passes None and causes unhandled
internal errors.

If the attribute is empty or not present, we should return empty list
instead as to not break calling cod attribute, the code that tries to
retrieve tha value for further computations passes None and causes
unhandled internal errors. We should return empty list instead.

https://pagure.io/freeipa/issue/6965
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/821/head:pr821
git checkout pr821

[freeipa PR#821][comment] fix incorrect suffix handling in topology checks

[pvoborni]

URL: https://github.com/freeipa/freeipa/pull/821
Title: #821: fix incorrect suffix handling in topology checks

pvoborni commented:
"""
can this happen?
```
> > > d = {'a': None}
> > > r = d.get('a', [])
> > > print r

None
```

And thus fail with the same error?
"""

See the full comment at https://github.com/freeipa/freeipa/pull/821#issuecomment-304270681

[freeipa PR#821][comment] fix incorrect suffix handling in topology checks

[martbab]

URL: https://github.com/freeipa/freeipa/pull/821
Title: #821: fix incorrect suffix handling in topology checks

martbab commented:
"""
@pvoborni it shouldn't but given how our framework sometimes (mis)-behaves the possibility is there.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/821#issuecomment-304643335

[freeipa PR#821][synchronized] fix incorrect suffix handling in topology checks

[martbab]

URL: https://github.com/freeipa/freeipa/pull/821
Author: martbab
 Title: #821: fix incorrect suffix handling in topology checks
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/821/head:pr821
git checkout pr821

[freeipa PR#821][comment] fix incorrect suffix handling in topology checks

[felipevolpone]

URL: https://github.com/freeipa/freeipa/pull/821
Title: #821: fix incorrect suffix handling in topology checks

felipevolpone commented:
"""
Tested, works as advertised.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/821#issuecomment-305861037

[freeipa PR#821][+ack] fix incorrect suffix handling in topology checks

[felipevolpone]

URL: https://github.com/freeipa/freeipa/pull/821
Title: #821: fix incorrect suffix handling in topology checks

Label: +ack

[freeipa PR#821][+pushed] fix incorrect suffix handling in topology checks

[martbab]

URL: https://github.com/freeipa/freeipa/pull/821
Title: #821: fix incorrect suffix handling in topology checks

Label: +pushed

[freeipa PR#821][comment] fix incorrect suffix handling in topology checks

[martbab]

URL: https://github.com/freeipa/freeipa/pull/821
Title: #821: fix incorrect suffix handling in topology checks

martbab commented:
"""
ipa-4-5:

* d651a9877d0e2f9dd1b057630508b488678bb86e fix incorrect suffix handling in topology checks

master:

* 8ef4888af77f8e6fd8324297d26287b575b18163 fix incorrect suffix handling in topology checks

"""

See the full comment at https://github.com/freeipa/freeipa/pull/821#issuecomment-306237609

[freeipa PR#821][closed] fix incorrect suffix handling in topology checks

[martbab]

URL: https://github.com/freeipa/freeipa/pull/821
Author: martbab
 Title: #821: fix incorrect suffix handling in topology checks
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/821/head:pr821
git checkout pr821