[freeipa PR#792][opened] named.conf template: add modification warning

[tomaskrizek]

   URL: https://github.com/freeipa/freeipa/pull/792
Author: tomaskrizek
 Title: #792: named.conf template: add modification warning
Action: opened

PR body:
"""
Based on our discussion with Brian Atkinsson, I think we should add some warning about
making undocumented changes to the config files.

---

Warn the user some modifications may break IPA setup or upgrade.
All changes the user makes should be explicitly supported and mentioned
in the documentation. Undocumented and unsupported changes, such as
renaming dyndb part from "ipa" will break IPA.

Signed-off-by: Tomas Krizek <tkrizek(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/792/head:pr792
git checkout pr792

[freeipa PR#792][comment] named.conf template: add modification warning

[stlaz]

  URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

stlaz commented:
"""
Aside from the tests failing because DNS fails to start with your patch, I don't think
you can claim this easily without listing the supported modifications.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/792#issuecomment-302045267

[freeipa PR#792][synchronized] named.conf template: add modification warning

[tomaskrizek]

   URL: https://github.com/freeipa/freeipa/pull/792
Author: tomaskrizek
 Title: #792: named.conf template: add modification warning
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/792/head:pr792
git checkout pr792

[freeipa PR#792][comment] named.conf template: add modification warning

[tomaskrizek]

  URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

tomaskrizek commented:
"""
- fixed the broken comment
- mentioned any changes should be documented in FreeIPA or Red Hat IdM documentation

I don't think going into more detail is necessary.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/792#issuecomment-303156828

[freeipa PR#792][comment] named.conf template: add modification warning

[stlaz]

  URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

stlaz commented:
"""
The IdM documentation does not list allowed operations on the file, only a note of what
the file is most commonly used for.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/792#issuecomment-303305555

[freeipa PR#792][synchronized] named.conf template: add modification warning

[tomaskrizek]

   URL: https://github.com/freeipa/freeipa/pull/792
Author: tomaskrizek
 Title: #792: named.conf template: add modification warning
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/792/head:pr792
git checkout pr792

[freeipa PR#792][comment] named.conf template: add modification warning

[tomaskrizek]

  URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

tomaskrizek commented:
"""
Fair enough, let's go with a simple warning that changes may break IPA
setup/upgrades.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/792#issuecomment-303316574

[freeipa PR#792][+ack] named.conf template: add modification warning

[stlaz]

  URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

Label: +ack

[freeipa PR#792][+pushed] named.conf template: add modification warning

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

Label: +pushed

[freeipa PR#792][comment] named.conf template: add modification warning

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/792
Title: #792: named.conf template: add modification warning

MartinBasti commented:
"""
master:

* a924efe847e725d6a4dde209f57521a9a899ef23 named.conf template: add modification warning


"""

See the full comment at
https://github.com/freeipa/freeipa/pull/792#issuecomment-303359641

[freeipa PR#792][closed] named.conf template: add modification warning

[MartinBasti]

   URL: https://github.com/freeipa/freeipa/pull/792
Author: tomaskrizek
 Title: #792: named.conf template: add modification warning
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/792/head:pr792
git checkout pr792