[freeipa PR#840][opened] Add Role 'Client Administrator'

[Tiboris]

   URL: https://github.com/freeipa/freeipa/pull/840
Author: Tiboris
 Title: #840: Add Role 'Client Administrator'
Action: opened

PR body:
"""
User with the 'Client Administrator' role assigned to is
able to enroll host against a FreeIPA server as a client
using the ipa-client-install command.

The 'Client Administrator' contains 'Host Enrollment' privilege only.

Points to: https://pagure.io/freeipa/issue/6852
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/840/head:pr840
git checkout pr840

[freeipa PR#840][comment] Add Role 'Client Administrator'

[MartinBasti]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Client Administrator'

MartinBasti commented:
"""
Off Topic: Shouldn't have "IT specialists" also 'Host Enrollment'
privilege, because they have 'Host administrators' already and this should close
the circle.

"Client administrator" sounds to me like too much as the role can only enroll
client.  How about "Enrolling Administrator"/"Client Enrolling
Administrator". But I'm not sure.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/840#issuecomment-307098685

[freeipa PR#840][comment] Add Role 'Client Administrator'

[abbra]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Client Administrator'

abbra commented:
"""
I think "Enrollment Administrator" would be fine. On the "IT
Specialists" and "Host Enrollment" -- why not, it seems logical.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/840#issuecomment-307105859

[freeipa PR#840][edited] Add Role 'Enrollment Administrator'

[Tiboris]

   URL: https://github.com/freeipa/freeipa/pull/840
Author: Tiboris
 Title: #840: Add Role 'Enrollment Administrator'
Action: edited

 Changed field: title
Original value:
"""
Add Role 'Client Administrator'
"""

[freeipa PR#840][synchronized] Add Role 'Enrollment Administrator'

[Tiboris]

   URL: https://github.com/freeipa/freeipa/pull/840
Author: Tiboris
 Title: #840: Add Role 'Enrollment Administrator'
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/840/head:pr840
git checkout pr840

[freeipa PR#840][edited] Add Role 'Enrollment Administrator'

[Tiboris]

   URL: https://github.com/freeipa/freeipa/pull/840
Author: Tiboris
 Title: #840: Add Role 'Enrollment Administrator'
Action: edited

 Changed field: body
Original value:
"""
User with the 'Client Administrator' role assigned to is
able to enroll host against a FreeIPA server as a client
using the ipa-client-install command.

The 'Client Administrator' contains 'Host Enrollment' privilege only.

Points to: https://pagure.io/freeipa/issue/6852
"""

[freeipa PR#840][comment] Add Role 'Enrollment Administrator'

[Tiboris]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Enrollment Administrator'

Tiboris commented:
"""
Thanks, changed.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/840#issuecomment-307324655

[freeipa PR#840][comment] Add Role 'Enrollment Administrator'

[abbra]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Enrollment Administrator'

abbra commented:
"""
LGTM.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/840#issuecomment-307343158

[freeipa PR#840][comment] Add Role 'Enrollment Administrator'

[abbra]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Enrollment Administrator'

abbra commented:
"""
The patch works but we also agreed to add 'Host Enrollment' privilege to 'IT
Specialists'. Please add this as a separate commit mentioning the same ticket.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/840#issuecomment-307356354

[freeipa PR#840][comment] Add Role 'Enrollment Administrator'

[Tiboris]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Enrollment Administrator'

Tiboris commented:
"""
On it.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/840#issuecomment-307358845

[freeipa PR#840][comment] Add Role 'Enrollment Administrator'

[Tiboris]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Enrollment Administrator'

Tiboris commented:
"""
I think adding 'Host Enrollment' privilege to 'IT Specialists' is not
necessary because the  'IT Specialists' role has already a 'Host
Administrators' privilege assigned an this privilege contain all of the 'Host
Enrollment' privilege permissions.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/840#issuecomment-307360260

[freeipa PR#840][comment] Add Role 'Enrollment Administrator'

[Tiboris]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Enrollment Administrator'

Tiboris commented:
"""
I think adding 'Host Enrollment' privilege to 'IT Specialists' is not
necessary because the  'IT Specialists' role has already a 'Host
Administrators' privilege assigned an this privilege contain all of the 'Host
Enrollment' privilege permissions.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/840#issuecomment-307360260

[freeipa PR#840][comment] Add Role 'Enrollment Administrator'

[abbra]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Enrollment Administrator'

abbra commented:
"""
Got it. Thanks.
"""

See the full comment at
https://github.com/freeipa/freeipa/pull/840#issuecomment-307369453

[freeipa PR#840][+ack] Add Role 'Enrollment Administrator'

[abbra]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Enrollment Administrator'

Label: +ack

[freeipa PR#840][+pushed] Add Role 'Enrollment Administrator'

[martbab]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Enrollment Administrator'

Label: +pushed

[freeipa PR#840][comment] Add Role 'Enrollment Administrator'

[martbab]

  URL: https://github.com/freeipa/freeipa/pull/840
Title: #840: Add Role 'Enrollment Administrator'

martbab commented:
"""
master:

* 468eb3c712140399ed2ec346ff4356bffd590e09 Add Role 'Enrollment Administrator'


"""

See the full comment at
https://github.com/freeipa/freeipa/pull/840#issuecomment-307407213

[freeipa PR#840][closed] Add Role 'Enrollment Administrator'

[martbab]

   URL: https://github.com/freeipa/freeipa/pull/840
Author: Tiboris
 Title: #840: Add Role 'Enrollment Administrator'
Action: closed

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/840/head:pr840
git checkout pr840