2:43 a.m.
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: baseldap.py: Removes dnss-server configuration from ldap
Action: opened
PR body:
"""
After invocation of the ipa server-del <hostname>
command there was still record in ldap if DNS
was installed on the <hostname> server.
Fixes: https://pagure.io/freeipa/issue/6572
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/857/head:pr857
git checkout pr857
3:28 a.m.
New subject: [freeipa PR#857][synchronized] baseldap.py: Removes dnss-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: baseldap.py: Removes dnss-server configuration from ldap
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/857/head:pr857
git checkout pr857
3:28 a.m.
New subject: [freeipa PR#857][edited] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: baseldap.py: Removes dns-server configuration from ldap
Action: edited
Changed field: title
Original value:
"""
baseldap.py: Removes dnss-server configuration from ldap
"""
3:29 a.m.
New subject: [freeipa PR#857][edited] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: baseldap.py: Removes dns-server configuration from ldap
Action: edited
Changed field: body
Original value:
"""
After invocation of the ipa server-del <hostname>
command there was still record in ldap if DNS
was installed on the <hostname> server.
Fixes: https://pagure.io/freeipa/issue/6572
"""
3:29 a.m.
New subject: [freeipa PR#857][comment] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Title: #857: baseldap.py: Removes dns-server configuration from ldap
MartinBasti commented:
"""
NACK
Please create a new method `_cleanup_server_dns_config` because this patch unrelated to
DNS records but it is for DNS configuration per server.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/857#issuecomment-306727089
3:30 a.m.
New subject: [freeipa PR#857][edited] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: baseldap.py: Removes dns-server configuration from ldap
Action: edited
Changed field: body
Original value:
"""
After invocation of the ipa server-del `<hostname>`
command there was still record in ldap if DNS
was installed on the `<hostname>` server.
Fixes: https://pagure.io/freeipa/issue/6572
"""
3:37 a.m.
New subject: [freeipa PR#857][synchronized] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: baseldap.py: Removes dns-server configuration from ldap
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/857/head:pr857
git checkout pr857
3:52 a.m.
New subject: [freeipa PR#857][synchronized] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: baseldap.py: Removes dns-server configuration from ldap
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/857/head:pr857
git checkout pr857
5:21 a.m.
New subject: [freeipa PR#857][synchronized] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: baseldap.py: Removes dns-server configuration from ldap
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/857/head:pr857
git checkout pr857
1:06 p.m.
New subject: [freeipa PR#857][+ack] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Title: #857: baseldap.py: Removes dns-server configuration from ldap
Label: +ack
1:58 a.m.
New subject: [freeipa PR#857][comment] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Title: #857: baseldap.py: Removes dns-server configuration from ldap
MartinBasti commented:
"""
Actually NACK until you fix commit message, this is not related to baseldap.py
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/857#issuecomment-307016671
2:10 a.m.
New subject: [freeipa PR#857][synchronized] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: baseldap.py: Removes dns-server configuration from ldap
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/857/head:pr857
git checkout pr857
2:11 a.m.
New subject: [freeipa PR#857][comment] baseldap.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Title: #857: baseldap.py: Removes dns-server configuration from ldap
Tiboris commented:
"""
It should be better now.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/857#issuecomment-307019167
2:13 a.m.
New subject: [freeipa PR#857][edited] server.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: server.py: Removes dns-server configuration from ldap
Action: edited
Changed field: title
Original value:
"""
baseldap.py: Removes dns-server configuration from ldap
"""
10:02 a.m.
New subject: [freeipa PR#857][comment] server.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Title: #857: server.py: Removes dns-server configuration from ldap
MartinBasti commented:
"""
master:
* 063211d665d02fc343952f5b158fd8d89223fbc9 server.py: Removes dns-server configuration
from ldap
ipa-4-5:
* 005c92868ce36770ce89e87ef3cdeae62d11ece4 server.py: Removes dns-server configuration
from ldap
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/857#issuecomment-307131102
10:02 a.m.
New subject: [freeipa PR#857][closed] server.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Author: Tiboris
Title: #857: server.py: Removes dns-server configuration from ldap
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/857/head:pr857
git checkout pr857
10:02 a.m.
New subject: [freeipa PR#857][+pushed] server.py: Removes dns-server configuration from ldap
URL: https://github.com/freeipa/freeipa/pull/857
Title: #857: server.py: Removes dns-server configuration from ldap
Label: +pushed
2526
days inactive
2527
days old
freeipa-devel@lists.fedorahosted.org
16 comments
2 participants
participants (2)
-
MartinBasti -
Tiboris