[Bug 1138384] New: fix 'quickCheckAll' to read haskell sources in UTF-8

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1138384

Bug ID: 1138384
           Summary: fix 'quickCheckAll' to read haskell sources in UTF-8
           Product: Fedora
           Version: rawhide
         Component: ghc-QuickCheck
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail]

Description of problem:

Locale-dependent instead of UTF-8 file manipulation.

Version-Release number of selected component (if applicable):

ghc-QuickCheck-devel-2.6-34.fc22

How reproducible:

Always: http://koji.fedoraproject.org/koji/taskinfo?taskID=7524823

Steps to Reproduce:

Build ShellCheck 0.3.4 :)

Actual results:

ShellCheck/Parser.hs:2098:12:
    Exception when trying to run compile-time code:
      ./ShellCheck/Parser.hs: hGetContents: invalid argument (invalid byte
sequence)
      Code: quickCheckAll
    In the expression: $quickCheckAll
    In an equation for `runTests': runTests = $quickCheckAll

Expected results:

A build!

Additional info:

Fixed in QuickCheck 2.7.4
https://github.com/nick8325/quickcheck/commit/ccf15ee
https://github.com/nick8325/quickcheck/commit/ccf15ee.diff

[Bug 1138384] fix 'quickCheckAll' to read haskell sources in UTF-8

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1138384

Dridi Boukelmoune  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1136297

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1136297
[Bug 1136297] ShellCheck-0.3.4 is available

[Bug 1138384] fix 'quickCheckAll' to read haskell sources in UTF-8

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1138384

Dridi Boukelmoune  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1052117

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1052117
[Bug 1052117] ShellCheck source dir is named shellcheck-version/ not
ShellCheck-version/

[Bug 1138384] fix 'quickCheckAll' to read haskell sources in UTF-8

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1138384

--- Comment #1 from Jens Petersen  ---
I really blame rpmbuild for still using LANG=C by default... :)

Anyway as I commented in bug 1136297 you can workaround this
by setting LANG=en_US.utf8 before %cabal_lib_build. Like this:

%build
LANG=en_US.utf8
%ghc_lib_build

[Bug 1138384] fix 'quickCheckAll' to read haskell sources in UTF-8

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1138384

--- Comment #2 from Jens Petersen  ---
I hope this is not the reason that upstream is now requiring 2.7.4...

[Bug 1138384] fix 'quickCheckAll' to read haskell sources in UTF-8

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1138384

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from Jens Petersen  ---
If I apply this it may change the ABI of the QuickCheck and so require
quite a number of packages to be rebuilt.  Perhaps we could consider
it for rawhide, but it also means diverging from the upsteam behaviour/
library so I am a little hesitant.  If you can live with the above workaround
then I may well be tempted to just close this as Upstream or CANTFIX.

[Bug 1138384] fix 'quickCheckAll' to read haskell sources in UTF-8

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1138384

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1052117                     |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1052117
[Bug 1052117] ShellCheck source dir is named shellcheck-version/ not
ShellCheck-version/

[Bug 1138384] fix 'quickCheckAll' to read haskell sources in UTF-8

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1138384

--- Comment #4 from Jens Petersen  ---
As far as I can tell now it is better to patch out the QC code from
the ShellCheck library since it is only needed for tests.

So hopefully this need not block future ShellCheck versions.

Haskell Platform for ghc-7.8.3 is still on 2.6 anyway.

[Bug 1138384] fix 'quickCheckAll' to read haskell sources in UTF-8

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1138384

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 1138384] fix 'quickCheckAll' to read haskell sources in UTF-8

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1138384

Fedora End Of Life  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |EOL
        Last Closed|                            |2016-07-19 08:06:02

--- Comment #6 from Fedora End Of Life  ---
Fedora 22 changed to end-of-life (EOL) status on 2016-07-19. Fedora 22 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.