[Bug 1507505] New: ShelLCheck 0.4.5 does not honor file scope " shellcheck disable=SC2181"

https://bugzilla.redhat.com/show_bug.cgi?id=1507505

Bug ID: 1507505
           Summary: ShelLCheck 0.4.5 does not honor file scope "shellcheck
                    disable=SC2181"
           Product: Fedora
           Version: 26
         Component: ShellCheck
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail],
                    [e-mail]

I'm working on Fedora 26 x86_64 (fully patched). I have ShellCheck 0.4.5
installed from the Fedora repos.

Checking a shell script with SC2181 disabled still produces SC2181 warnings:

git clone https://github.com/weidai11/cryptopp.git
  shellcheck cryptest.sh | grep -i -c SC2181
  68

To disable the warning, the following was added after the shebang and before
any commands:

# Keep the noise down
  # shellcheck disable=SC2181

The same exercise on Ubuntu 17 with ShellCheck 0.4.4 does not witness the
problem. Others on Stack Overflow cannot reproduce the problem either. Also see
https://stackoverflow.com/q/47014776/608639 .

**********

$ yum info shellcheck
Installed Packages
Name         : ShellCheck
Version      : 0.4.5
Release      : 3.fc26
Arch         : x86_64
Size         : 6.0 M
Source       : ShellCheck-0.4.5-3.fc26.src.rpm
Repo         : @System
From repo    : fedora
Summary      : Shell script analysis tool
URL          : https://github.com/koalaman/shellcheck
License      : GPLv3+
Description  : The goals of ShellCheck are:
             :
             : * To point out and clarify typical beginner's syntax issues,
             :   that causes a shell to give cryptic error messages.
             :
             : * To point out and clarify typical intermediate level semantic
             :   problems, that causes a shell to behave strangely and
             :   counter-intuitively.
             :
             : * To point out subtle caveats, corner cases and pitfalls, that
             :   may cause an advanced user's otherwise working script to fail
             :   under future circumstances.

[Bug 1507505] ShelLCheck 0.4.5 does not honor file scope " shellcheck disable=SC2181"

https://bugzilla.redhat.com/show_bug.cgi?id=1507505

Jeffrey Walton  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 1507505] ShelLCheck 0.4.5 does not honor file scope " shellcheck disable=SC2181"

https://bugzilla.redhat.com/show_bug.cgi?id=1507505

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #1 from Jens Petersen  ---
I tested and can't reproduce on my F26 machine.

Could you attach your diff for cryptest.sh?

[cryptopp:master]$ git diff -U1
diff --git a/cryptest.sh b/cryptest.sh
index cc4a737..6ed7b4f 100755
--- a/cryptest.sh
+++ b/cryptest.sh
@@ -1,3 +1,3 @@
 #!/usr/bin/env bash
-
+# shellcheck disable=SC2181
 # cryptest.sh - written and placed in public domain by Jeffrey Walton and Uri
Blumenthal.
[cryptopp:master]$ shellcheck cryptest.sh | grep -i -c SC2181
0

[Bug 1507505] ShelLCheck 0.4.5 does not honor file scope " shellcheck disable=SC2181"

https://bugzilla.redhat.com/show_bug.cgi?id=1507505

Jeffrey Walton  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #2 from Jeffrey Walton  ---
(In reply to Jens Petersen from comment #1)
> I tested and can't reproduce on my F26 machine.
>
> Could you attach your diff for cryptest.sh?
>
> [cryptopp:master]$ git diff -U1
> diff --git a/cryptest.sh b/cryptest.sh
> index cc4a737..6ed7b4f 100755
> --- a/cryptest.sh
> +++ b/cryptest.sh
> @@ -1,3 +1,3 @@
>  #!/usr/bin/env bash
>
> +# shellcheck disable=SC2181
>  # cryptest.sh - written and placed in public domain by Jeffrey Walton and
> Uri Blumenthal.
> [cryptopp:master]$ shellcheck cryptest.sh | grep -i -c SC2181
> 0

Thanks Jens.

I think this has something to do with libraries installed in /usr/local/lib64.
I often build typical libraries with different settings and insatlly them in
/usr/local. The libraries include GetText, Readline, OCRE, etc. The problem is,
I can't tell the Linux loader that programs in /bin and /usr/bin (like
shellcheck) should _not_ to use the new libraries (in /usr/local). The runtime
link loader is just too braindead to understand the simple policy.

I suggest you close this report as "can't duplicate".

[Bug 1507505] ShelLCheck 0.4.5 does not honor file scope " shellcheck disable=SC2181"

https://bugzilla.redhat.com/show_bug.cgi?id=1507505

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |WORKSFORME
        Last Closed|                            |2017-11-14 05:58:06

--- Comment #3 from Jens Petersen  ---
Okay thanks