[Fedora-haskell-list] [Bug 746557] New: Review Request: ghc-tagged - Newtype wrappers for phantom types - haskell-devel

List overview All Threads
Download

newer

[Fedora-haskell-list] [Bug 746557] New: Review Request: ghc-tagged - Newtype wrappers for phantom types

older

[Bug 909150] New:...

[Bug 910639] Review Request:...

Red Hat Bugzilla

17 Oct 2011 17 Oct '11

5:50 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: ghc-tagged - Newtype wrappers for phantom types

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Summary: Review Request: ghc-tagged - Newtype wrappers for phantom types Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Status Whiteboard: Ready Severity: unspecified Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lakshminaras2002@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-haskell-list@redhat.com, package-review@lists.fedoraproject.org Depends on: 648246,737228,742882 Blocks: 648248,713359 Classification: Fedora Story Points: --- Type: ---

Spec file: http://narasim.fedorapeople.org/package_reviews/ghc-tagged.spec

SRPM http://narasim.fedorapeople.org/package_reviews/ghc-tagged-0.2.3.1-1.fc14.sr...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

17 Oct 17 Oct

5:51 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Lakshmi Narasimhan lakshminaras2002@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mathstuf@gmail.com

--- Comment #1 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-10-17 00:51:41 EDT --- *** Bug 648247 has been marked as a duplicate of this bug. ***

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:32 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Jens Petersen petersen@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |ghc-tagged

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

20 Oct 20 Oct

7:28 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Jens Petersen petersen@redhat.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

27 Oct 27 Oct

5:05 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Jens Petersen petersen@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #2 from Jens Petersen petersen@redhat.com 2011-10-27 00:05:29 EDT --- Thanks for the submission - looks fine to me.

Here is the review:

+:ok, NA: not applicable

MUST Items: [+] MUST: rpmlint output [1]

ghc-tagged.src: W: spelling-error Summary(en_US) Newtype -> New type, New-type, Tintype ghc-tagged.src: W: spelling-error %description -l en_US Newtype -> New type, New-type, Tintype 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ghc-tagged.x86_64: W: spelling-error Summary(en_US) Newtype -> New type, New-type, Tintype ghc-tagged.x86_64: W: spelling-error %description -l en_US Newtype -> New type, New-type, Tintype 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ghc-tagged-devel.x86_64: W: spelling-error %description -l en_US Newtype -> New type, New-type, Tintype 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[+] MUST: package named according to Package Naming Guidelines [+] MUST: spec file name must match base package %{name} [2] [+] MUST: meet Packaging Guidelines [+] MUST: Fedora approved license and Licensing Guidelines BSD 3 clause [+] MUST: License field in the package spec file must match actual license. [3] [+] MUST: include license files in %doc if available in source [4] [+] MUST: The spec file must be written in American English [5] and legible. [6] [+] MUST: source md5sum matches upstream release (from upstream URL)

7899d417f18952a5a56b8588ba4724e4 tagged-0.2.3.1.tar.gz

[+] MUST: successfully compile and build into binary rpms on a primary arch [7]

http://koji.fedoraproject.org/koji/taskinfo?taskID=3465018

[NA] MUST: if necessary use ExcludeArch for other archs [8] [+] MUST: All build dependencies must be listed in BuildRequires [NA] MUST: use %find_lang macro for .po translations [9] [NA] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] [+] MUST: Packages must NOT bundle copies of system libraries. [11] [NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [12] [+] MUST: A package must own all directories that it creates. [13] [+] MUST: A package must not contain any duplicate files in the %files listing. [14] [+] MUST: Permissions on files must be set properly. [15] [+] MUST: consistently use macros [16] [+] MUST: The package must contain code, or permissable content. [17] [NA] MUST: Large documentation files should go in a doc subpackage. [18] [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [18] [+] MUST: Header files must be in a -devel package. [19] [NA] MUST: Static libraries must be in a -static package. [20] [NA] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19] [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency [21] [NA] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [20] [NA] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [22] [+] MUST: Packages must not own files or directories already owned by other packages. [23] [+] MUST: All filenames in rpm packages must be valid UTF-8. [24]

SHOULD Items: [+] SHOULD: If upstream source does not include license text file(s), the packager SHOULD query upstream to include it. [25] [+] SHOULD: The reviewer should test that the package builds in mock. [27] [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [29] [+] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [21]

The source files also include headers tagged with the license. :)

Package is APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:05 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Jens Petersen petersen@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|Ready |

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:23 p.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Lakshmi Narasimhan lakshminaras2002@gmail.com changed:

--- Comment #3 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-10-27 13:23:04 EDT --- New Package SCM Request ======================= Package Name: ghc-tagged Short Description: Newtype wrappers for phantom types Owners: narasim Branches: f14 f15 f16 InitialCC: haskell-sig

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:23 p.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

--- Comment #4 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-10-27 13:23:37 EDT --- Thanks for the review!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

28 Oct 28 Oct

3:07 p.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Lakshmi Narasimhan lakshminaras2002@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:13 p.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

--- Comment #5 from Jon Ciesla limb@jcomserv.net 2011-10-28 10:13:40 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:28 p.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

--- Comment #6 from Lakshmi Narasimhan lakshminaras2002@gmail.com 2011-10-28 11:28:13 EDT --- Built for rawhide

http://koji.fedoraproject.org/koji/buildinfo?buildID=271224

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4 Nov 4 Nov

3:44 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

Bug 746557 depends on bug 742882, which changed state.

Bug 742882 Summary: Review Request: ghc-semigroups - Provides Haskell 98 semigroups https://bugzilla.redhat.com/show_bug.cgi?id=742882

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:44 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-11-03 23:44:44 EDT --- ghc-tagged-0.2.3.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-tagged-0.2.3.1-1.fc14

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:44 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-11-03 23:44:51 EDT --- ghc-tagged-0.2.3.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-tagged-0.2.3.1-1.fc15

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5 Nov 5 Nov

11:57 p.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-11-05 19:57:29 EDT --- ghc-tagged-0.2.3.1-1.fc14 has been pushed to the Fedora 14 testing repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6 Nov 6 Nov

10:07 p.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-11-06 17:07:32 EST --- ghc-tagged-0.2.3.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-tagged-0.2.3.1-1.fc16

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

23 Nov 23 Nov

12:52 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Fedora Update System updates@fedoraproject.org changed:

--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-11-22 19:52:41 EST --- ghc-tagged-0.2.3.1-1.fc14 has been pushed to the Fedora 14 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:55 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|ghc-tagged-0.2.3.1-1.fc14 |ghc-tagged-0.2.3.1-1.fc15

--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-11-22 19:55:14 EST --- ghc-tagged-0.2.3.1-1.fc15 has been pushed to the Fedora 15 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1 a.m.

New subject: [Fedora-haskell-list] [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|ghc-tagged-0.2.3.1-1.fc15 |ghc-tagged-0.2.3.1-1.fc16

--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-11-22 20:00:48 EST --- ghc-tagged-0.2.3.1-1.fc16 has been pushed to the Fedora 16 stable repository.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7 Jul 7 Jul

12:17 p.m.

New subject: [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Jens Petersen petersen@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?

--- Comment #14 from Jens Petersen petersen@redhat.com --- Package Change Request ====================== Package Name: ghc-tagged New Branches: el6 Owners: petersen InitialCC: haskell-sig

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1EhlRqWsVp&a=cc_unsubscribe

Red Hat Bugzilla

8:12 p.m.

New subject: [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

https://bugzilla.redhat.com/show_bug.cgi?id=746557

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IAhVvd8TCf&a=cc_unsubscribe

Red Hat Bugzilla

8:12 p.m.

New subject: [Bug 746557] Review Request: ghc-tagged - Newtype wrappers for phantom types

https://bugzilla.redhat.com/show_bug.cgi?id=746557

--- Comment #15 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=29H763ZfaG&a=cc_unsubscribe

4110

Age (days ago)

4739

Last active (days ago)

haskell-devel@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla