[Fedora-i18n-bugs] [Bug 983340] Review Request: fcitx-kkc - Japanese Kana Kanji Engine for Fcitx

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=983340

Parag AN(पराग) <panemade(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade(a)gmail.com
           Assignee|nobody(a)fedoraproject.org    |panemade(a)gmail.com
              Flags|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com&gt; ---
Review:

+ mock build is successful for f20

- rpmlint output on rpms gave
fcitx-kkc.src: W: spelling-error %description -l en_US libkkc -> lick
fcitx-kkc.x86_64: W: spelling-error %description -l en_US libkkc -> lick
fcitx-kkc.x86_64: W: no-documentation
fcitx-kkc.x86_64: W: devel-file-in-non-devel-package
/usr/include/fcitx/module/kkc/fcitx-kkc.h
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
==> you may want to remove header file

+ Source verified with upstream as (sha256sum)
srpm tarball     :
c364c991b09c88f0dc7475497ab37df7919a495f77b48bc88a094e9a43630c9b
upstream tarball :
c364c991b09c88f0dc7475497ab37df7919a495f77b48bc88a094e9a43630c9b

- License should be GPLv3+

- Directory ownership issues
/usr/share/fcitx/imicon
/usr/share/fcitx/inputmethod

I can't find who owns these. 

suggestions:
1) we don't need now
rm -rf $RPM_BUILD_ROOT

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=HsgcLzTi90&a=cc_unsubscribe