[Fedora-i18n-bugs] [Bug 1567689] New: Please split out the emoji chooser

https://bugzilla.redhat.com/show_bug.cgi?id=1567689

            Bug ID: 1567689
           Summary: Please split out the emoji chooser
           Product: Fedora
           Version: 28
         Component: ibus
          Assignee: tfujiwar(a)redhat.com
          Reporter: bochecha(a)daitauha.fr
        QA Contact: extras-qa(a)fedoraproject.org
                CC: i18n-bugs(a)lists.fedoraproject.org,
                    shawn.p.huang(a)gmail.com, tfujiwar(a)redhat.com



Description of problem:
The new IBus on Fedora 28 comes in with a new Emoji Chooser interface.

This shouldn't be installed by default. (on GNOME, this kind of input UI is
supposed to be displayed by the shell)

In addition, GNOME Software happily lets users remove the Emoji Chooser "app",
which removes the ibus package… and as such removes GNOME Shell and GDM,
breaking the user's desktop.

Splitting the Emoji Chooser to its own subpackage allows us not to have it
installed by default, and in addition means that if it is installed, removing
it won't take the desktop down.

Version-Release number of selected component (if applicable):
ibus-1.5.18-4.fc28.x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 1567689] Please split out the emoji chooser

https://bugzilla.redhat.com/show_bug.cgi?id=1567689



--- Comment #1 from Mathieu Bridon <bochecha(a)daitauha.fr&gt; ---
Pull request: https://src.fedoraproject.org/rpms/ibus/pull-request/2

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 1567689] Please split out the emoji chooser

https://bugzilla.redhat.com/show_bug.cgi?id=1567689



--- Comment #2 from fujiwara <tfujiwar(a)redhat.com&gt; ---
I'd like to clarify your request.

(In reply to Mathieu Bridon from comment #0)
>  This shouldn't be installed by default. (on GNOME, this kind of
> input UI is
>  supposed to be displayed by the shell) 
Do you ask the UI is not installed by default while gnome-shell does not
provide the similar feature at present?
Once gnome-shell could implement the UI, I'd think ibus can replace the owned
UI with it.

>  Splitting the Emoji Chooser to its own subpackage allows us not to
> have it
>  installed by default, and in addition means that if it is installed,
>  removing it won't take the desktop down. 
The feature to output the selected emoji character was asked by several people
without using a clipboard and ibus hadn't provided the feature in GNOME only.
If the sub package is used, the feature won't be available in desktops so
probably I think the sub package needs to be installed by default by desktop?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 1567689] Please split out the emoji chooser

https://bugzilla.redhat.com/show_bug.cgi?id=1567689



--- Comment #3 from Mathieu Bridon <bochecha(a)daitauha.fr&gt; ---
Whether this should be installed by default or not is up to the Workstation WG.
Since I'm not a member of the WG I'm going to refrain from commenting on this,
and I probably shouldn't have mentioned it in the first place in my original
report, sorry about that.

The real issue here is that gnome-shell ends up depending on what appears as an
application in GNOME Software, and removing this application removes
gnome-shell.

GNOME Shell depends on the IBus library and on the IBus daemon. It does not
actually depend on this emoji chooser.

GNOME Shell is an OS component. OS components should never depend on optional
applications.

The packaging should reflect this, so that the emoji chooser can be
installed/removed independently.

I'd like to keep this issue on this specific point moving forward if you don't
mind, and this is what my pull request achieves.

The workstation WG can then decide whether they want this installed by default
or not independently.

All I want to fix in this report (and pull request) is the very big risk that
someone ends up with a system that doesn't boot to GNOME any more because they
thought they didn't need the emoji chooser and remove it. (like I did)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 1567689] Please split out the emoji chooser

https://bugzilla.redhat.com/show_bug.cgi?id=1567689



--- Comment #4 from fujiwara <tfujiwar(a)redhat.com&gt; ---
Thank you for your explanation.

I created a scratch build to split the package:
https://koji.fedoraproject.org/koji/taskinfo?taskID=26412210
The build includes 'ibus-extension' sub package.

(In reply to Mathieu Bridon from comment #1)
>  Pull request: https://src.fedoraproject.org/rpms/ibus/pull-request/2
It seems this request is to split ibus-ui-emojier from 'ibus' package but I
think your issue is ibus-extension-gtk3 instead.
ibus-ui-emojier is launched by `ibus emoji` command only to enable copy & paste
in GNOME Wayland and it has been available since Fedora 27.
ibus-extension-gtk3 is integrated in Fedora 28.

The scratch build includes the following patch not to crash ibus without
ibus-extension-gtk3.
https://github.com/ibus/ibus/commit/3280848b42b07afbac3d59066474c5f429de9182

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 1567689] Please split out the emoji chooser

https://bugzilla.redhat.com/show_bug.cgi?id=1567689



--- Comment #5 from Mathieu Bridon <bochecha(a)daitauha.fr&gt; ---
The issue happens with both, I get 2 entries in GNOME Software, both can be
removed, both take GNOME Shell with them.

With your scratch build, Software now only shows one of the two "Emoji Choice"
apps.

I really think both need to be split out, as I did in my pull request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 1567689] Please split out the emoji chooser

https://bugzilla.redhat.com/show_bug.cgi?id=1567689



--- Comment #6 from fujiwara <tfujiwar(a)redhat.com&gt; ---
(In reply to Mathieu Bridon from comment #5)
>  With your scratch build, Software now only shows one of the two
> "Emoji
>  Choice" apps. 
Seems your issue is to pull the applications from .desktop files.
I'd like to fix the issue to replace 'OnlyShowIn=' with
'NoDisplay=true' in
.desktop files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 1567689] Please split out the emoji chooser

https://bugzilla.redhat.com/show_bug.cgi?id=1567689



--- Comment #7 from Kalev Lember <klember(a)redhat.com&gt; ---
FYI, I just fixed the 'OnlyShowIn=' issue on gnome-software side,
https://github.com/hughsie/appstream-glib/commit/95dd5f7bcbca007145f4c625...
and backported it to
https://bodhi.fedoraproject.org/updates/libappstream-glib-0.7.7-3.fc28

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 1567689] Please split out the emoji chooser

https://bugzilla.redhat.com/show_bug.cgi?id=1567689



--- Comment #8 from fujiwara <tfujiwar(a)redhat.com&gt; ---
(In reply to Kalev Lember from comment #7)
>  FYI, I just fixed the 'OnlyShowIn=' issue on gnome-software
> side,
>  https://github.com/hughsie/appstream-glib/commit/
>  95dd5f7bcbca007145f4c625f6c14c94c40cb481 and backported it to
>  https://bodhi.fedoraproject.org/updates/libappstream-glib-0.7.7-3.fc28 
Thank you.
Probably I will replace 'OnlyShowIn=' with 'NoDisplay=true' later for
other
applications.

The problem was I didn't know the submitter's "GNOME Software" is an
application and I thought it meant GNOME developers by mistake.
"GNOME Software Manager" might be better for the application name.

I finally noticed the original issue:
https://gitlab.gnome.org/GNOME/gnome-software/issues/367

It would be better for the submitter to explain the content of g-s#367.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 1567689] Please split out the emoji chooser

https://bugzilla.redhat.com/show_bug.cgi?id=1567689

fujiwara <tfujiwar(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2018-08-30 02:09:21



-- 
You are receiving this mail because:
You are on the CC list for the bug.