[PATCH 1/2] Try to install PHY and MDIO bus drivers explicitly
by Coiby Xu
Resolves: https://issues.redhat.com/browse/RHEL-7028
Currently, nfs dumping fails on some machines that has a dedicated PHY
driver (dealing with the physical layer) or MDIO bus (connecting the MAC
to PHY devices) driver. This is because kexec-tools doesn't install
dedicated PHY or MDIO driver explicitly and the NIC driver don't specify
the dependency on the needed PHY or MDIO driver. So when the dependency
on a PHY driver or MDIO driver is not found by dracut's instmods, the
PHY or MDIO driver won't be installed.
This patch passes =drivers/net/phy and =drivers/net/mdio to dracut's
instmods which will only install in-use PHY or MDIO driver(s).
Note ideally we should find out which PHY driver is used by a NIC but
unfortunately currently no universal way can be found
(/sys/class/net/NIC_NAME/device/driver/module can be used to find the
name of the PHY driver for some NICs but it doesn't exist for some NICs
like Qualcomm Atheros AR8031). So is it for a MDIO bus driver.
Fortunately currently no huge memory consumption is found for a PHY or
MDIO driver.
Fixes: a65dde2d ("Reduce kdump memory consumption by only installing needed NIC drivers")
Reported-by: Doreen Alongi <dalongi(a)redhat.com>
Signed-off-by: Coiby Xu <coxu(a)redhat.com>
---
dracut-module-setup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index ff53d084..905e6fbd 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -381,7 +381,7 @@ _get_hpyerv_physical_driver() {
kdump_install_nic_driver() {
local _netif _driver _drivers
- _drivers=()
+ _drivers=('=drivers/net/phy' '=drivers/net/mdio')
for _netif in $1; do
[[ $_netif == lo ]] && continue
--
2.41.0
1 week, 2 days
[PATCH v2 0/2] consolidated s390 device configuration
by Steffen Maier
Consolidate the persistent and dynamic configuration of s390-specific
network devices by delegating the configuration to the existing framework
zdev from s390-tools.
This is part of a larger consolidation comprising:
https://github.com/ibm-s390-linux/s390-tools/pull/158
https://github.com/dracutdevs/dracut/pull/2534
https://github.com/storaged-project/blivet/pull/1162
https://github.com/rhinstaller/anaconda/pull/5250
https://github.com/steffen-maier/s390utils/pull/1
However, there are no dependencies on these other pull requests, so the
change here can go in independently. It only depends on zdev from
s390-tools, which exists since years.
Zdev's job is to perform low-level configuration after which the user gets
architecture-independent objects such as network interfaces. Those can and
should in turn be configured with existing common code mechanisms. So
there's a clear separated layering for configuration duties.
In particular, the s390-specific network devices currently are: ZNET
representing channel-attached network (QETH incl. OSA and HiperSockets,
LCS, CTC). Zdev has a stable command line user interface and abstracts from
sysfs and from a persistent configuration representation. Zdev encapsulates
configuration details. Systems management code can simply delegate
configuration to zdev and thus reduce architecture-specific code.
This improves user experience, serviceability, maintainability, and reduces
test effort.
Changes since v1:
Addressed review comments from Philipp:
* Replaced first paragraph (dracut commit reference) of patch 1 description
with a summary of this cover letter providing URLs to 2 pull requests
for dracut and s390utils with relevant commit titles.
* Put temp file under subdir ${_DRACUT_KDUMP_NM_TMP_DIR}.
My own changes:
* Patch 2 description now also references the s390utils pull request
with relevant commit title to provide further information regarding
migration of znet persistent config from the old to the new scheme.
Steffen Maier (2):
dracut-module-setup: consolidate s390 network device config (#1937048)
dracut-module-setup: remove old s390 network device config (#1937048)
dracut-module-setup.sh | 53 ++++++++++++++----------------------------
1 file changed, 17 insertions(+), 36 deletions(-)
base-commit: 5058cef90c2e24ff3a17a9c5560e16363e3281f5
--
2.39.3
3 months, 1 week
[PATCH 0/2] consolidated s390 device configuration
by Steffen Maier
Consolidate the persistent and dynamic configuration of s390-specific
network devices by delegating the configuration to the existing framework
zdev from s390-tools.
This is part of a larger consolidation comprising:
https://github.com/ibm-s390-linux/s390-tools/pull/158
https://github.com/dracutdevs/dracut/pull/2534
https://github.com/storaged-project/blivet/pull/1162
https://github.com/rhinstaller/anaconda/pull/5250
https://github.com/steffen-maier/s390utils/commits/zdev
However, there are no dependencies on these other pull requests, so the
change here can go in independently. It only depends on zdev from
s390-tools, which exists since years.
Zdev's job is to perform low-level configuration after which the user gets
architecture-independent objects such as network interfaces. Those can and
should in turn be configured with existing common code mechanisms. So
there's a clear separated layering for configuration duties.
In particular, the s390-specific network devices currently are: ZNET
representing channel-attached network (QETH incl. OSA and HiperSockets,
LCS, CTC). Zdev has a stable command line user interface and abstracts from
sysfs and from a persistent configuration representation. Zdev encapsulates
configuration details. Systems management code can simply delegate
configuration to zdev and thus reduce architecture-specific code.
This improves user experience, serviceability, maintainability, and reduces
test effort.
Steffen Maier (2):
dracut-module-setup: consolidate s390 network device config (#1937048)
dracut-module-setup: remove old s390 network device config (#1937048)
dracut-module-setup.sh | 53 ++++++++++++++----------------------------
1 file changed, 17 insertions(+), 36 deletions(-)
base-commit: 5058cef90c2e24ff3a17a9c5560e16363e3281f5
--
2.39.3
4 months, 3 weeks
[PATCH] Let %post scriptlet always exits with the zero exit status
by Coiby Xu
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2247940
Currently, CoreOS image fails to be built. This is because since commit
00c37d8c ("spec: Drop special handling for IA64 machines"), the last
command is now kdump-migrate-action.sh and it fails to run in such
invocation environment. Thus the %post scriptlet returns a non-zero
exit code which breaks package installation,
Running scriptlet: kexec-tools-2.0.27-4.fc40.ppc64le
/proc/ is not mounted. This is not a supported mode of operation. Please fix your invocation environment to mount /proc/ and /sys/ properly. Proceeding anyway. Your mileage may vary.
servicelog_notify: is not supported on the Unknown platform
warning: %post(kexec-tools-2.0.27-4.fc40.ppc64le) scriptlet failed, exit status 1
Error in POSTIN scriptlet in rpm package kexec-tools
Quoting [1],
> Non-zero exit codes from scriptlets can break installs/upgrades/erases
> such that no further actions will be taken for that package in a
> transaction (see Ordering), which may for example prevent an old version
> of a package from being erased on upgrades, ...
>
> All scriptlets MUST exit with the zero exit status. Because RPM in its
> default configuration does not execute shell scriptlets with the -e
> argument to the shell, excluding explicit exit calls (frowned upon with
> a non-zero argument!), the exit status of the last command in a
> scriptlet determines its exit status...
>
> Usually the most important bit is to apply this to the last command
> executed in a scriptlet, or to add a separate command such as plain “:”
> or “exit 0” as the last one in a scriptlet.
Following the above suggestion, add a separate command ":" as the last
one to the %post scriptlet.
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/
Reported-by: Colin Walters <walters(a)redhat.com>
Cc: Dusty Mabe <dustymabe(a)redhat.com>
Cc: Philipp Rudo <prudo(a)redhat.com>
Fixes: 00c37d8c ("spec: Drop special handling for IA64 machines")
Signed-off-by: Coiby Xu <coxu(a)redhat.com>
---
kexec-tools.spec | 1 +
1 file changed, 1 insertion(+)
diff --git a/kexec-tools.spec b/kexec-tools.spec
index cb1a408c..19b0b69d 100644
--- a/kexec-tools.spec
+++ b/kexec-tools.spec
@@ -271,6 +271,7 @@ touch /etc/kdump.conf
servicelog_notify --remove --command=/usr/lib/kdump/kdump-migrate-action.sh 2>/dev/null
servicelog_notify --add --command=/usr/lib/kdump/kdump-migrate-action.sh --match='refcode="#MIGRATE" and serviceable=0' --type=EVENT --method=pairs_stdin >/dev/null
%endif
+:
%postun
--
2.41.0
4 months, 3 weeks
[PATCH] Add /etc/resolve.conf to kdump initrd if it's managed manually
by Coiby Xu
Some users may choose to manage /etc/resolve.conf manually. In this case,
network dumping will not work because DNS resolution doesn't work. Copy
/etc/resolve.conf to kdump initrd if this file is not managed by
systemd-resolved or NetworkManager.
Fixes: 63c3805c ("Set up kdump network by directly copying NM connection profile to initrd")
Reported-by: Curtis Taylor <cutaylor(a)redhat.com>
Cc: Jie Li <jieli(a)redhat.com>
Signed-off-by: Coiby Xu <coxu(a)redhat.com>
---
dracut-module-setup.sh | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index ff53d084..e6355973 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -563,6 +563,19 @@ kdump_collect_netif_usage() {
fi
}
+kdump_install_resolv_conf() {
+
+ local _resolv_conf=/etc/resolv.conf
+
+ # Some users may choose to manage /etc/resolve.conf manually.
+ #
+ # We can tell this case by confirming this file is not manged by
+ # systemd-resolved or NetworkManager.
+ if ! grep -qs "^nameserver 127.0.0.53" "$_resolv_conf" && ! grep -qs "^# Generated by NetworkManager" "$_resolv_conf"; then
+ dracut_install "$_resolv_conf"
+ fi
+}
+
# Setup dracut to bring up network interface that enable
# initramfs accessing giving destination
kdump_install_net() {
@@ -575,6 +588,7 @@ kdump_install_net() {
kdump_setup_znet
kdump_install_nm_netif_allowlist "$_netifs"
kdump_install_nic_driver "$_netifs"
+ kdump_install_resolv_conf
fi
}
--
2.41.0
5 months
[PATCH v2] kdumpctl: Only returns immediately after an error occurs in check_*_modified
by Lichen Liu
Currently is_system_modified will return immediately when check_*_modified
return a non-zero value, and the remaining checks will not be executed.
For example, if there is a fs-related error exists, and someone changes the
kdump.conf, check_files_modified will return 1 and is_system_modified will
return 1 immediately. This will cause kdumpctl to skip check_fs/drivers_modified,
kdump.service will rebuild the initrd and start successfully, however, any
errors should prevent kdump.service from starting.
This patch will cause check_*_modifed to continue running until an error occurs
or all execution ends.
Signed-off-by: Lichen Liu <lichliu(a)redhat.com>
---
kdumpctl | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/kdumpctl b/kdumpctl
index 01433e2..3da5fff 100755
--- a/kdumpctl
+++ b/kdumpctl
@@ -605,6 +605,10 @@ check_fs_modified()
is_system_modified()
{
local ret
+ local CONF_ERROR=2
+ local CONF_MODIFY=1
+ local CONF_NO_MODIFY=0
+ local conf_status=$CONF_NO_MODIFY
[[ -f $TARGET_INITRD ]] || return 1
@@ -617,9 +621,15 @@ is_system_modified()
fi
fi
- check_files_modified || return
- check_fs_modified || return
- check_drivers_modified
+ for _func in check_files_modified check_fs_modified check_drivers_modified; do
+ $_func
+ ret=$?
+ # return immediately if an error occurred.
+ [[ $ret -eq "$CONF_ERROR" ]] && return "$ret"
+ [[ $ret -eq "$CONF_MODIFY" ]] && { conf_status="$CONF_MODIFY"; }
+ done
+
+ return $conf_status
}
# need_initrd_rebuild - check whether the initrd needs to be rebuild
--
2.41.0
5 months, 1 week
[PATCH v3] kdump-lib.sh: add extra 64M to default crashkernel if sme/sev is active
by Baoquan He
It's reported that kdump kernel failed to boot and can't dump vmcore
when crashkernel=192M and SME/SEV is active.
This is because swiotlb will be enabled and reserves 64M memory by
default on system with SME/SEV enabled. Then kdump kernel will be out of
memory after taking 64M away for swiotlb init.
So here add extra 64M memory to default crashkernel value so that kdump
kernel can function well as before. When doing that, search journalctl
for the "Memory Encryption Features active: AMD" to check if SME or SEV
is active. This line of log is printed out in kernel function as below
and the type SME is mutual exclusive with type SEV.
***:
arch/x86/mm/mem_encrypt.c:print_mem_encrypt_feature_info()
Note:
1) The conditional check is relying on journalctl log because I didn't
find available system interface to check if SEV is active. Even
though we can check if SME is active via /proc/cpuinfo. For
consistency, I take the same check for both SME and SEV by searching
journalctl.
2) The conditional check is relying on journalctl log, means it won't
work for crashkernel setting in anoconda because the installation
kernel doesn't have the SME/SEV setting. So customer need manually
run 'kdumpctl reset-crashkernel' to reset crashkernel to add the
extra 64M after OS installation.
3) We need watch the line of log printing in
print_mem_encrypt_feature_info() in kernel just in case people may
change it in the future.
Signed-off-by: Baoquan He <bhe(a)redhat.com>
---
v2->v3:
- Redirect the stdin|out to /dev/null since "journalctl -q" can't
suppress output completely. Suggested by Coiby.
- Define local variable "_delta" to contain the value added on
"$_ck_cmdline". This is suggested by Philipp.
kdump-lib.sh | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/kdump-lib.sh b/kdump-lib.sh
index 16238c508f65..89b6d39506fb 100755
--- a/kdump-lib.sh
+++ b/kdump-lib.sh
@@ -38,6 +38,11 @@ is_aws_aarch64()
[[ "$(lscpu | grep "BIOS Model name")" =~ "AWS Graviton" ]]
}
+is_sme_or_sev_active()
+{
+ journalctl -q --dmesg --grep "^Memory Encryption Features active: AMD (SME|SEV)$" >/dev/null 2>&1
+}
+
is_squash_available()
{
local _version kmodule
@@ -917,6 +922,7 @@ _crashkernel_add()
kdump_get_arch_recommend_crashkernel()
{
local _arch _ck_cmdline _dump_mode
+ local _delta=0
if [[ -z "$1" ]]; then
if is_fadump_capable; then
@@ -932,9 +938,9 @@ kdump_get_arch_recommend_crashkernel()
if [[ $_arch == "x86_64" ]] || [[ $_arch == "s390x" ]]; then
_ck_cmdline="1G-4G:192M,4G-64G:256M,64G-:512M"
+ is_sme_or_sev_active && ((_delta += 64))
elif [[ $_arch == "aarch64" ]]; then
local _running_kernel
- local _delta=0
# Base line for 4K variant kernel. The formula is based on x86 plus extra = 64M
_ck_cmdline="1G-4G:256M,4G-64G:320M,64G-:576M"
@@ -958,7 +964,6 @@ kdump_get_arch_recommend_crashkernel()
#4k kernel, mlx5 consumes extra 124M memory, and choose 150M
has_mlx5 && ((_delta += 150))
fi
- _ck_cmdline=$(_crashkernel_add "$_ck_cmdline" "$_delta")
elif [[ $_arch == "ppc64le" ]]; then
if [[ $_dump_mode == "fadump" ]]; then
_ck_cmdline="4G-16G:768M,16G-64G:1G,64G-128G:2G,128G-1T:4G,1T-2T:6G,2T-4T:12G,4T-8T:20G,8T-16T:36G,16T-32T:64G,32T-64T:128G,64T-:180G"
@@ -967,7 +972,7 @@ kdump_get_arch_recommend_crashkernel()
fi
fi
- echo -n "$_ck_cmdline"
+ echo -n "$(_crashkernel_add "$_ck_cmdline" "$_delta")"
}
# return recommended size based on current system RAM size
--
2.41.0
5 months, 2 weeks
[PATCH 1/2] tests: enable kdump.service in the systemd preset policy to allow setting up the crashkernel kernel parameter automatically
by Coiby Xu
Previously, the kernel parameter crashkernel will be set up when
kexec-tools is installed. But now it will happen only when kdump.service
is enabled first. When kexec-tools is installed, the kdump.service will
be enabled according to the systemd policy file and later the kernel
parameter crashkernel will be added only if kdump.service is enabled.
Fedora disables kdump.service in the systemd policy. So enable
kdump.service in the systemd preset policy manually in the test script.
Fixes: 0ffce0ef ("Only try to reset crashkernel when kdump.service is enabled")
Signed-off-by: Coiby Xu <coxu(a)redhat.com>
---
tests/scripts/build-scripts/test-base-image.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/scripts/build-scripts/test-base-image.sh b/tests/scripts/build-scripts/test-base-image.sh
index afe1a974..866e5646 100755
--- a/tests/scripts/build-scripts/test-base-image.sh
+++ b/tests/scripts/build-scripts/test-base-image.sh
@@ -16,6 +16,9 @@ img_inst $TESTDIR/scripts/kexec-kdump-test/test.sh /kexec-kdump-test/test.sh
img_inst $TESTDIR/scripts/kexec-kdump-test/kexec-kdump-test.service /etc/systemd/system/kexec-kdump-test.service
img_run_cmd "systemctl enable kexec-kdump-test.service"
+# enable kdump.service in the systemd preset policy so the kernel parameter crashkernel
+# will be added automatically when kexec-tools is installed
+img_run_cmd "echo 'enable kdump.service' > /usr/lib/systemd/system-preset/95-kdump.preset"
img_inst_pkg $TEST_RPMS
# Test script should start kdump manually to save time
img_run_cmd "systemctl disable kdump.service"
--
2.41.0
5 months, 3 weeks
[PATCH] Allow _crashkernel_add to address terabyte memory range
by Coiby Xu
Currently _crashkernel_add can't deal with a terabyte memory range e.g.
_crashkernel_add "128G-1T:4G" "0" actually returns empty result.
Fixes: 64f2827a ("kdump-lib: Harden _crashkernel_add")
Signed-off-by: Coiby Xu <coxu(a)redhat.com>
---
kdump-lib.sh | 11 +++++++++--
spec/kdump-lib_spec.sh | 6 +++++-
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/kdump-lib.sh b/kdump-lib.sh
index ae39c236..c7fa6c16 100755
--- a/kdump-lib.sh
+++ b/kdump-lib.sh
@@ -862,7 +862,7 @@ has_aarch64_smmu()
ls /sys/devices/platform/arm-smmu-* 1> /dev/null 2>&1
}
-is_memsize() { [[ "$1" =~ ^[+-]?[0-9]+[KkMmGg]?$ ]]; }
+is_memsize() { [[ "$1" =~ ^[+-]?[0-9]+[BbKkMmGgTt]?$ ]]; }
# range defined for crashkernel parameter
# i.e. <start>-[<end>]
@@ -881,6 +881,9 @@ to_bytes()
is_memsize "$_s" || return 1
case "${_s: -1}" in
+ B|b)
+ _s=${_s::-1}
+ ;;
K|k)
_s=${_s::-1}
_s="$((_s * 1024))"
@@ -893,6 +896,10 @@ to_bytes()
_s=${_s::-1}
_s="$((_s * 1024 * 1024 * 1024))"
;;
+ T|t)
+ _s=${_s::-1}
+ _s="$((_s * 1024 * 1024 * 1024 * 1024))"
+ ;;
*)
;;
esac
@@ -901,7 +908,7 @@ to_bytes()
memsize_add()
{
- local -a units=("" "K" "M" "G")
+ local -a units=("" "K" "M" "G" "T")
local i a b
a=$(to_bytes "$1") || return 1
diff --git a/spec/kdump-lib_spec.sh b/spec/kdump-lib_spec.sh
index 814f9618..ae94e609 100644
--- a/spec/kdump-lib_spec.sh
+++ b/spec/kdump-lib_spec.sh
@@ -52,14 +52,18 @@ Describe 'kdump-lib'
Context "For valid input values"
Parameters
"1G-4G:256M,4G-64G:320M,64G-:576M" "100M" "1G-4G:356M,4G-64G:420M,64G-:676M"
+ "1G-4G:256M" "100B" "1G-4G:268435556" # avoids any rounding when size % 1024 != 0
"1G-4G:256M,4G-64G:320M,64G-:576M@4G" "100M" "1G-4G:356M,4G-64G:420M,64G-:676M@4G"
"1G-4G:1G,4G-64G:2G,64G-:3G@4G" "100M" "1G-4G:1124M,4G-64G:2148M,64G-:3172M@4G"
"1G-4G:10000K,4G-64G:20000K,64G-:40000K@4G" "100M" "1G-4G:112400K,4G-64G:122400K,64G-:142400K@4G"
"1,high" "1" "2,high"
"1K,low" "1" "1025,low"
+ "128G-1T:4G" "0" "128G-1T:4G"
+ "10T-100T:1T" "0" "10T-100T:1T"
+ "128G-1T:4G" "0M" "128G-1T:4G"
"1M@1G" "1k" "1025K@1G"
"500M@1G" "-100m" "400M@1G"
- "1099511627776" "0" "1024G"
+ "1099511627776" "0" "1T"
End
It "should add delta to every value after ':'"
When call _crashkernel_add "$1" "$2"
--
2.41.0
5 months, 3 weeks
[PATCH] Fix two issues in _crashkernel_add
by Coiby Xu
This patch fix the following issues with _crashkernel_add,
1. it couldn't address a terabyte memory range e.g. _crashkernel_add "128G-1T:4G" "0"
actually returns empty result
2. it allows a memory delta without a unit specified and returns the incorrect result
e.g. _crashkernel_add 1G-4G:256M,4G-64G:320M,64G-:576M 100 actually
returns 1G-4G:268435556,4G-64G:335544420,64G-:603979876
Note a memory delta without unit like 0M is allowed.
Fixes: 64f2827a ("kdump-lib: Harden _crashkernel_add")
Signed-off-by: Coiby Xu <coxu(a)redhat.com>
---
kdump-lib.sh | 9 ++++++++-
spec/kdump-lib_spec.sh | 7 +++++--
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/kdump-lib.sh b/kdump-lib.sh
index ae39c236..d182bab8 100755
--- a/kdump-lib.sh
+++ b/kdump-lib.sh
@@ -862,7 +862,9 @@ has_aarch64_smmu()
ls /sys/devices/platform/arm-smmu-* 1> /dev/null 2>&1
}
-is_memsize() { [[ "$1" =~ ^[+-]?[0-9]+[KkMmGg]?$ ]]; }
+is_memdelta() { [[ "$1" == 0 || "$1" =~ ^[+-]?[0-9]+[BbKkMmGgTt]$ ]]; }
+
+is_memsize() { [[ "$1" =~ ^[+-]?[0-9]+[BbKkMmGgTt]?$ ]]; }
# range defined for crashkernel parameter
# i.e. <start>-[<end>]
@@ -881,6 +883,9 @@ to_bytes()
is_memsize "$_s" || return 1
case "${_s: -1}" in
+ B|b)
+ _s=${_s::-1}
+ ;;
K|k)
_s=${_s::-1}
_s="$((_s * 1024))"
@@ -964,6 +969,8 @@ _crashkernel_add()
delta="$2"
ret=""
+ is_memdelta "$delta" || return 1
+
while IFS=';' read -r size range offset; do
if [[ -n "$offset" ]]; then
ret="${ret%,}$offset"
diff --git a/spec/kdump-lib_spec.sh b/spec/kdump-lib_spec.sh
index 814f9618..ee6c9b27 100644
--- a/spec/kdump-lib_spec.sh
+++ b/spec/kdump-lib_spec.sh
@@ -55,8 +55,10 @@ Describe 'kdump-lib'
"1G-4G:256M,4G-64G:320M,64G-:576M@4G" "100M" "1G-4G:356M,4G-64G:420M,64G-:676M@4G"
"1G-4G:1G,4G-64G:2G,64G-:3G@4G" "100M" "1G-4G:1124M,4G-64G:2148M,64G-:3172M@4G"
"1G-4G:10000K,4G-64G:20000K,64G-:40000K@4G" "100M" "1G-4G:112400K,4G-64G:122400K,64G-:142400K@4G"
- "1,high" "1" "2,high"
- "1K,low" "1" "1025,low"
+ "128G-1T:4G" "0" "128G-1T:4G"
+ "128G-1T:4G" "0M" "128G-1T:4G"
+ "1,high" "1b" "2,high"
+ "1K,low" "1b" "1025,low"
"1M@1G" "1k" "1025K@1G"
"500M@1G" "-100m" "400M@1G"
"1099511627776" "0" "1024G"
@@ -68,6 +70,7 @@ Describe 'kdump-lib'
End
Context "For invalid input values"
Parameters
+ "1G-4G:256M" "100"
"1G-4G:256M.4G-64G:320M" "100M"
"foo" "1"
"1" "bar"
--
2.41.0
5 months, 3 weeks