Previously, the range of log level is from 1 to 6, and the TRACE
level and FATAL level are not used, therefore, let's remove these
unused log levels and update the kdump sysconfig accordingly.
Nowadays it has only four log levels: error(1), warn(2), info(3)
and debug(4). We have to remap the numeric log level to the logger
priority or syslog log level, which is finished in kdump-logger.sh
module, it is invisible for user.
Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com>
---
dracut-module-setup.sh | 4 +-
kdump-logger.sh | 162 +++++++++++-----------------------------
kdump.sysconfig | 12 +--
kdump.sysconfig.aarch64 | 12 +--
kdump.sysconfig.i386 | 12 +--
kdump.sysconfig.ppc64 | 12 +--
kdump.sysconfig.ppc64le | 12 +--
kdump.sysconfig.s390x | 12 +--
kdump.sysconfig.x86_64 | 12 +--
9 files changed, 89 insertions(+), 161 deletions(-)
diff --git a/dracut-module-setup.sh b/dracut-module-setup.sh
index 911a8b84de9d..718edf98e857 100755
--- a/dracut-module-setup.sh
+++ b/dracut-module-setup.sh
@@ -33,7 +33,7 @@ depends() {
if is_squash_available && ! is_fadump_capable; then
_dep="$_dep squash"
else
- dwarning "Required modules to build a squashed kdump image is
missing!"
+ dwarn "Required modules to build a squashed kdump image is missing!"
fi
if [ -n "$( find /sys/devices -name drm )" ] || [ -d /sys/module/hyperv_fb
]; then
@@ -72,7 +72,7 @@ source_ifcfg_file() {
if [ -f "${ifcfg_file}" ]; then
. ${ifcfg_file}
else
- dwarning "The ifcfg file of $1 is not found!"
+ dwarn "The ifcfg file of $1 is not found!"
fi
}
diff --git a/kdump-logger.sh b/kdump-logger.sh
index a3d674cd07c2..0645ad8780db 100755
--- a/kdump-logger.sh
+++ b/kdump-logger.sh
@@ -2,24 +2,18 @@
#
# This comes from the dracut-logger.sh
#
-# The logger defined 6 logging levels:
-# - dtrace() (6)
-# The TRACE Level designates finer-grained informational events than the
-# DEBUG.
-# - ddebug (5)
+# The logger defined 4 logging levels:
+# - ddebug (4)
# The DEBUG Level designates fine-grained informational events that are most
# useful to debug an application.
-# - dinfo (4)
+# - dinfo (3)
# The INFO level designates informational messages that highlight the
# progress of the application at coarse-grained level.
-# - dwarn (3)
+# - dwarn (2)
# The WARN level designates potentially harmful situations.
-# - derror (2)
+# - derror (1)
# The ERROR level designates error events that might still allow the
# application to continue running.
-# - dfatal (1)
-# The FATAL level designates very severe error events that will presumably
-# lead the application to abort.
#
# Logging is controlled by following global variables:
# - @var kdump_stdloglvl - logging level to standard error (console output)
@@ -27,8 +21,8 @@
# - @var kdump_kmsgloglvl - logging level to /dev/kmsg (only for boot-time)
#
# If any of the variables is not set, this function set it to default:
-# - @var kdump_stdloglvl = 4 (info)
-# - @var kdump_sysloglvl = 4 (info)
+# - @var kdump_stdloglvl = 3 (info)
+# - @var kdump_sysloglvl = 3 (info)
# - @var kdump_kmsgloglvl = 0 (no logging)
#
# First of all you have to start with dlog_init() function which initializes
@@ -42,7 +36,7 @@
check_loglvl()
{
case "$1" in
- 0|1|2|3|4|5|6)
+ 0|1|2|3|4)
return 0
;;
*)
@@ -58,8 +52,8 @@ check_loglvl()
dlog_init() {
local ret=0; local errmsg
- [ -z "$kdump_stdloglvl" ] && kdump_stdloglvl=4
- [ -z "$kdump_sysloglvl" ] && kdump_sysloglvl=4
+ [ -z "$kdump_stdloglvl" ] && kdump_stdloglvl=3
+ [ -z "$kdump_sysloglvl" ] && kdump_sysloglvl=3
[ -z "$kdump_kmsgloglvl" ] && kdump_kmsgloglvl=0
for loglvl in $kdump_stdloglvl $kdump_kmsgloglvl $kdump_sysloglvl; do
@@ -103,83 +97,50 @@ dlog_init() {
readonly kdump_maxloglvl=$maxloglvl_l
export kdump_maxloglvl
-
- if [[ $kdump_stdloglvl -lt 6 ]] && [[ $kdump_kmsgloglvl -lt 6 ]] &&
[[ $kdump_sysloglvl -lt 6 ]]; then
- unset dtrace
- dtrace() { :; };
- fi
-
- if [[ $kdump_stdloglvl -lt 5 ]] && [[ $kdump_kmsgloglvl -lt 5 ]] &&
[[ $kdump_sysloglvl -lt 5 ]]; then
+ if [[ $kdump_stdloglvl -lt 4 ]] && [[ $kdump_kmsgloglvl -lt 4 ]] &&
[[ $kdump_sysloglvl -lt 4 ]]; then
unset ddebug
ddebug() { :; };
fi
- if [[ $kdump_stdloglvl -lt 4 ]] && [[ $kdump_kmsgloglvl -lt 4 ]] &&
[[ $kdump_sysloglvl -lt 4 ]]; then
+ if [[ $kdump_stdloglvl -lt 3 ]] && [[ $kdump_kmsgloglvl -lt 3 ]] &&
[[ $kdump_sysloglvl -lt 3 ]]; then
unset dinfo
dinfo() { :; };
fi
- if [[ $kdump_stdloglvl -lt 3 ]] && [[ $kdump_kmsgloglvl -lt 3 ]] &&
[[ $kdump_sysloglvl -lt 3 ]]; then
+ if [[ $kdump_stdloglvl -lt 2 ]] && [[ $kdump_kmsgloglvl -lt 2 ]] &&
[[ $kdump_sysloglvl -lt 2 ]]; then
unset dwarn
dwarn() { :; };
- unset dwarning
- dwarning() { :; };
fi
- if [[ $kdump_stdloglvl -lt 2 ]] && [[ $kdump_kmsgloglvl -lt 2 ]] &&
[[ $kdump_sysloglvl -lt 2 ]]; then
+ if [[ $kdump_stdloglvl -lt 1 ]] && [[ $kdump_kmsgloglvl -lt 1 ]] &&
[[ $kdump_sysloglvl -lt 1 ]]; then
unset derror
derror() { :; };
fi
- if [[ $kdump_stdloglvl -lt 1 ]] && [[ $kdump_kmsgloglvl -lt 1 ]] &&
[[ $kdump_sysloglvl -lt 1 ]]; then
- unset dfatal
- dfatal() { :; };
- fi
-
[ -n "$errmsg" ] && derror "$errmsg"
return $ret
}
-## @brief Converts numeric logging level to the first letter of level name.
-#
-# @param lvl Numeric logging level in range from 1 to 6.
-# @retval 1 if @a lvl is out of range.
-# @retval 0 if @a lvl is correct.
-# @result Echoes first letter of level name.
-_lvl2char() {
- case "$1" in
- 1) echo F;;
- 2) echo E;;
- 3) echo W;;
- 4) echo I;;
- 5) echo D;;
- 6) echo T;;
- *) return 1;;
- esac
-}
-
## @brief Converts numeric level to logger priority defined by POSIX.2.
#
-# @param lvl Numeric logging level in range from 1 to 6.
+# @param lvl Numeric logging level in range from 1 to 4.
# @retval 1 if @a lvl is out of range.
# @retval 0 if @a lvl is correct.
# @result Echoes logger priority.
_lvl2syspri() {
case "$1" in
- 1) echo crit;;
- 2) echo error;;
- 3) echo warning;;
- 4) echo info;;
- 5) echo debug;;
- 6) echo debug;;
+ 1) echo error;;
+ 2) echo warning;;
+ 3) echo info;;
+ 4) echo debug;;
*) return 1;;
esac
}
## @brief Converts logger numeric level to syslog log level
#
-# @param lvl Numeric logging level in range from 1 to 6.
+# @param lvl Numeric logging level in range from 1 to 4.
# @retval 1 if @a lvl is out of range.
# @retval 0 if @a lvl is correct.
# @result Echoes kernel console numeric log level
@@ -189,13 +150,12 @@ _lvl2syspri() {
# <tt>
# none -> LOG_EMERG (0)
# none -> LOG_ALERT (1)
-# FATAL(1) -> LOG_CRIT (2)
-# ERROR(2) -> LOG_ERR (3)
-# WARN(3) -> LOG_WARNING (4)
+# none -> LOG_CRIT (2)
+# ERROR(1) -> LOG_ERR (3)
+# WARN(2) -> LOG_WARNING (4)
# none -> LOG_NOTICE (5)
-# INFO(4) -> LOG_INFO (6)
-# DEBUG(5) -> LOG_DEBUG (7)
-# TRACE(6) /
+# INFO(3) -> LOG_INFO (6)
+# DEBUG(4) -> LOG_DEBUG (7)
# </tt>
#
# @see /usr/include/sys/syslog.h
@@ -203,16 +163,17 @@ _dlvl2syslvl() {
local lvl
case "$1" in
- 1) lvl=2;;
- 2) lvl=3;;
- 3) lvl=4;;
- 4) lvl=6;;
- 5) lvl=7;;
- 6) lvl=7;;
+ 1) lvl=3;;
+ 2) lvl=4;;
+ 3) lvl=6;;
+ 4) lvl=7;;
*) return 1;;
esac
- [ -s /proc/vmcore ] && echo $((24+$lvl)) || echo $((8+$lvl))
+ # The number is constructed by multiplying the facility by 8 and then
+ # adding the level.
+ # About The Syslog Protocol, please refer to the RFC5424 for more details.
+ echo $((24+$lvl))
}
## @brief Prints to stderr and/or writes to file, to syslog and/or /dev/kmsg
@@ -223,10 +184,10 @@ _dlvl2syslvl() {
# @retval 0 It's always returned, even if logging failed.
#
# @note This function is not supposed to be called manually. Please use
-# dtrace(), ddebug(), or others instead which wrap this one.
+# dinfo(), ddebug(), or others instead which wrap this one.
#
-# This is core logging function which logs given message to standard error, file
-# and/or syslog (with POSIX shell command <tt>logger</tt>) and/or to
/dev/kmsg.
+# This is core logging function which logs given message to standard error
+# and syslog (with POSIX shell command <tt>logger</tt>) and/or to /dev/kmsg.
# The format is following:
#
# <tt>X: some message</tt>
@@ -236,16 +197,13 @@ _dlvl2syslvl() {
#
# Message to syslog is sent with tag @c kdump. Priorities are mapped as
# following:
-# - @c FATAL to @c crit
# - @c ERROR to @c error
# - @c WARN to @c warning
# - @c INFO to @c info
-# - @c DEBUG and @c TRACE both to @c debug
+# - @c DEBUG to @c debug
_do_dlog() {
local lvl="$1"; shift
- local lvlc=$(_lvl2char "$lvl") || return 0
local msg="$*"
- local lmsg="$lvlc: $*"
[[ $lvl -le $kdump_stdloglvl ]] && printf -- 'kdump: %s\n'
"$msg" >&2
@@ -268,7 +226,7 @@ _do_dlog() {
# @retval 0 It's always returned, even if logging failed.
#
# @note This function is not supposed to be called manually. Please use
-# dtrace(), ddebug(), or others instead which wrap this one.
+# dinfo(), ddebug(), or others instead which wrap this one.
#
# This function calls _do_dlog() either with parameter msg, or if
# none is given, it will read standard input and will use every line as
@@ -290,71 +248,41 @@ dlog() {
fi
}
-## @brief Logs message at TRACE level (6)
-#
-# @param msg Message.
-# @retval 0 It's always returned, even if logging failed.
-dtrace() {
- set +x
- dlog 6 "$@"
- [ -n "$debug" ] && set -x || :
-}
-
-## @brief Logs message at DEBUG level (5)
+## @brief Logs message at DEBUG level (4)
#
# @param msg Message.
# @retval 0 It's always returned, even if logging failed.
ddebug() {
- set +x
- dlog 5 "$@"
- [ -n "$debug" ] && set -x || :
-}
-
-## @brief Logs message at INFO level (4)
-#
-# @param msg Message.
-# @retval 0 It's always returned, even if logging failed.
-dinfo() {
set +x
dlog 4 "$@"
[ -n "$debug" ] && set -x || :
}
-## @brief Logs message at WARN level (3)
+## @brief Logs message at INFO level (3)
#
# @param msg Message.
# @retval 0 It's always returned, even if logging failed.
-dwarn() {
+dinfo() {
set +x
dlog 3 "$@"
[ -n "$debug" ] && set -x || :
}
-## @brief It's an alias to dwarn() function.
-#
-# @param msg Message.
-# @retval 0 It's always returned, even if logging failed.
-dwarning() {
- set +x
- dwarn "$@"
- [ -n "$debug" ] && set -x || :
-}
-
-## @brief Logs message at ERROR level (2)
+## @brief Logs message at WARN level (2)
#
# @param msg Message.
# @retval 0 It's always returned, even if logging failed.
-derror() {
+dwarn() {
set +x
dlog 2 "$@"
[ -n "$debug" ] && set -x || :
}
-## @brief Logs message at FATAL level (1)
+## @brief Logs message at ERROR level (1)
#
# @param msg Message.
# @retval 0 It's always returned, even if logging failed.
-dfatal() {
+derror() {
set +x
dlog 1 "$@"
[ -n "$debug" ] && set -x || :
diff --git a/kdump.sysconfig b/kdump.sysconfig
index 52a0b9249fe7..d956be32f5e9 100644
--- a/kdump.sysconfig
+++ b/kdump.sysconfig
@@ -41,13 +41,13 @@ KDUMP_IMG="vmlinuz"
# - @var kdump_sysloglvl - logging level to syslog (by logger command)
# - @var kdump_kmsgloglvl - logging level to /dev/kmsg (only for boot-time)
# If any of the variables is not set, this function set it to default:
-# - @var kdump_stdloglvl=4 (info)
-# - @var kdump_sysloglvl=4 (info)
+# - @var kdump_stdloglvl=3 (info)
+# - @var kdump_sysloglvl=3 (info)
# - @var kdump_kmsgloglvl=0 (no logging)
#
-# Logging levels: fatal(1),error(2),warn(3),info(4),debug(5),trace(6)
+# Logging levels: error(1),warn(2),info(3),debug(4)
#
# For example: the following configurations indicate that kdump messages will be printed
-# to console and journald for debugging case.
-# kdump_sysloglvl=5
-# kdump_stdloglvl=5
+# to console and journald, and this is also the current default log level(3).
+# kdump_sysloglvl=3
+# kdump_stdloglvl=3
diff --git a/kdump.sysconfig.aarch64 b/kdump.sysconfig.aarch64
index 1d75979df03e..5164b708903b 100644
--- a/kdump.sysconfig.aarch64
+++ b/kdump.sysconfig.aarch64
@@ -41,13 +41,13 @@ KDUMP_IMG="vmlinuz"
# - @var kdump_sysloglvl - logging level to syslog (by logger command)
# - @var kdump_kmsgloglvl - logging level to /dev/kmsg (only for boot-time)
# If any of the variables is not set, this function set it to default:
-# - @var kdump_stdloglvl=4 (info)
-# - @var kdump_sysloglvl=4 (info)
+# - @var kdump_stdloglvl=3 (info)
+# - @var kdump_sysloglvl=3 (info)
# - @var kdump_kmsgloglvl=0 (no logging)
#
-# Logging levels: fatal(1),error(2),warn(3),info(4),debug(5),trace(6)
+# Logging levels: error(1),warn(2),info(3),debug(4)
#
# For example: the following configurations indicate that kdump messages will be printed
-# to console and journald for debugging case.
-# kdump_sysloglvl=5
-# kdump_stdloglvl=5
+# to console and journald, and this is also the current default log level(3).
+# kdump_sysloglvl=3
+# kdump_stdloglvl=3
diff --git a/kdump.sysconfig.i386 b/kdump.sysconfig.i386
index 2eb9705e32e9..a335416c42ac 100644
--- a/kdump.sysconfig.i386
+++ b/kdump.sysconfig.i386
@@ -44,13 +44,13 @@ KDUMP_IMG_EXT=""
# - @var kdump_sysloglvl - logging level to syslog (by logger command)
# - @var kdump_kmsgloglvl - logging level to /dev/kmsg (only for boot-time)
# If any of the variables is not set, this function set it to default:
-# - @var kdump_stdloglvl=4 (info)
-# - @var kdump_sysloglvl=4 (info)
+# - @var kdump_stdloglvl=3 (info)
+# - @var kdump_sysloglvl=3 (info)
# - @var kdump_kmsgloglvl=0 (no logging)
#
-# Logging levels: fatal(1),error(2),warn(3),info(4),debug(5),trace(6)
+# Logging levels: error(1),warn(2),info(3),debug(4)
#
# For example: the following configurations indicate that kdump messages will be printed
-# to console and journald for debugging case.
-# kdump_sysloglvl=5
-# kdump_stdloglvl=5
+# to console and journald, and this is also the current default log level(3).
+# kdump_sysloglvl=3
+# kdump_stdloglvl=3
diff --git a/kdump.sysconfig.ppc64 b/kdump.sysconfig.ppc64
index 24279ff34211..ba3857434569 100644
--- a/kdump.sysconfig.ppc64
+++ b/kdump.sysconfig.ppc64
@@ -46,13 +46,13 @@ KDUMP_IMG_EXT=""
# - @var kdump_sysloglvl - logging level to syslog (by logger command)
# - @var kdump_kmsgloglvl - logging level to /dev/kmsg (only for boot-time)
# If any of the variables is not set, this function set it to default:
-# - @var kdump_stdloglvl=4 (info)
-# - @var kdump_sysloglvl=4 (info)
+# - @var kdump_stdloglvl=3 (info)
+# - @var kdump_sysloglvl=3 (info)
# - @var kdump_kmsgloglvl=0 (no logging)
#
-# Logging levels: fatal(1),error(2),warn(3),info(4),debug(5),trace(6)
+# Logging levels: error(1),warn(2),info(3),debug(4)
#
# For example: the following configurations indicate that kdump messages will be printed
-# to console and journald for debugging case.
-# kdump_sysloglvl=5
-# kdump_stdloglvl=5
+# to console and journald, and this is also the current default log level(3).
+# kdump_sysloglvl=3
+# kdump_stdloglvl=3
diff --git a/kdump.sysconfig.ppc64le b/kdump.sysconfig.ppc64le
index 24279ff34211..ba3857434569 100644
--- a/kdump.sysconfig.ppc64le
+++ b/kdump.sysconfig.ppc64le
@@ -46,13 +46,13 @@ KDUMP_IMG_EXT=""
# - @var kdump_sysloglvl - logging level to syslog (by logger command)
# - @var kdump_kmsgloglvl - logging level to /dev/kmsg (only for boot-time)
# If any of the variables is not set, this function set it to default:
-# - @var kdump_stdloglvl=4 (info)
-# - @var kdump_sysloglvl=4 (info)
+# - @var kdump_stdloglvl=3 (info)
+# - @var kdump_sysloglvl=3 (info)
# - @var kdump_kmsgloglvl=0 (no logging)
#
-# Logging levels: fatal(1),error(2),warn(3),info(4),debug(5),trace(6)
+# Logging levels: error(1),warn(2),info(3),debug(4)
#
# For example: the following configurations indicate that kdump messages will be printed
-# to console and journald for debugging case.
-# kdump_sysloglvl=5
-# kdump_stdloglvl=5
+# to console and journald, and this is also the current default log level(3).
+# kdump_sysloglvl=3
+# kdump_stdloglvl=3
diff --git a/kdump.sysconfig.s390x b/kdump.sysconfig.s390x
index 5e1cb5a7ad89..78b1d4dcc129 100644
--- a/kdump.sysconfig.s390x
+++ b/kdump.sysconfig.s390x
@@ -47,13 +47,13 @@ KDUMP_IMG_EXT=""
# - @var kdump_sysloglvl - logging level to syslog (by logger command)
# - @var kdump_kmsgloglvl - logging level to /dev/kmsg (only for boot-time)
# If any of the variables is not set, this function set it to default:
-# - @var kdump_stdloglvl=4 (info)
-# - @var kdump_sysloglvl=4 (info)
+# - @var kdump_stdloglvl=3 (info)
+# - @var kdump_sysloglvl=3 (info)
# - @var kdump_kmsgloglvl=0 (no logging)
#
-# Logging levels: fatal(1),error(2),warn(3),info(4),debug(5),trace(6)
+# Logging levels: error(1),warn(2),info(3),debug(4)
#
# For example: the following configurations indicate that kdump messages will be printed
-# to console and journald for debugging case.
-# kdump_sysloglvl=5
-# kdump_stdloglvl=5
+# to console and journald, and this is also the current default log level(3).
+# kdump_sysloglvl=3
+# kdump_stdloglvl=3
diff --git a/kdump.sysconfig.x86_64 b/kdump.sysconfig.x86_64
index eb1c53824241..2c1966152853 100644
--- a/kdump.sysconfig.x86_64
+++ b/kdump.sysconfig.x86_64
@@ -44,13 +44,13 @@ KDUMP_IMG_EXT=""
# - @var kdump_sysloglvl - logging level to syslog (by logger command)
# - @var kdump_kmsgloglvl - logging level to /dev/kmsg (only for boot-time)
# If any of the variables is not set, this function set it to default:
-# - @var kdump_stdloglvl=4 (info)
-# - @var kdump_sysloglvl=4 (info)
+# - @var kdump_stdloglvl=3 (info)
+# - @var kdump_sysloglvl=3 (info)
# - @var kdump_kmsgloglvl=0 (no logging)
#
-# Logging levels: fatal(1),error(2),warn(3),info(4),debug(5),trace(6)
+# Logging levels: error(1),warn(2),info(3),debug(4)
#
# For example: the following configurations indicate that kdump messages will be printed
-# to console and journald for debugging case.
-# kdump_sysloglvl=5
-# kdump_stdloglvl=5
+# to console and journald, and this is also the current default log level(3).
+# kdump_sysloglvl=3
+# kdump_stdloglvl=3
--
2.17.1