[PATCH v2] kdumpctl: skip selinux-relabel for dracut_args --mount dump target

[Pingfan Liu]

When using "dracut_args --mount" to specify dump target, e.g. nfs like:
    path /
    core_collector makedumpfile -d 31
    dracut_args --mount "host:/path /var/crash nfs defaults"
kdump service should neither guarantees the correctness, nor relabels it.
Current code has a bug and kdump service will relabel "/", which is
meanless and takes very long time.

Signed-off-by: Pingfan Liu 
---
 kdumpctl | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kdumpctl b/kdumpctl
index d4e0050..094de02 100755
--- a/kdumpctl
+++ b/kdumpctl
@@ -1013,6 +1013,10 @@ path_to_be_relabeled()
    	fi
    fi

+	# users are expected to ensure its correctness of specifying mount info. So kdumpctl skips it.
+	if is_mount_in_dracut_args; then
+		return;
+	fi
    _path=$(get_save_path)
    # if $_path is masked by other mount, we will not relabel it.
    _rmnt=$(df $_mnt/$_path 2>/dev/null | tail -1 | awk '{ print $NF }')

[Dave Young]

Hi Pingfan,

On 11/29/17 at 11:17am, Pingfan Liu wrote:
> When using "dracut_args --mount" to specify dump target, e.g. nfs like:
>     path /
>     core_collector makedumpfile -d 31
>     dracut_args --mount "host:/path /var/crash nfs defaults"
> kdump service should neither guarantees the correctness, nor relabels it.
> Current code has a bug and kdump service will relabel "/", which is
> meanless and takes very long time.

It is better to add that because dracut_args dump targets are likely not
mounted so kdump service mistakenly relabel the rootfs.
> Signed-off-by: Pingfan Liu
>
> kdumpctl | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/kdumpctl b/kdumpctl
> index d4e0050..094de02 100755
> --- a/kdumpctl
> +++ b/kdumpctl
> @@ -1013,6 +1013,10 @@ path_to_be_relabeled()
>    	fi
>    fi
> # users are expected to ensure its correctness of specifying mount info. So kdumpctl skips it.

The comment is too long, since it is clear one can get it from the
function name so the comment line can be dropped.
> if is_mount_in_dracut_args; then
> return;
> fi
> _path=$(get_save_path)
> # if $_path is masked by other mount, we will not relabel it.
> _rmnt=$(df $_mnt/$_path 2>/dev/null | tail -1 | awk '{ print $NF }')
>
> -- 
> 2.7.4
> _______________________________________________
> kexec mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

Thanks
Dave